Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 26882,
    "url": "http://patches.dpdk.org/api/patches/26882/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170713094832.16904-1-michalx.k.jastrzebski@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170713094832.16904-1-michalx.k.jastrzebski@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170713094832.16904-1-michalx.k.jastrzebski@intel.com",
    "date": "2017-07-13T09:48:32",
    "name": "[dpdk-dev] app/testpmd: fix bonding initialization due to unproper name",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f6800553cf3c2ce6c00c6819d5c70f7e2df80a49",
    "submitter": {
        "id": 74,
        "url": "http://patches.dpdk.org/api/people/74/?format=api",
        "name": "Michal Jastrzebski",
        "email": "michalx.k.jastrzebski@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170713094832.16904-1-michalx.k.jastrzebski@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/26882/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/26882/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C06D25A6E;\n\tThu, 13 Jul 2017 11:49:23 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 2A2035905\n\tfor <dev@dpdk.org>; Thu, 13 Jul 2017 11:49:21 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jul 2017 02:49:20 -0700",
            "from unknown ([10.103.103.76])\n\tby fmsmga001.fm.intel.com with SMTP; 13 Jul 2017 02:49:17 -0700",
            "by  (sSMTP sendmail emulation); Thu, 13 Jul 2017 11:48:34 +0200"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.40,353,1496127600\"; d=\"scan'208\";\n\ta=\"1171979500\"",
        "From": "Michal Jastrzebski <michalx.k.jastrzebski@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "deepak.k.jain@intel.com, declan.doherty@intel.com,\n\tMichal Jastrzebski <michalx.k.jastrzebski@intel.com>",
        "Date": "Thu, 13 Jul 2017 11:48:32 +0200",
        "Message-Id": "<20170713094832.16904-1-michalx.k.jastrzebski@intel.com>",
        "X-Mailer": "git-send-email 2.12.2",
        "Subject": "[dpdk-dev] [PATCH] app/testpmd: fix bonding initialization due to\n\tunproper name",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "when creating a bond device in testpmd, a name for a device must meet\nthe correct convention described in the documentation:\nThe device name must start with the net_bonding prefix\nfollowed by numbers or letters.\nChange for ALB mempool allocation - mem_name was too long.\n\nFixes: 9bf4901d1a11 (\"bus/vdev: remove probe with driver name option\")\n\nSigned-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>\n---\n app/test-pmd/cmdline.c                 |    2 +-\n drivers/net/bonding/rte_eth_bond_alb.c |    2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex d4ff608..23361bc 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -4900,7 +4900,7 @@ static void cmd_create_bonded_device_parsed(void *parsed_result,\n \t\treturn;\n \t}\n \n-\tsnprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, \"net_bond_testpmd_%d\",\n+\tsnprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, \"net_bonding_testpmd_%d\",\n \t\t\tbond_dev_num++);\n \n \t/* Create a new bonded device. */\ndiff --git a/drivers/net/bonding/rte_eth_bond_alb.c b/drivers/net/bonding/rte_eth_bond_alb.c\nindex 7f6884d..d9d3749 100644\n--- a/drivers/net/bonding/rte_eth_bond_alb.c\n+++ b/drivers/net/bonding/rte_eth_bond_alb.c\n@@ -80,7 +80,7 @@\n \t\t * The value is chosen to be cache aligned.\n \t\t */\n \t\tdata_size = 256 + RTE_PKTMBUF_HEADROOM;\n-\t\tsnprintf(mem_name, sizeof(mem_name), \"%s_MODE6\",\n+\t\tsnprintf(mem_name, sizeof(mem_name), \"%s_ALB\",\n \t\t\t\tbond_dev->device->name);\n \t\tinternals->mode6.mempool = rte_pktmbuf_pool_create(mem_name,\n \t\t\t512 * RTE_MAX_ETHPORTS,\n",
    "prefixes": [
        "dpdk-dev"
    ]
}