Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26669/?format=api
{ "id": 26669, "url": "http://patches.dpdk.org/api/patches/26669/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d721f3de73824c767b3e7df5aba378e4f35c49be.1499563730.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d721f3de73824c767b3e7df5aba378e4f35c49be.1499563730.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d721f3de73824c767b3e7df5aba378e4f35c49be.1499563730.git.gaetan.rivet@6wind.com", "date": "2017-07-09T01:45:45", "name": "[dpdk-dev,9/9] bus: remove useless plug parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e106bf1f396765aa4fe8d9c2a90e7ca9c254f7fb", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d721f3de73824c767b3e7df5aba378e4f35c49be.1499563730.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/26669/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/26669/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2AF997CC0;\n\tSun, 9 Jul 2017 03:46:21 +0200 (CEST)", "from mail-wr0-f181.google.com (mail-wr0-f181.google.com\n\t[209.85.128.181]) by dpdk.org (Postfix) with ESMTP id D3FF458D1\n\tfor <dev@dpdk.org>; Sun, 9 Jul 2017 03:46:08 +0200 (CEST)", "by mail-wr0-f181.google.com with SMTP id r103so93871909wrb.0\n\tfor <dev@dpdk.org>; Sat, 08 Jul 2017 18:46:08 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\th130sm2430609wmd.34.2017.07.08.18.46.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 08 Jul 2017 18:46:07 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=r1SmDurJN4ZUUeceHuKLI+qsosk01a/PaH9tCMr1DyY=;\n\tb=e2s2Woc4/znzNz0YTB0DE4djvi8FFTvwa4PI14Yl+LczQqAzGDOD/y9Q3M79xh+Mqu\n\tn92eVoPDdiPEhiyIaXmVmqC4qccYdxt9/X7S+dY6VmWQIok08UC1eqwAHeGZKOI8DfXm\n\t87X5lgti8tiER2ggp1iTDW33ACun3cwUmPwrHRihXzIyUbqS295GqTxZQmkwOfLcQobl\n\tu/7OWGoMMW/zUpIwpagusbBDYOj7HrheyPRDChmJ69DJ/uGVIbRBQyIesk1QXA83KQjH\n\tF4bIQoDg3wUKzIFNwRQx+5JKmvGzaOPgPgnKTglLB30vkrOfSbYDjNrWixqXaomJfWWm\n\t4B6g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=r1SmDurJN4ZUUeceHuKLI+qsosk01a/PaH9tCMr1DyY=;\n\tb=cN8+lqOgjLXr2lEy4jOpMR5L7k8ycqF2rB65hb6vHq7Cyri8i6wCA3yXMZr7yJjcli\n\t7YzghLBexns2mWD73OoupAq9jWqAAN6oyIKfomsWqGBbI/YIcZ3FYdh+3hJxHHQ2JPKu\n\tfOk+vskLxNiAYd3ct2BDDquPlwoinU4U+qE2fzhFA2J5cCpC6P8AmpjINkRsT02pI7A0\n\ttMNxS0BrRCtzwxyM3iAwgcGFeQJRfudmGWSIS1zxzJRtiJgIFwwDngkfGjhVhDxPmHa8\n\tmjVDHCyZqPUcBu4Rby4Su3kfNn/cOHjygkUnM1LBh0OrjKHUJUA175+jZCjCF8fgQqB6\n\tO2AA==", "X-Gm-Message-State": "AIVw110+/C1GuaWHxeWqLwPp4i3sjsUzusfUn4JegKTyKA/x0GeeDTtX\n\tm6QtjPQGLTR0NF9sYOk=", "X-Received": "by 10.223.134.207 with SMTP id 15mr4480307wry.127.1499564768297; \n\tSat, 08 Jul 2017 18:46:08 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Sun, 9 Jul 2017 03:45:45 +0200", "Message-Id": "<d721f3de73824c767b3e7df5aba378e4f35c49be.1499563730.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1499563730.git.gaetan.rivet@6wind.com>", "<cover.1499563730.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1499563730.git.gaetan.rivet@6wind.com>", "<cover.1499563730.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 9/9] bus: remove useless plug parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The prior scan should link the relevant rte_devargs to the newly\nallocated rte_device. As such, it is useless to pass device arguments to\nthe plug callback. Those arguments are available within the devargs\nfield of the rte_device structure.\n\nFixes: 7c8810f43f6e (\"bus: introduce device plug/unplug\")\nFixes: 00e62aae69c0 (\"bus/pci: implement plug/unplug operations\")\nFixes: a3ee360f4440 (\"eal: add hotplug add/remove device\")\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/eal_common_dev.c | 2 +-\n lib/librte_eal/common/eal_common_pci.c | 2 +-\n lib/librte_eal/common/eal_common_vdev.c | 2 +-\n lib/librte_eal/common/include/rte_bus.h | 6 +-----\n 4 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex 143c231..42e91db 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -188,7 +188,7 @@ rte_eal_hotplug_add(const char *busname, const char *devname,\n \t\tgoto err_devarg;\n \t}\n \n-\tret = bus->plug(dev, devargs);\n+\tret = bus->plug(dev);\n \tif (ret) {\n \t\tRTE_LOG(ERR, EAL, \"Driver cannot attach the device (%s)\\n\",\n \t\t\tdev->name);\ndiff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex 7e82a31..a64d76c 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -533,7 +533,7 @@ pci_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n }\n \n static int\n-pci_plug(struct rte_device *dev, const char *devargs __rte_unused)\n+pci_plug(struct rte_device *dev)\n {\n \treturn pci_probe_all_drivers(RTE_DEV_TO_PCI(dev));\n }\ndiff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c\nindex f8b48b5..a2cdfa4 100644\n--- a/lib/librte_eal/common/eal_common_vdev.c\n+++ b/lib/librte_eal/common/eal_common_vdev.c\n@@ -354,7 +354,7 @@ vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n }\n \n static int\n-vdev_plug(struct rte_device *dev, const char *args __rte_unused)\n+vdev_plug(struct rte_device *dev)\n {\n \treturn vdev_probe_all_drivers(RTE_DEV_TO_VDEV(dev));\n }\ndiff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h\nindex 37cc230..167635a 100644\n--- a/lib/librte_eal/common/include/rte_bus.h\n+++ b/lib/librte_eal/common/include/rte_bus.h\n@@ -114,15 +114,11 @@ typedef struct rte_device *\n * @param dev\n *\tDevice pointer that was returned by a previous call to find_device.\n *\n- * @param devargs\n- *\tDevice declaration.\n- *\n * @return\n *\t0 on success.\n *\t!0 on error.\n */\n-typedef int (*rte_bus_plug_t)(struct rte_device *dev,\n-\t\t\t const char *devargs);\n+typedef int (*rte_bus_plug_t)(struct rte_device *dev);\n \n /**\n * Implementation specific remove function which is responsible for unlinking\n", "prefixes": [ "dpdk-dev", "9/9" ] }