Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26653/?format=api
http://patches.dpdk.org/api/patches/26653/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1499527015-31958-1-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1499527015-31958-1-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1499527015-31958-1-git-send-email-arybchenko@solarflare.com", "date": "2017-07-08T15:16:55", "name": "[dpdk-dev] net/sfc: request MAC stats upload immediately on port start", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f1794ab84e8a377b8d7f2239f3ea4ffc909db292", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1499527015-31958-1-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/26653/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/26653/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C3C482B9E;\n\tSat, 8 Jul 2017 17:17:26 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id ACD3F16E;\n\tSat, 8 Jul 2017 17:17:25 +0200 (CEST)", "from pure.maildistiller.com (unknown [10.110.50.29])\n\tby dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server)\n\twith ESMTP id 4668360067; Sat, 8 Jul 2017 15:17:25 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.49.251])\n\tby pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id A61D36004C; Sat, 8 Jul 2017 15:17:24 +0000 (UTC)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 894762006D; Sat, 8 Jul 2017 15:17:24 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Sat, 8 Jul 2017 08:17:21 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Sat, 8 Jul 2017 08:17:21 -0700", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv68FHIg3000851; Sat, 8 Jul 2017 16:17:18 +0100", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv68FHIji032051; Sat, 8 Jul 2017 16:17:18 +0100" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>, <stable@dpdk.org>", "Date": "Sat, 8 Jul 2017 16:16:55 +0100", "Message-ID": "<1499527015-31958-1-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1499527045-jxL2evzQ092K", "Subject": "[dpdk-dev] [PATCH] net/sfc: request MAC stats upload immediately on\n\tport start", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nIf MAC stats refresh is arranged to be done by periodic DMA,\nthe first DMA transaction is unlikely to occur right on the\nport start; if the user tries to get stats right after port\nstart and before the transaction occurs, bogus figures will\nbe collected; a one-off stats upload on port start is a fix\n\nFixes: 1caab2f1e684 (\"net/sfc: add basic statistics\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_port.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c\nindex e7eea9f..ba2284f 100644\n--- a/drivers/net/sfc/sfc_port.c\n+++ b/drivers/net/sfc/sfc_port.c\n@@ -245,6 +245,18 @@ sfc_port_start(struct sfc_adapter *sa)\n \t\t}\n \t}\n \n+\tif ((port->mac_stats_update_period_ms != 0) &&\n+\t port->mac_stats_periodic_dma_supported) {\n+\t\t/*\n+\t\t * Request an explicit MAC stats upload immediately to\n+\t\t * preclude bogus figures readback if the user decides\n+\t\t * to read stats before periodic DMA is really started\n+\t\t */\n+\t\trc = efx_mac_stats_upload(sa->nic, &port->mac_stats_dma_mem);\n+\t\tif (rc != 0)\n+\t\t\tgoto fail_mac_stats_upload;\n+\t}\n+\n \tsfc_log_init(sa, \"disable MAC drain\");\n \trc = efx_mac_drain(sa->nic, B_FALSE);\n \tif (rc != 0)\n@@ -265,6 +277,7 @@ sfc_port_start(struct sfc_adapter *sa)\n \t(void)efx_mac_stats_periodic(sa->nic, &port->mac_stats_dma_mem,\n \t\t\t\t 0, B_FALSE);\n \n+fail_mac_stats_upload:\n fail_mac_stats_periodic:\n fail_mcast_address_list_set:\n fail_mac_filter_set:\n", "prefixes": [ "dpdk-dev" ] }{ "id": 26653, "url": "