Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26500/?format=api
{ "id": 26500, "url": "http://patches.dpdk.org/api/patches/26500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170705052620.34223-9-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170705052620.34223-9-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170705052620.34223-9-pablo.de.lara.guarch@intel.com", "date": "2017-07-05T05:26:16", "name": "[dpdk-dev,v4,08/12] cryptodev: remove mempool from session", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "604d518e7a0ed6e2fe737143331d4896ac9626dc", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170705052620.34223-9-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/26500/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/26500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B85497CC0;\n\tWed, 5 Jul 2017 15:27:28 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id B9F7B7CB0\n\tfor <dev@dpdk.org>; Wed, 5 Jul 2017 15:27:21 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jul 2017 06:27:21 -0700", "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby orsmga003.jf.intel.com with ESMTP; 05 Jul 2017 06:27:18 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,312,1496127600\"; d=\"scan'208\";a=\"988933509\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com, zbigniew.bodek@caviumnetworks.com,\n\tjerin.jacob@caviumnetworks.com, akhil.goyal@nxp.com,\n\themant.agrawal@nxp.com, fiona.trahe@intel.com, john.griffin@intel.com,\n\tdeepak.k.jain@intel.com", "Cc": "dev@dpdk.org, Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Wed, 5 Jul 2017 06:26:16 +0100", "Message-Id": "<20170705052620.34223-9-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170705052620.34223-1-pablo.de.lara.guarch@intel.com>", "References": "<20170702155719.66530-1-pablo.de.lara.guarch@intel.com>\n\t<20170705052620.34223-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 08/12] cryptodev: remove mempool from session", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>\n\nMempool pointer can be obtained from the object itself,\nwhich means that it is not required to actually store the pointer\nin the session.\n\nSigned-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n doc/guides/rel_notes/release_17_08.rst | 1 +\n lib/librte_cryptodev/rte_cryptodev.c | 7 +++----\n lib/librte_cryptodev/rte_cryptodev.h | 6 ------\n 3 files changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst\nindex c3d3b34..74275e0 100644\n--- a/doc/guides/rel_notes/release_17_08.rst\n+++ b/doc/guides/rel_notes/release_17_08.rst\n@@ -210,6 +210,7 @@ API Changes\n the new parameter ``device id``.\n * ``dev_id`` field has been removed from ``rte_cryptodev_sym_session`` structure.\n * ``driver_id`` field has been removed from ``rte_cryptodev_sym_session`` structure.\n+ * Mempool pointer ``mp`` has been removed from ``rte_cryptodev_sym_session`` structure.\n \n \n ABI Changes\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex c2123cd..dfced85 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -1087,8 +1087,6 @@ rte_cryptodev_sym_session_init(struct rte_mempool *mp,\n {\n \tmemset(sess, 0, mp->elt_size);\n \n-\tsess->mp = mp;\n-\n \tif (dev->dev_ops->session_initialize)\n \t\t(*dev->dev_ops->session_initialize)(mp, sess);\n }\n@@ -1126,7 +1124,7 @@ rte_cryptodev_sym_session_create(uint8_t dev_id,\n \t\t\t\tdev_id);\n \n \t\t/* Return session to mempool */\n-\t\trte_mempool_put(sess->mp, _sess);\n+\t\trte_mempool_put(dev->data->session_pool, _sess);\n \t\treturn NULL;\n \t}\n \n@@ -1198,7 +1196,8 @@ rte_cryptodev_sym_session_free(uint8_t dev_id,\n \tdev->dev_ops->session_clear(dev, (void *)sess->_private);\n \n \t/* Return session to mempool */\n-\trte_mempool_put(sess->mp, (void *)sess);\n+\tstruct rte_mempool *mp = rte_mempool_from_obj(sess);\n+\trte_mempool_put(mp, (void *)sess);\n \n \treturn NULL;\n }\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex 0fb5608..508c672 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -883,12 +883,6 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,\n /** Cryptodev symmetric crypto session */\n struct rte_cryptodev_sym_session {\n \tRTE_STD_C11\n-\tstruct {\n-\t\tstruct rte_mempool *mp;\n-\t\t/**< Mempool session allocated from */\n-\t} __rte_aligned(8);\n-\t/**< Public symmetric session details */\n-\n \t__extension__ char _private[0];\n \t/**< Private session material */\n };\n", "prefixes": [ "dpdk-dev", "v4", "08/12" ] }