Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26100/?format=api
{ "id": 26100, "url": "http://patches.dpdk.org/api/patches/26100/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170630142021.50855-8-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170630142021.50855-8-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170630142021.50855-8-ajit.khaparde@broadcom.com", "date": "2017-06-30T14:20:19", "name": "[dpdk-dev,v2,7/9] net/bnxt: fix autoneg on 10GBase-T links", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ccfb369cc73c0bf402b8fd89262f97ea09e77a44", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170630142021.50855-8-ajit.khaparde@broadcom.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/26100/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/26100/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 901497CC7;\n\tFri, 30 Jun 2017 16:20:55 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (lpdvrndsmtp01.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 024BF7CAA\n\tfor <dev@dpdk.org>; Fri, 30 Jun 2017 16:20:36 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 5EE9C30C029;\n\tFri, 30 Jun 2017 07:20:34 -0700 (PDT)", "from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.85.248.104])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id E688081EAB;\n\tFri, 30 Jun 2017 07:20:33 -0700 (PDT)" ], "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tStephen Hurd <stephen.hurd@broadcom.com>", "Date": "Fri, 30 Jun 2017 09:20:19 -0500", "Message-Id": "<20170630142021.50855-8-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.10.1 (Apple Git-78)", "In-Reply-To": "<20170630142021.50855-1-ajit.khaparde@broadcom.com>", "References": "<096daf46-dd9f-f84b-de0d-9a4e87a8d461@intel.com>\n\t<20170630142021.50855-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 7/9] net/bnxt: fix autoneg on 10GBase-T links", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are not passing proper speed mask causing autoneg to not work\nproperly on 10GBase-T links. Use supported speeds from phy_qcfg\nfor auto mask to fix this.\n\nFixes: 7bc8e9a227cc (\"net/bnxt: support async link notification\")\n\nSigned-off-by: Stephen Hurd <stephen.hurd@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n--\nv1->v2: split the patch into relevant patches based on code review\n---\n drivers/net/bnxt/bnxt_hwrm.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 9b00b60..85ef0e3 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1787,12 +1787,16 @@ static int bnxt_valid_link_speed(uint32_t link_speed, uint8_t port_id)\n \treturn 0;\n }\n \n-static uint16_t bnxt_parse_eth_link_speed_mask(uint32_t link_speed)\n+static uint16_t\n+bnxt_parse_eth_link_speed_mask(struct bnxt *bp, uint32_t link_speed)\n {\n \tuint16_t ret = 0;\n \n-\tif (link_speed == ETH_LINK_SPEED_AUTONEG)\n+\tif (link_speed == ETH_LINK_SPEED_AUTONEG) {\n+\t\tif (bp->link_info.support_speeds)\n+\t\t\treturn bp->link_info.support_speeds;\n \t\tlink_speed = BNXT_SUPPORTED_SPEEDS;\n+\t}\n \n \tif (link_speed & ETH_LINK_SPEED_100M)\n \t\tret |= HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_MASK_100MB;\n@@ -1926,7 +1930,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)\n \t\tlink_req.auto_mode =\n \t\t\t\tHWRM_PORT_PHY_CFG_INPUT_AUTO_MODE_SPEED_MASK;\n \t\tlink_req.auto_link_speed_mask =\n-\t\t\tbnxt_parse_eth_link_speed_mask(dev_conf->link_speeds);\n+\t\t\tbnxt_parse_eth_link_speed_mask(bp,\n+\t\t\t\t\t\t dev_conf->link_speeds);\n \t} else {\n \t\tlink_req.phy_flags |= HWRM_PORT_PHY_CFG_INPUT_FLAGS_FORCE;\n \t\tlink_req.link_speed = speed;\n", "prefixes": [ "dpdk-dev", "v2", "7/9" ] }