Patch Comment List
List patch comments
GET /api/patches/261/comments/?format=api
[ { "id": 668, "web_url": "http://patches.dpdk.org/comment/668/", "msgid": "<E115CCD9D858EF4F90C690B0DCB4D89722614382@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/E115CCD9D858EF4F90C690B0DCB4D89722614382@IRSMSX108.ger.corp.intel.com", "date": "2014-09-05T16:21:20", "subject": "Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson\n> Sent: Thursday, August 28, 2014 4:43 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n> mbuf struct\n> \n> The vlan_macip structure combined a vlan tag id with l2 and l3 headers\n> lengths for tracking offloads. However, this structure was only used as\n> a unit by the e1000 and ixgbe drivers, not generally.\n> \n> This patch removes the structure from the mbuf header and places the\n> fields into the mbuf structure directly at the required point, without\n> any net effect on the structure layout. This allows us to treat the vlan\n> tags and header length fields as separate for future mbuf changes. The\n> drivers which were written to use the combined structure still do so,\n> using a driver-local definition of it.\n> \n> Changes in V2:\n> * None\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAfter applying this patch, I see a performance degradation (around 5%) using testpmd with the default RX path, so this may require a v3 patch.\n\nThanks,\nPablo", "headers": { "Return-Path": "<pablo.de.lara.guarch@intel.com>", "Received": [ "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id DB9B8A547\n\tfor <dev@dpdk.org>; Fri, 5 Sep 2014 18:16:48 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 05 Sep 2014 09:21:23 -0700", "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby orsmga001.jf.intel.com with ESMTP; 05 Sep 2014 09:21:22 -0700", "from irsmsx152.ger.corp.intel.com (163.33.192.66) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Fri, 5 Sep 2014 17:21:21 +0100", "from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by\n\tIRSMSX152.ger.corp.intel.com ([169.254.6.48]) with mapi id\n\t14.03.0195.001; Fri, 5 Sep 2014 17:21:21 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,474,1406617200\"; d=\"scan'208\";a=\"568943642\"", "From": "\"De Lara Guarch, Pablo\" <pablo.de.lara.guarch@intel.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "Thread-Index": "AQHPwtorTR+55KA+OUysoJ0C3dEfnZvyxCMg", "Date": "Fri, 5 Sep 2014 16:21:20 +0000", "Message-ID": "<E115CCD9D858EF4F90C690B0DCB4D89722614382@IRSMSX108.ger.corp.intel.com>", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-7-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409240559-14447-7-git-send-email-bruce.richardson@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Sep 2014 16:16:49 -0000" }, "addressed": null }, { "id": 669, "web_url": "http://patches.dpdk.org/comment/669/", "msgid": "<59AF69C657FD0841A61C55336867B5B0343EF578@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B0343EF578@IRSMSX103.ger.corp.intel.com", "date": "2014-09-07T19:40:01", "subject": "Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "> -----Original Message-----\n> From: De Lara Guarch, Pablo\n> Sent: Friday, September 05, 2014 5:21 PM\n> To: Richardson, Bruce; dev@dpdk.org\n> Subject: RE: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n> mbuf struct\n> \n> \n> \n> > -----Original Message-----\n> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson\n> > Sent: Thursday, August 28, 2014 4:43 PM\n> > To: dev@dpdk.org\n> > Subject: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n> > mbuf struct\n> >\n> > The vlan_macip structure combined a vlan tag id with l2 and l3 headers\n> > lengths for tracking offloads. However, this structure was only used as\n> > a unit by the e1000 and ixgbe drivers, not generally.\n> >\n> > This patch removes the structure from the mbuf header and places the\n> > fields into the mbuf structure directly at the required point, without\n> > any net effect on the structure layout. This allows us to treat the vlan\n> > tags and header length fields as separate for future mbuf changes. The\n> > drivers which were written to use the combined structure still do so,\n> > using a driver-local definition of it.\n> >\n> > Changes in V2:\n> > * None\n> >\n> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> \n> After applying this patch, I see a performance degradation (around 5%) using\n> testpmd with the default RX path, so this may require a v3 patch.\n> \n> Thanks,\n> Pablo\n\nThanks for Pablo for flagging this. Since no fields are moved in the structure, merely flattened, I suspect any degradation must come from having the l2_len and l3_len bit fields split out. I'll do up a v3 with a union to allow them to be assigned simultaneously and see if it helps things. Fast-path is unaffected in my tests.\n\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5C16E58F1;\n\tSun, 7 Sep 2014 21:35:26 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id F24F23989\n\tfor <dev@dpdk.org>; Sun, 7 Sep 2014 21:35:23 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 07 Sep 2014 12:31:35 -0700", "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2014 12:35:09 -0700", "from irsmsx152.ger.corp.intel.com (163.33.192.66) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Sun, 7 Sep 2014 20:40:02 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by\n\tIRSMSX152.ger.corp.intel.com ([169.254.6.48]) with mapi id\n\t14.03.0195.001; Sun, 7 Sep 2014 20:40:02 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"382697561\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "\"De Lara Guarch, Pablo\" <pablo.de.lara.guarch@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "Thread-Index": "AQHPySVub/fa/VTREkqBfdqRu3OwlJv2E+lA", "Date": "Sun, 7 Sep 2014 19:40:01 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343EF578@IRSMSX103.ger.corp.intel.com>", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-7-git-send-email-bruce.richardson@intel.com>\n\t<E115CCD9D858EF4F90C690B0DCB4D89722614382@IRSMSX108.ger.corp.intel.com>", "In-Reply-To": "<E115CCD9D858EF4F90C690B0DCB4D89722614382@IRSMSX108.ger.corp.intel.com>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.182]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 676, "web_url": "http://patches.dpdk.org/comment/676/", "msgid": "<540D71BF.8050006@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/540D71BF.8050006@6wind.com", "date": "2014-09-08T09:07:11", "subject": "Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf struct", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "content": "Hi Bruce,\n\nJust small typos below.\n\nOn 08/28/2014 05:42 PM, Bruce Richardson wrote:\n> The vlan_macip structure combined a vlan tag id with l2 and l3 headers\n> lengths for tracking offloads. However, this structure was only used as\n> a unit by the e1000 and ixgbe drivers, not generally.\n> \n> This patch removes the structure from the mbuf header and places the\n> fields into the mbuf structure directly at the required point, without\n> any net effect on the structure layout. This allows us to treat the vlan\n> tags and header length fields as separate for future mbuf changes. The\n> drivers which were written to use the combined structure still do so,\n> using a driver-local definition of it.\n> \n> Changes in V2:\n> * None\n> \n> [...]\n> \n> diff --git a/lib/librte_pmd_e1000/em_rxtx.c b/lib/librte_pmd_e1000/em_rxtx.c\n> index 074c9b3..4f46bdf 100644\n> --- a/lib/librte_pmd_e1000/em_rxtx.c\n> +++ b/lib/librte_pmd_e1000/em_rxtx.c\n> @@ -144,13 +144,34 @@ enum {\n> \tEM_CTX_NUM = 1, /**< CTX NUM */\n> };\n> \n> +/** Offload features */\n> +union em_vlan_macip {\n> +\tuint32_t data;\n> +\tstruct {\n> +\t\tuint16_t l3_len:9; /**< L3 (IP) Header Length. */\n> +\t\tuint16_t l2_len:7; /**< L2 (MAC) Header Length. */\n> +\t\tuint16_t vlan_tci;\n> +\t\t/**< VLAN Tag Control Identifier (CPU order). */\n> +\t} f;\n> +};\n> +\n> +/*\n> + * Compare mask for vlan_macip_len.data,\n> + * should be in sync with em_vlan_macip.f layout.\n> + * */\n> +#define TX_VLAN_CMP_MASK 0xFFFF0000 /**< VLAN length - 16-bits. */\n> +#define TX_MAC_LEN_CMP_MASK 0x0000FE00 /**< MAC length - 7-bits. */\n> +#define TX_IP_LEN_CMP_MASK 0x000001FF /**< IP length - 9-bits. */\n> +/**< MAC+IP length. */\n> +#define TX_MACIP_LEN_CMP_MASK (TX_MAC_LEN_CMP_MASK | TX_IP_LEN_CMP_MASK)\n> +\n\nI think the doxygen syntax \"/**<\" is only used for comments that are\nafter the name. It was already like this before your patch (in\nrte_mbuf.h), but maybe it's a good occasion to fix this typo.\nThere is the same in igb and ixgbe.\n\n> /**\n> * Structure to check if new context need be built\n> */\n> struct em_ctx_info {\n> \tuint16_t flags; /**< ol_flags related to context build. */\n> \tuint32_t cmp_mask; /**< compare mask */\n> -\tunion rte_vlan_macip hdrlen; /**< L2 and L3 header lenghts */\n> +\tunion em_vlan_macip hdrlen; /**< L2 and L3 header lenghts */\n> };\n\nThe comment is not aligned with the others.\n\nAcked-by: Olivier Matz <olivier.matz@6wind.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B788EB39D;\n\tMon, 8 Sep 2014 11:02:27 +0200 (CEST)", "from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])\n\tby dpdk.org (Postfix) with ESMTP id 5536EB39C\n\tfor <dev@dpdk.org>; Mon, 8 Sep 2014 11:02:25 +0200 (CEST)", "from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]\n\thelo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.80) (envelope-from <olivier.matz@6wind.com>)\n\tid 1XQuxN-0007fR-FT; Mon, 08 Sep 2014 11:09:59 +0200" ], "Message-ID": "<540D71BF.8050006@6wind.com>", "Date": "Mon, 08 Sep 2014 11:07:11 +0200", "From": "Olivier MATZ <olivier.matz@6wind.com>", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0", "MIME-Version": "1.0", "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-7-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409240559-14447-7-git-send-email-bruce.richardson@intel.com>", "Content-Type": "text/plain; charset=ISO-8859-1", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf struct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]