Patch Comment List
List patch comments
GET /api/patches/260/comments/?format=api
[ { "id": 664, "web_url": "http://patches.dpdk.org/comment/664/", "msgid": "<E115CCD9D858EF4F90C690B0DCB4D8972261432B@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/E115CCD9D858EF4F90C690B0DCB4D8972261432B@IRSMSX108.ger.corp.intel.com", "date": "2014-09-05T16:15:06", "subject": "Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson\n> Sent: Thursday, August 28, 2014 4:43 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf\n> \n> From: Olivier Matz <olivier.matz@6wind.com>\n> \n> The initial role of rte_ctrlmbuf is to carry generic messages (data\n> pointer + data length) but it's not used by the DPDK or it applications.\n> Keeping it implies:\n> - loosing 1 byte in the rte_mbuf structure\n> - having some dead code rte_mbuf.[ch]\n> \n> This patch removes this feature. Thanks to it, it is now possible to\n> simplify the rte_mbuf structure by merging the rte_pktmbuf structure\n> in it. This is done in next commit.\n> \n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> \n> * Updated patch to HEAD.\n> * Modified patch to retain the old function names for ctrl mbufs as\n> macros. This helps with app compatibility, and allows the concept\n> of a control mbuf to be reintroduced via a single-bit flag in\n> a future change.\n> * Updated the packet framework ip_pipeline example application to\n> work following this change.\n> \n> Changes in v2:\n> * Fixed whitespace errors introduced by this patch flagged by checkpatch\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAcked-by Pablo de Lara <pablo.de.lara.guarch@intel.com>", "headers": { "Return-Path": "<pablo.de.lara.guarch@intel.com>", "Received": [ "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id CDC73A547\n\tfor <dev@dpdk.org>; Fri, 5 Sep 2014 18:10:25 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 05 Sep 2014 09:15:11 -0700", "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Sep 2014 09:15:08 -0700", "from irsmsx109.ger.corp.intel.com (163.33.3.23) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Fri, 5 Sep 2014 17:15:07 +0100", "from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by\n\tIRSMSX109.ger.corp.intel.com ([169.254.13.200]) with mapi id\n\t14.03.0195.001; Fri, 5 Sep 2014 17:15:07 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,474,1406617200\"; d=\"scan'208\";a=\"595179751\"", "From": "\"De Lara Guarch, Pablo\" <pablo.de.lara.guarch@intel.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "Thread-Index": "AQHPwtbK37/Er7+iYEmJzJPNGBA/yZvyw1KA", "Date": "Fri, 5 Sep 2014 16:15:06 +0000", "Message-ID": "<E115CCD9D858EF4F90C690B0DCB4D8972261432B@IRSMSX108.ger.corp.intel.com>", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-4-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409240559-14447-4-git-send-email-bruce.richardson@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Sep 2014 16:10:26 -0000" }, "addressed": null }, { "id": 673, "web_url": "http://patches.dpdk.org/comment/673/", "msgid": "<540D671B.9040104@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/540D671B.9040104@6wind.com", "date": "2014-09-08T08:21:47", "subject": "Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "content": "Hi Bruce,\n\nOn 08/28/2014 05:42 PM, Bruce Richardson wrote:\n> From: Olivier Matz <olivier.matz@6wind.com>\n> \n> The initial role of rte_ctrlmbuf is to carry generic messages (data\n> pointer + data length) but it's not used by the DPDK or it applications.\n> Keeping it implies:\n> - loosing 1 byte in the rte_mbuf structure\n> - having some dead code rte_mbuf.[ch]\n> \n> This patch removes this feature. Thanks to it, it is now possible to\n> simplify the rte_mbuf structure by merging the rte_pktmbuf structure\n> in it. This is done in next commit.\n> \n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> \n> * Updated patch to HEAD.\n> * Modified patch to retain the old function names for ctrl mbufs as\n> macros. This helps with app compatibility, and allows the concept\n> of a control mbuf to be reintroduced via a single-bit flag in\n> a future change.\n> * Updated the packet framework ip_pipeline example application to\n> work following this change.\n> \n> Changes in v2:\n> * Fixed whitespace errors introduced by this patch flagged by checkpatch\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nTo be honest, I'm not convinced that keeping the old function names\nis really required, but I suppose you had good reasons to reintroduce\nthem. Just for information, is it for compatibility purpose or is there\na real wish to reintroduce a sort of control mbuf in the future ?\n\nAcked-by: Olivier Matz <olivier.matz@6wind.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 252C468A8;\n\tMon, 8 Sep 2014 10:17:01 +0200 (CEST)", "from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])\n\tby dpdk.org (Postfix) with ESMTP id 0E606683A\n\tfor <dev@dpdk.org>; Mon, 8 Sep 2014 10:16:59 +0200 (CEST)", "from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]\n\thelo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.80) (envelope-from <olivier.matz@6wind.com>)\n\tid 1XQuFR-0007eW-FR; Mon, 08 Sep 2014 10:24:32 +0200" ], "Message-ID": "<540D671B.9040104@6wind.com>", "Date": "Mon, 08 Sep 2014 10:21:47 +0200", "From": "Olivier MATZ <olivier.matz@6wind.com>", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0", "MIME-Version": "1.0", "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-4-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409240559-14447-4-git-send-email-bruce.richardson@intel.com>", "Content-Type": "text/plain; charset=ISO-8859-1", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 708, "web_url": "http://patches.dpdk.org/comment/708/", "msgid": "<59AF69C657FD0841A61C55336867B5B0343EFA22@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B0343EFA22@IRSMSX103.ger.corp.intel.com", "date": "2014-09-09T08:48:37", "subject": "Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "> -----Original Message-----\n> From: Olivier MATZ [mailto:olivier.matz@6wind.com]\n> Sent: Monday, September 08, 2014 9:22 AM\n> To: Richardson, Bruce; dev@dpdk.org\n> Subject: Re: [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf\n> \n> Hi Bruce,\n> \n> On 08/28/2014 05:42 PM, Bruce Richardson wrote:\n> > From: Olivier Matz <olivier.matz@6wind.com>\n> >\n> > The initial role of rte_ctrlmbuf is to carry generic messages (data\n> > pointer + data length) but it's not used by the DPDK or it applications.\n> > Keeping it implies:\n> > - loosing 1 byte in the rte_mbuf structure\n> > - having some dead code rte_mbuf.[ch]\n> >\n> > This patch removes this feature. Thanks to it, it is now possible to\n> > simplify the rte_mbuf structure by merging the rte_pktmbuf structure\n> > in it. This is done in next commit.\n> >\n> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> >\n> > * Updated patch to HEAD.\n> > * Modified patch to retain the old function names for ctrl mbufs as\n> > macros. This helps with app compatibility, and allows the concept\n> > of a control mbuf to be reintroduced via a single-bit flag in\n> > a future change.\n> > * Updated the packet framework ip_pipeline example application to\n> > work following this change.\n> >\n> > Changes in v2:\n> > * Fixed whitespace errors introduced by this patch flagged by checkpatch\n> >\n> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> \n> To be honest, I'm not convinced that keeping the old function names\n> is really required, but I suppose you had good reasons to reintroduce\n> them. Just for information, is it for compatibility purpose or is there\n> a real wish to reintroduce a sort of control mbuf in the future ?\n> \n> Acked-by: Olivier Matz <olivier.matz@6wind.com>\n\nCompatibility primarily. However, it's a useful enough concept, and can be controlled by having a single-bit flag as done in my second patch set.\n\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8F0DEB3AB;\n\tTue, 9 Sep 2014 10:44:46 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 6AFDDB3AA\n\tfor <dev@dpdk.org>; Tue, 9 Sep 2014 10:44:45 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 09 Sep 2014 01:49:47 -0700", "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby fmsmga002.fm.intel.com with ESMTP; 09 Sep 2014 01:49:23 -0700", "from irsmsx154.ger.corp.intel.com (163.33.192.96) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 9 Sep 2014 09:48:38 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by\n\tIRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id\n\t14.03.0195.001; Tue, 9 Sep 2014 09:48:38 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,491,1406617200\"; d=\"scan'208\";a=\"596702996\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "Olivier MATZ <olivier.matz@6wind.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "Thread-Index": "AQHPwta/R/ZLSlLyIU6bZkQjlXXcBZv25WuAgAGqPbA=", "Date": "Tue, 9 Sep 2014 08:48:37 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343EFA22@IRSMSX103.ger.corp.intel.com>", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-4-git-send-email-bruce.richardson@intel.com>\n\t<540D671B.9040104@6wind.com>", "In-Reply-To": "<540D671B.9040104@6wind.com>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.180]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]