Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25982,
    "url": "http://patches.dpdk.org/api/patches/25982/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1498735421-100164-6-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1498735421-100164-6-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1498735421-100164-6-git-send-email-harry.van.haaren@intel.com",
    "date": "2017-06-29T11:23:41",
    "name": "[dpdk-dev,v2,5/5] service cores: enable event/sw with service",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "5abc34ea16dc2e516e0e781c0ad0aa451e7a4910",
    "submitter": {
        "id": 317,
        "url": "http://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1498735421-100164-6-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/25982/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/25982/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A0F127CB3;\n\tThu, 29 Jun 2017 13:24:08 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id DF0F6374\n\tfor <dev@dpdk.org>; Thu, 29 Jun 2017 13:23:52 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP; 29 Jun 2017 04:23:52 -0700",
            "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga005.fm.intel.com with ESMTP; 29 Jun 2017 04:23:51 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.40,280,1496127600\"; d=\"scan'208\";a=\"120290630\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jerin.jacob@caviumnetworks.com, thomas@monjalon.net,\n\tkeith.wiles@intel.com, bruce.richardson@intel.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>",
        "Date": "Thu, 29 Jun 2017 12:23:41 +0100",
        "Message-Id": "<1498735421-100164-6-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1498735421-100164-1-git-send-email-harry.van.haaren@intel.com>",
        "References": "<1498208779-166205-1-git-send-email-harry.van.haaren@intel.com>\n\t<1498735421-100164-1-git-send-email-harry.van.haaren@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 5/5] service cores: enable event/sw with\n\tservice",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This commit shows how easy it is to enable a specific\nDPDK component with a service callback, in order to get\nCPU cycles for it.\n\nThe beauty of this method is that the service is unaware\nof how much CPU time it is getting - the application can\ndecide how to split and slice cores and map them to the\nregistered services.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv2:\n- Remove #include <rte_cycles.h> (Jerin)\n- Remove development prints (Jerin)\n- Track service name in PMD\n- Print warning if service does not have an lcore mapped (Jerin)\n---\n drivers/event/sw/sw_evdev.c | 32 ++++++++++++++++++++++++++++++++\n drivers/event/sw/sw_evdev.h |  3 +++\n 2 files changed, 35 insertions(+)",
    "diff": "diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c\nindex fe2a61e..baab376 100644\n--- a/drivers/event/sw/sw_evdev.c\n+++ b/drivers/event/sw/sw_evdev.c\n@@ -38,6 +38,7 @@\n #include <rte_kvargs.h>\n #include <rte_ring.h>\n #include <rte_errno.h>\n+#include <rte_service_private.h>\n \n #include \"sw_evdev.h\"\n #include \"iq_ring.h\"\n@@ -597,6 +598,13 @@ sw_start(struct rte_eventdev *dev)\n {\n \tunsigned int i, j;\n \tstruct sw_evdev *sw = sw_pmd_priv(dev);\n+\n+\t/* check a service core is mapped to this service */\n+\tstruct rte_service_spec *s = rte_service_get_by_name(sw->service_name);\n+\tif (!rte_service_is_running(s))\n+\t\tSW_LOG_ERR(\"Warning: No Service core enabled on service %s\\n\",\n+\t\t\t\ts->name);\n+\n \t/* check all ports are set up */\n \tfor (i = 0; i < sw->port_count; i++)\n \t\tif (sw->ports[i].rx_worker_ring == NULL) {\n@@ -699,6 +707,14 @@ set_credit_quanta(const char *key __rte_unused, const char *value, void *opaque)\n \treturn 0;\n }\n \n+\n+static int32_t sw_sched_service_func(void *args)\n+{\n+\tstruct rte_eventdev *dev = args;\n+\tsw_event_schedule(dev);\n+\treturn 0;\n+}\n+\n static int\n sw_probe(struct rte_vdev_device *vdev)\n {\n@@ -810,6 +826,22 @@ sw_probe(struct rte_vdev_device *vdev)\n \tsw->credit_update_quanta = credit_quanta;\n \tsw->sched_quanta = sched_quanta;\n \n+\t/* register service with EAL */\n+\tstruct rte_service_spec service;\n+\tmemset(&service, 0, sizeof(struct rte_service_spec));\n+\tsnprintf(service.name, sizeof(service.name), \"%s_service\", name);\n+\tsnprintf(sw->service_name, sizeof(sw->service_name), \"%s_service\",\n+\t\t\tname);\n+\tservice.socket_id = socket_id;\n+\tservice.callback = sw_sched_service_func;\n+\tservice.callback_userdata = (void *)dev;\n+\n+\tint32_t ret = rte_service_register(&service);\n+\tif (ret) {\n+\t\tSW_LOG_ERR(\"service register() failed\");\n+\t\treturn -ENOEXEC;\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/event/sw/sw_evdev.h b/drivers/event/sw/sw_evdev.h\nindex 0d7f94f..3e83823 100644\n--- a/drivers/event/sw/sw_evdev.h\n+++ b/drivers/event/sw/sw_evdev.h\n@@ -59,6 +59,7 @@\n \n #define EVENTDEV_NAME_SW_PMD event_sw\n #define SW_PMD_NAME RTE_STR(event_sw)\n+#define SW_PMD_NAME_MAX 64\n \n #define SW_SCHED_TYPE_DIRECT (RTE_SCHED_TYPE_PARALLEL + 1)\n \n@@ -276,6 +277,8 @@ struct sw_evdev {\n \t/* store num stats and offset of the stats for each queue */\n \tuint16_t xstats_count_per_qid[RTE_EVENT_MAX_QUEUES_PER_DEV];\n \tuint16_t xstats_offset_for_qid[RTE_EVENT_MAX_QUEUES_PER_DEV];\n+\n+\tchar service_name[SW_PMD_NAME_MAX];\n };\n \n static inline struct sw_evdev *\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "5/5"
    ]
}