Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25658,
    "url": "http://patches.dpdk.org/api/patches/25658/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170623124137.61091-1-allain.legacy@windriver.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170623124137.61091-1-allain.legacy@windriver.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170623124137.61091-1-allain.legacy@windriver.com",
    "date": "2017-06-23T12:41:37",
    "name": "[dpdk-dev] net/virtio-user: fix crash when detaching device",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "1e7f555ca64e26d591cbffd2a0ae46d386554e86",
    "submitter": {
        "id": 679,
        "url": "http://patches.dpdk.org/api/people/679/?format=api",
        "name": "Allain Legacy",
        "email": "allain.legacy@windriver.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170623124137.61091-1-allain.legacy@windriver.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/25658/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/25658/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C0F523230;\n\tFri, 23 Jun 2017 14:41:48 +0200 (CEST)",
            "from mail1.windriver.com (mail1.windriver.com [147.11.146.13])\n\tby dpdk.org (Postfix) with ESMTP id 78ED6292D;\n\tFri, 23 Jun 2017 14:41:46 +0200 (CEST)",
            "from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id v5NCficv021677\n\t(version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);\n\tFri, 23 Jun 2017 05:41:44 -0700 (PDT)",
            "from yow-cgts4-lx.wrs.com (128.224.145.137) by\n\tALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server\n\t(TLS) id 14.3.294.0; Fri, 23 Jun 2017 05:41:44 -0700"
        ],
        "From": "Allain Legacy <allain.legacy@windriver.com>",
        "To": "<yliu@fridaylinux.org>, <maxime.coquelin@redhat.com>",
        "CC": "<dev@dpdk.org>, <stable@dpdk.org>",
        "Date": "Fri, 23 Jun 2017 08:41:37 -0400",
        "Message-ID": "<20170623124137.61091-1-allain.legacy@windriver.com>",
        "X-Mailer": "git-send-email 2.12.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[128.224.145.137]",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: fix crash when detaching device",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The rte_eth_dev.data pointer is set to a reference to a static table.\nAttempting to rte_free() it leads to a panic.  For example, the\nfollowing commands result in a panic if run in testpmd\n\n  testpmd> port attach virtio_user0,path=/dev/vhost-net,iface=test0\n  testpmd> port stop 2\n  testpmd> port close 2\n  testpmd> port detach 2\n\nFixes: ce2eabdd43ec (\"net/virtio-user: add virtual device\")\n\nSigned-off-by: Allain Legacy <allain.legacy@windriver.com>\n---\n drivers/net/virtio/virtio_user_ethdev.c | 1 -\n 1 file changed, 1 deletion(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 280406c02..e9af946e8 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -556,7 +556,6 @@ virtio_user_pmd_remove(struct rte_vdev_device *vdev)\n \tvirtio_user_dev_uninit(dev);\n \n \trte_free(eth_dev->data->dev_private);\n-\trte_free(eth_dev->data);\n \trte_eth_dev_release_port(eth_dev);\n \n \treturn 0;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}