Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/25652/?format=api
{ "id": 25652, "url": "http://patches.dpdk.org/api/patches/25652/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1498208779-166205-2-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1498208779-166205-2-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1498208779-166205-2-git-send-email-harry.van.haaren@intel.com", "date": "2017-06-23T09:06:15", "name": "[dpdk-dev,2/6] service cores: coremask parsing", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "79a42b0077d7d41f16c971352409a9462da1152d", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1498208779-166205-2-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/25652/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/25652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 96AC9377E;\n\tFri, 23 Jun 2017 11:06:34 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 83C0729CA\n\tfor <dev@dpdk.org>; Fri, 23 Jun 2017 11:06:28 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jun 2017 02:06:27 -0700", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga004.fm.intel.com with ESMTP; 23 Jun 2017 02:06:26 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.39,377,1493708400\"; d=\"scan'208\";a=\"277769850\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, jerin.jacob@caviumnetworks.com,\n\tkeith.wiles@intel.com, bruce.richardson@intel.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>", "Date": "Fri, 23 Jun 2017 10:06:15 +0100", "Message-Id": "<1498208779-166205-2-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1498208779-166205-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1498208779-166205-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/6] service cores: coremask parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add logic for parsing a coremask from EAL, which allows\nthe application to be unaware of the cores being taken from\nits coremask.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n lib/librte_eal/common/eal_common_options.c | 78 ++++++++++++++++++++++++++++++\n 1 file changed, 78 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex f470195..3599784 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -50,6 +50,7 @@\n #include <rte_version.h>\n #include <rte_devargs.h>\n #include <rte_memcpy.h>\n+#include <rte_service.h>\n \n #include \"eal_internal_cfg.h\"\n #include \"eal_options.h\"\n@@ -61,6 +62,7 @@ const char\n eal_short_options[] =\n \t\"b:\" /* pci-blacklist */\n \t\"c:\" /* coremask */\n+\t\"s:\" /* service coremask */\n \t\"d:\" /* driver */\n \t\"h\" /* help */\n \t\"l:\" /* corelist */\n@@ -267,6 +269,75 @@ static int xdigit2val(unsigned char c)\n }\n \n static int\n+eal_parse_service_coremask(const char *coremask)\n+{\n+\tstruct rte_config *cfg = rte_eal_get_configuration();\n+\tint i, j, idx = 0;\n+\tunsigned count = 0;\n+\tchar c;\n+\tint val;\n+\n+\tif (coremask == NULL)\n+\t\treturn -1;\n+\t/* Remove all blank characters ahead and after .\n+\t * Remove 0x/0X if exists.\n+\t */\n+\twhile (isblank(*coremask))\n+\t\tcoremask++;\n+\tif (coremask[0] == '0' && ((coremask[1] == 'x')\n+\t\t|| (coremask[1] == 'X')))\n+\t\tcoremask += 2;\n+\ti = strlen(coremask);\n+\twhile ((i > 0) && isblank(coremask[i - 1]))\n+\t\ti--;\n+\n+\tif (i == 0)\n+\t\treturn -1;\n+\n+\tprintf(\"\\n\\nRemoving Service Cores from lcore roles now\\n\\n\");\n+\n+\t/* TODO: only scan active cores in coremask */\n+\tfor (i = i - 1; i >= 0 && idx < RTE_MAX_LCORE; i--) {\n+\t\tc = coremask[i];\n+\t\tif (isxdigit(c) == 0) {\n+\t\t\t/* invalid characters */\n+\t\t\treturn -1;\n+\t\t}\n+\t\tval = xdigit2val(c);\n+\t\tfor (j = 0; j < BITS_PER_HEX && idx < RTE_MAX_LCORE;\n+\t\t\t\tj++, idx++) {\n+\t\t\tif ((1 << j) & val) {\n+\t\t\t\t/* TODO: enable flexible master core */\n+\t\t\t\tif (idx == 0)\n+\t\t\t\t\tcontinue;\n+\n+\t\t\t\tif (!lcore_config[idx].detected) {\n+\t\t\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\t\t\"lcore %u unavailable\\n\", idx);\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t\t//cfg->lcore_role[idx] = ROLE_SERVICE;\n+\t\t\t\trte_service_core_add(idx);\n+\t\t\t\tcount++;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\tfor (; i >= 0; i--)\n+\t\tif (coremask[i] != '0')\n+\t\t\treturn -1;\n+\n+\tfor (; idx < RTE_MAX_LCORE; idx++)\n+\t\tlcore_config[idx].core_index = -1;\n+\n+\tif (count == 0)\n+\t\treturn -1;\n+\n+\tcfg->score_count = count;\n+\treturn 0;\n+}\n+\n+static int\n eal_parse_coremask(const char *coremask)\n {\n \tstruct rte_config *cfg = rte_eal_get_configuration();\n@@ -826,6 +897,13 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t}\n \t\tcore_parsed = 1;\n \t\tbreak;\n+\t/* service coremask */\n+\tcase 's':\n+\t\tif (eal_parse_service_coremask(optarg) < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"invalid service coremask\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tbreak;\n \t/* size of memory */\n \tcase 'm':\n \t\tconf->memory = atoi(optarg);\n", "prefixes": [ "dpdk-dev", "2/6" ] }