Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25552,
    "url": "http://patches.dpdk.org/api/patches/25552/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170621050733.88850-3-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170621050733.88850-3-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170621050733.88850-3-pablo.de.lara.guarch@intel.com",
    "date": "2017-06-21T05:07:31",
    "name": "[dpdk-dev,v2,2/4] crypto/scheduler: remove socket id check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "31b45da028667e4d2830f167a152fb6737160669",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170621050733.88850-3-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/25552/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/25552/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8A55C5689;\n\tWed, 21 Jun 2017 15:07:36 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 6153C4BE1\n\tfor <dev@dpdk.org>; Wed, 21 Jun 2017 15:07:31 +0200 (CEST)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Jun 2017 06:07:25 -0700",
            "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2017 06:07:22 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.39,369,1493708400\"; d=\"scan'208\";a=\"870269118\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "declan.doherty@intel.com,\n\tthomas@monjalon.net",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Wed, 21 Jun 2017 06:07:31 +0100",
        "Message-Id": "<20170621050733.88850-3-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.9.4",
        "In-Reply-To": "<20170621050733.88850-1-pablo.de.lara.guarch@intel.com>",
        "References": "<20170620232555.82244-1-pablo.de.lara.guarch@intel.com>\n\t<20170621050733.88850-1-pablo.de.lara.guarch@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/4] crypto/scheduler: remove socket id check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Socket id parsed from the user was checked\nif it was in the range of available sockets.\nThis check is unnecessary, as the socket specified\nmight not have memory anyway, so it will fail\nat memory allocation.\n\nTherefore, the best solution is to remove this check.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/scheduler/scheduler_pmd.c | 22 ----------------------\n 1 file changed, 22 deletions(-)",
    "diff": "diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c\nindex 0b63c20..29b16c9 100644\n--- a/drivers/crypto/scheduler/scheduler_pmd.c\n+++ b/drivers/crypto/scheduler/scheduler_pmd.c\n@@ -219,22 +219,6 @@ cryptodev_scheduler_remove(struct rte_vdev_device *vdev)\n \treturn 0;\n }\n \n-static uint8_t\n-number_of_sockets(void)\n-{\n-\tint sockets = 0;\n-\tint i;\n-\tconst struct rte_memseg *ms = rte_eal_get_physmem_layout();\n-\n-\tfor (i = 0; ((i < RTE_MAX_MEMSEG) && (ms[i].addr != NULL)); i++) {\n-\t\tif (sockets < ms[i].socket_id)\n-\t\t\tsockets = ms[i].socket_id;\n-\t}\n-\n-\t/* Number of sockets = maximum socket_id + 1 */\n-\treturn ++sockets;\n-}\n-\n /** Parse integer from integer argument */\n static int\n parse_integer_arg(const char *key __rte_unused,\n@@ -390,12 +374,6 @@ scheduler_parse_init_params(struct scheduler_init_params *params,\n \t\t\t\t&parse_ordering_arg, params);\n \t\tif (ret < 0)\n \t\t\tgoto free_kvlist;\n-\n-\t\tif (params->def_p.socket_id >= number_of_sockets()) {\n-\t\t\tCDEV_LOG_ERR(\"Invalid socket id specified to create \"\n-\t\t\t\t\"the virtual crypto device on\");\n-\t\t\tgoto free_kvlist;\n-\t\t}\n \t}\n \n free_kvlist:\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/4"
    ]
}