Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25016,
    "url": "http://patches.dpdk.org/api/patches/25016/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1496339745-36414-1-git-send-email-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1496339745-36414-1-git-send-email-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1496339745-36414-1-git-send-email-qi.z.zhang@intel.com",
    "date": "2017-06-01T17:55:45",
    "name": "[dpdk-dev,v2] net/i40e: exclude internal packet's byte count",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "1699a2edd7de470c4985009519a238efb2aabf2f",
    "submitter": {
        "id": 504,
        "url": "http://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1496339745-36414-1-git-send-email-qi.z.zhang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/25016/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/25016/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 195197CEB;\n\tFri,  2 Jun 2017 03:02:28 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id B39FB7CE5;\n\tFri,  2 Jun 2017 03:02:25 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jun 2017 18:02:24 -0700",
            "from zhangqi.sh.intel.com ([10.239.129.189])\n\tby fmsmga002.fm.intel.com with ESMTP; 01 Jun 2017 18:02:23 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.39,282,1493708400\"; d=\"scan'208\";\n\ta=\"1177267715\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "jingjing.wu@intel.com,\n\thelin.zhang@intel.com",
        "Cc": "dev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>,\n\tstable@dpdk.org",
        "Date": "Thu,  1 Jun 2017 13:55:45 -0400",
        "Message-Id": "<1496339745-36414-1-git-send-email-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH v2] net/i40e: exclude internal packet's byte count",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Tx/Rx byte counts of internal managed packet should be\nexluded from the total rx/tx bytes.\n\nFixes: 9aace75fc82e (\"i40e: fix statistics\")\nCc: stable@dpdk.org\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n\nv2:\n- internal byte count should be clear during pf setup.\n\n drivers/net/i40e/i40e_ethdev.c | 21 +++++++++++++++++++--\n drivers/net/i40e/i40e_ethdev.h |  5 +++++\n 2 files changed, 24 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 4c49673..0187367 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -2379,6 +2379,19 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \tstruct i40e_hw_port_stats *ns = &pf->stats; /* new stats */\n \tstruct i40e_hw_port_stats *os = &pf->stats_offset; /* old stats */\n \n+\t/* Get rx/tx bytes of internal transfer packets */\n+\ti40e_stat_update_48(hw, I40E_GLV_GORCH(hw->port),\n+\t\t\tI40E_GLV_GORCL(hw->port),\n+\t\t\tpf->offset_loaded,\n+\t\t\t&pf->internal_rx_bytes_offset,\n+\t\t\t&pf->internal_rx_bytes);\n+\n+\ti40e_stat_update_48(hw, I40E_GLV_GOTCH(hw->port),\n+\t\t\tI40E_GLV_GOTCL(hw->port),\n+\t\t\tpf->offset_loaded,\n+\t\t\t&pf->internal_tx_bytes_offset,\n+\t\t\t&pf->internal_tx_bytes);\n+\n \t/* Get statistics of struct i40e_eth_stats */\n \ti40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port),\n \t\t\t    I40E_GLPRT_GORCL(hw->port),\n@@ -2400,7 +2413,7 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \t * so subtract ETHER_CRC_LEN from the byte counter for each rx packet.\n \t */\n \tns->eth.rx_bytes -= (ns->eth.rx_unicast + ns->eth.rx_multicast +\n-\t\tns->eth.rx_broadcast) * ETHER_CRC_LEN;\n+\t\tns->eth.rx_broadcast) * ETHER_CRC_LEN + pf->internal_rx_bytes;\n \n \ti40e_stat_update_32(hw, I40E_GLPRT_RDPC(hw->port),\n \t\t\t    pf->offset_loaded, &os->eth.rx_discards,\n@@ -2428,7 +2441,7 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \t\t\t    pf->offset_loaded, &os->eth.tx_broadcast,\n \t\t\t    &ns->eth.tx_broadcast);\n \tns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +\n-\t\tns->eth.tx_broadcast) * ETHER_CRC_LEN;\n+\t\tns->eth.tx_broadcast) * ETHER_CRC_LEN + pf->internal_tx_bytes;\n \t/* GLPRT_TEPC not supported */\n \n \t/* additional port specific stats */\n@@ -5196,6 +5209,10 @@ i40e_pf_setup(struct i40e_pf *pf)\n \tpf->offset_loaded = FALSE;\n \tmemset(&pf->stats, 0, sizeof(struct i40e_hw_port_stats));\n \tmemset(&pf->stats_offset, 0, sizeof(struct i40e_hw_port_stats));\n+\tpf->internal_rx_bytes = 0;\n+\tpf->internal_tx_bytes = 0;\n+\tpf->internal_rx_bytes_offset = 0;\n+\tpf->internal_tx_bytes_offset = 0;\n \n \tret = i40e_pf_get_switch_config(pf);\n \tif (ret != I40E_SUCCESS) {\ndiff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h\nindex 2ff8282..b0d963c 100644\n--- a/drivers/net/i40e/i40e_ethdev.h\n+++ b/drivers/net/i40e/i40e_ethdev.h\n@@ -639,6 +639,11 @@ struct i40e_pf {\n \n \tstruct i40e_hw_port_stats stats_offset;\n \tstruct i40e_hw_port_stats stats;\n+\t/* internal packet byte count, it should be excluded from the total */\n+\tuint64_t internal_rx_bytes;\n+\tuint64_t internal_tx_bytes;\n+\tuint64_t internal_rx_bytes_offset;\n+\tuint64_t internal_tx_bytes_offset;\n \tbool offset_loaded;\n \n \tstruct rte_eth_dev_data *dev_data; /* Pointer to the device data */\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}