Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 24990,
    "url": "http://patches.dpdk.org/api/patches/24990/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170601170723.48709-6-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170601170723.48709-6-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170601170723.48709-6-ajit.khaparde@broadcom.com",
    "date": "2017-06-01T17:07:02",
    "name": "[dpdk-dev,v4,05/26] net/bnxt: add additonal HWRM debug info to error messages",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "7ec736d5f96af648fbe38c8a006e3e21f6cdf2e2",
    "submitter": {
        "id": 501,
        "url": "http://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170601170723.48709-6-ajit.khaparde@broadcom.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/24990/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/24990/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 431427CE2;\n\tThu,  1 Jun 2017 19:07:53 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (lpdvrndsmtp01.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id F0CC47CC4\n\tfor <dev@dpdk.org>; Thu,  1 Jun 2017 19:07:41 +0200 (CEST)",
            "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 8528730C003;\n\tThu,  1 Jun 2017 10:07:40 -0700 (PDT)",
            "from C02PT1RBG8WP.wifi.broadcom.net (c02pt1rbg8wp.wifi.broadcom.net\n\t[10.45.51.51])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 06B5681EB5;\n\tThu,  1 Jun 2017 10:07:39 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 8528730C003",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1496336860;\n\tbh=Nq1NZOgUd2bu5W/9GxrRRP7HGasDlZpb722jmteVvJo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KWVUS8xOIYDWfdgssuaMsclkh0A1l2lYqkRRcb5Mvjc/GWngjScKXA4wcECX5n+Cu\n\t4EY4BpTyiaxGBVKXjr+NDuh1Ca6f4xj40jTgw+Ke+DSQ98FmePpCTYiKyovrJYypVg\n\tjuGnGW2F0kGo/rkSQDrbpi4HQUxBC+nE+Mh4SFx4=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com,\n\tStephen Hurd <stephen.hurd@broadcom.com>",
        "Date": "Thu,  1 Jun 2017 12:07:02 -0500",
        "Message-Id": "<20170601170723.48709-6-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.10.1 (Apple Git-78)",
        "In-Reply-To": "<20170601170723.48709-1-ajit.khaparde@broadcom.com>",
        "References": "<20170601030232.38677-1-ajit.khaparde@broadcom.com>\n\t<20170601170723.48709-1-ajit.khaparde@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH v4 05/26] net/bnxt: add additonal HWRM debug info\n\tto error messages",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add the cmd_err and opaque_0 and opaque_1 fields to HWRM error\nmessages.  These allow better debugging of some classes of HWRM\nerrors.\n\nSigned-off-by: Stephen Hurd <stephen.hurd@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\n--\nv1->v2: regroup related patches and incorporate other review comments\n\nv2->v3:\n  - rebasing to next-net tree\n  - Use net/bnxt instead of just bnxt in patch subject\n---\n drivers/net/bnxt/bnxt_hwrm.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex d2a8d8f..3c2f148 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -139,7 +139,7 @@ static int bnxt_hwrm_send_message_locked(struct bnxt *bp, void *msg,\n \t}\n \n \tif (i >= HWRM_CMD_TIMEOUT) {\n-\t\tRTE_LOG(ERR, PMD, \"Error sending msg %x\\n\",\n+\t\tRTE_LOG(ERR, PMD, \"Error sending msg 0x%04x\\n\",\n \t\t\treq->req_type);\n \t\tgoto err_ret;\n \t}\n@@ -176,7 +176,22 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, uint32_t msg_len)\n \t\t} \\\n \t\tif (resp->error_code) { \\\n \t\t\trc = rte_le_to_cpu_16(resp->error_code); \\\n-\t\t\tRTE_LOG(ERR, PMD, \"%s error %d\\n\", __func__, rc); \\\n+\t\t\tif (resp->resp_len >= 16) { \\\n+\t\t\t\tstruct hwrm_err_output *tmp_hwrm_err_op = \\\n+\t\t\t\t\t\t\t(void *)resp; \\\n+\t\t\t\tRTE_LOG(ERR, PMD, \\\n+\t\t\t\t\t\"%s error %d:%d:%08x:%04x\\n\", \\\n+\t\t\t\t\t__func__, \\\n+\t\t\t\t\trc, tmp_hwrm_err_op->cmd_err, \\\n+\t\t\t\t\trte_le_to_cpu_32(\\\n+\t\t\t\t\t\ttmp_hwrm_err_op->opaque_0), \\\n+\t\t\t\t\trte_le_to_cpu_16(\\\n+\t\t\t\t\t\ttmp_hwrm_err_op->opaque_1)); \\\n+\t\t\t} \\\n+\t\t\telse { \\\n+\t\t\t\tRTE_LOG(ERR, PMD, \\\n+\t\t\t\t\t\"%s error %d\\n\", __func__, rc); \\\n+\t\t\t} \\\n \t\t\treturn rc; \\\n \t\t} \\\n \t}\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "05/26"
    ]
}