Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 24873,
    "url": "http://patches.dpdk.org/api/patches/24873/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1496071015-24906-1-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1496071015-24906-1-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1496071015-24906-1-git-send-email-harry.van.haaren@intel.com",
    "date": "2017-05-29T15:16:55",
    "name": "[dpdk-dev] event/sw: fix credit tracking in port dequeue",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b6241bb9a4779dbac331404ad064c483d3e82f07",
    "submitter": {
        "id": 317,
        "url": "http://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1496071015-24906-1-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/24873/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/24873/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8FF0A7D32;\n\tMon, 29 May 2017 17:16:45 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id A0D3A7D27\n\tfor <dev@dpdk.org>; Mon, 29 May 2017 17:16:43 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2017 08:16:42 -0700",
            "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga004.fm.intel.com with ESMTP; 29 May 2017 08:16:40 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.38,415,1491289200\"; d=\"scan'208\";a=\"267719635\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jerin.jacob@caviumnetworks.com, gage.eads@intel.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>",
        "Date": "Mon, 29 May 2017 16:16:55 +0100",
        "Message-Id": "<1496071015-24906-1-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] event/sw: fix credit tracking in port dequeue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch targets the next-eventdev tree.\n\nSingle-link optimized ports previously did not correctly track\ncredits when dequeued, and re-enqueued as a FORWARD type. This\ncould \"inflate\" the number of credits in the system.\n\nA unit test is added to reproduce and verify the issue. The\nfixed implementation counts FORWARD packets and reduces the\nnumber of credits the port has if it is of single-link type.\n\nFixes: 656af9180014 (\"event/sw: add worker core functions\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/event/sw/sw_evdev_worker.c |  5 ++++\n test/test/test_eventdev_sw.c       | 58 +++++++++++++++++++++++++++++++++++++-\n 2 files changed, 62 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/event/sw/sw_evdev_worker.c b/drivers/event/sw/sw_evdev_worker.c\nindex 9cb6bef..b738506 100644\n--- a/drivers/event/sw/sw_evdev_worker.c\n+++ b/drivers/event/sw/sw_evdev_worker.c\n@@ -87,6 +87,7 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num)\n \t\t\treturn 0;\n \t}\n \n+\tuint32_t forwards = 0;\n \tfor (i = 0; i < num; i++) {\n \t\tint op = ev[i].op;\n \t\tint outstanding = p->outstanding_releases > 0;\n@@ -95,6 +96,7 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num)\n \t\tp->inflight_credits -= (op == RTE_EVENT_OP_NEW);\n \t\tp->inflight_credits += (op == RTE_EVENT_OP_RELEASE) *\n \t\t\t\t\toutstanding;\n+\t\tforwards += (op == RTE_EVENT_OP_FORWARD);\n \n \t\tnew_ops[i] = sw_qe_flag_map[op];\n \t\tnew_ops[i] &= ~(invalid_qid << QE_FLAG_VALID_SHIFT);\n@@ -113,6 +115,9 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num)\n \t\t}\n \t}\n \n+\t/* handle directed port forward credits */\n+\tp->inflight_credits -= forwards * p->is_directed;\n+\n \t/* returns number of events actually enqueued */\n \tuint32_t enq = qe_ring_enqueue_burst_with_ops(p->rx_worker_ring, ev, i,\n \t\t\t\t\t     new_ops);\ndiff --git a/test/test/test_eventdev_sw.c b/test/test/test_eventdev_sw.c\nindex b187d02..aaa9729 100644\n--- a/test/test/test_eventdev_sw.c\n+++ b/test/test/test_eventdev_sw.c\n@@ -548,6 +548,57 @@ test_single_directed_packet(struct test *t)\n \treturn 0;\n }\n \n+static int\n+test_directed_forward_credits(struct test *t)\n+{\n+\tuint32_t i;\n+\tint32_t err;\n+\n+\tif (init(t, 1, 1) < 0 ||\n+\t\t\tcreate_ports(t, 1) < 0 ||\n+\t\t\tcreate_directed_qids(t, 1, t->port) < 0)\n+\t\treturn -1;\n+\n+\tif (rte_event_dev_start(evdev) < 0) {\n+\t\tprintf(\"%d: Error with start call\\n\", __LINE__);\n+\t\treturn -1;\n+\t}\n+\n+\tstruct rte_event ev = {\n+\t\t\t.op = RTE_EVENT_OP_NEW,\n+\t\t\t.queue_id = 0,\n+\t};\n+\n+\tfor (i = 0; i < 1000; i++) {\n+\t\terr = rte_event_enqueue_burst(evdev, 0, &ev, 1);\n+\t\tif (err < 0) {\n+\t\t\tprintf(\"%d: error failed to enqueue\\n\", __LINE__);\n+\t\t\treturn -1;\n+\t\t}\n+\t\trte_event_schedule(evdev);\n+\t\tstruct test_event_dev_stats stats;\n+\t\terr = test_event_dev_stats_get(evdev, &stats);\n+\t\tif (err) {\n+\t\t\tprintf(\"%d: error failed to get stats\\n\", __LINE__);\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tuint32_t deq_pkts;\n+\t\tdeq_pkts = rte_event_dequeue_burst(evdev, 0, &ev, 1, 0);\n+\t\tif (deq_pkts != 1) {\n+\t\t\tprintf(\"%d: error failed to deq\\n\", __LINE__);\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\t/* re-write event to be a forward, and continue looping it */\n+\t\tev.op = RTE_EVENT_OP_FORWARD;\n+\t}\n+\n+\t//rte_event_dev_dump(0, stdout);\n+\tcleanup(t);\n+\treturn 0;\n+}\n+\n \n static int\n test_priority_directed(struct test *t)\n@@ -3025,13 +3076,18 @@ test_sw_eventdev(void)\n \t\t}\n \t}\n \tt->mbuf_pool = eventdev_func_mempool;\n-\n \tprintf(\"*** Running Single Directed Packet test...\\n\");\n \tret = test_single_directed_packet(t);\n \tif (ret != 0) {\n \t\tprintf(\"ERROR - Single Directed Packet test FAILED.\\n\");\n \t\treturn ret;\n \t}\n+\tprintf(\"*** Running Directed Forward Credit test...\\n\");\n+\tret = test_directed_forward_credits(t);\n+\tif (ret != 0) {\n+\t\tprintf(\"ERROR - Directed Forward Credit test FAILED.\\n\");\n+\t\treturn ret;\n+\t}\n \tprintf(\"*** Running Single Load Balanced Packet test...\\n\");\n \tret = single_packet(t);\n \tif (ret != 0) {\n",
    "prefixes": [
        "dpdk-dev"
    ]
}