List patch comments

GET /api/patches/247/comments/?format=api
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Link: 
<http://patches.dpdk.org/api/patches/247/comments/?format=api&page=1>; rel="first",
<http://patches.dpdk.org/api/patches/247/comments/?format=api&page=1>; rel="last"
Vary: Accept
[ { "id": 510, "web_url": "http://patches.dpdk.org/comment/510/", "msgid": "<9091956.EmWA3cIqCF@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/9091956.EmWA3cIqCF@xps13", "date": "2014-08-27T14:27:47", "subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-08-27 10:13, Jingjing Wu:\n> fix the Marco conflict between rte_ip.h and netinet/in.h\n\nWho is Marco?\n\n> +#ifndef _NETINET_IN_H\n> +#ifndef _NETINET_IN_H_\n> /* IPv4 protocols */\n> #define IPPROTO_IP 0 /**< dummy for IP */\n> #define IPPROTO_HOPOPTS 0 /**< IP6 hop-by-hop options */\n> @@ -226,7 +228,8 @@ struct ipv4_hdr {\n> #define IPPROTO_DIVERT 254 /**< divert pseudo-protocol */\n> #define IPPROTO_RAW 255 /**< raw IP packet */\n> #define IPPROTO_MAX 256 /**< maximum protocol number */\n> -\n> +#endif /* _NETINET_IN_H_ */\n> +#endif /* _NETINET_IN_H */\n\nPlease explain your \"fix\" (which seems to be a workaround).", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-we0-f180.google.com (mail-we0-f180.google.com\n\t[74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 680C9682E\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 16:23:47 +0200 (CEST)", "by mail-we0-f180.google.com with SMTP id w61so310668wes.11\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 07:27:52 -0700 (PDT)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tpc6sm1423074wjb.43.2014.08.27.07.27.50 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Aug 2014 07:27:51 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=ojjAcQmV59A7Q6Qe8rxtjVYSAIYaJ87MWG/w8gx7UYg=;\n\tb=YkVossB1LtRa/Qw7tZGybZ4QXlZz/E2EmqkSnumpA2npbZIdYDXDYMY6dhGv2yzWBa\n\t3xf8+cj3cOJoZGrVCA7ks5RzfVPiVbs4I83M3CjBtQ1b7toOuFXuqS4v2q2uxyVjSmWC\n\tMNn0DZd7ogGh+2ffSPOECDie0flgAd0u8fBtBOxD3vGlkV6wsDHbrPSCOFP6SAGOVeMq\n\t5vOxN3YFYFsya/MZGhYTPApIhW7Ch7ugawGUQIuhdZTehr6Vf8jhou3upeIVjaQBD0mY\n\t5Hdj/3KXBvXkoOWOcVmNoC0OSDf67VaFFm94oL2EXKS37LyDLslrslviER2XJtfFw04D\n\tHzJQ==", "X-Gm-Message-State": "ALoCoQl6gW3P4TvXQHGVtMEvCPQLaOHF0qrjHSfabI+07YvtxMlnT1KiR7WD7pLrllet3b97GoPc", "X-Received": "by 10.194.80.9 with SMTP id n9mr38063463wjx.57.1409149671995;\n\tWed, 27 Aug 2014 07:27:51 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Jingjing Wu <jingjing.wu@intel.com>", "Date": "Wed, 27 Aug 2014 16:27:47 +0200", "Message-ID": "<9091956.EmWA3cIqCF@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1409105634-29980-6-git-send-email-jingjing.wu@intel.com>", "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<1409105634-29980-6-git-send-email-jingjing.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 27 Aug 2014 14:23:47 -0000" }, "addressed": null }, { "id": 535, "web_url": "http://patches.dpdk.org/comment/535/", "msgid": "<9BB6961774997848B5B42BEC655768F8ADBF1D@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9BB6961774997848B5B42BEC655768F8ADBF1D@SHSMSX104.ccr.corp.intel.com", "date": "2014-08-28T03:39:53", "subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "submitter": { "id": 47, "url": "http://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "content": "Hi, Thomas\n\nBecause these macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in <netinet/in.h>. If user's application include <netinet/in.h> and rte_ip.h at the same time, there will be conflict error, for example cmdline.c in testpmd.\nI remember there was someone also raised this issue few month ago.\nSo just use the way \"#ifndef #endif\" to avoid the conflict. And it is exactly workaround as you said.\n\nOh, it should be macro, but not marco, my spelling mistake.\nSorry for that. I will rename this.\n\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Wednesday, August 27, 2014 10:28 PM\n> To: Wu, Jingjing\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict\n> \n> 2014-08-27 10:13, Jingjing Wu:\n> > fix the Marco conflict between rte_ip.h and netinet/in.h\n> \n> Who is Marco?\n> \n> > +#ifndef _NETINET_IN_H\n> > +#ifndef _NETINET_IN_H_\n> > /* IPv4 protocols */\n> > #define IPPROTO_IP 0 /**< dummy for IP */\n> > #define IPPROTO_HOPOPTS 0 /**< IP6 hop-by-hop options */\n> > @@ -226,7 +228,8 @@ struct ipv4_hdr {\n> > #define IPPROTO_DIVERT 254 /**< divert pseudo-protocol */\n> > #define IPPROTO_RAW 255 /**< raw IP packet */\n> > #define IPPROTO_MAX 256 /**< maximum protocol number */\n> > -\n> > +#endif /* _NETINET_IN_H_ */\n> > +#endif /* _NETINET_IN_H */\n> \n> Please explain your \"fix\" (which seems to be a workaround).\n> \n> --\n> Thomas", "headers": { "Return-Path": "<jingjing.wu@intel.com>", "Received": [ "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 6DEC83975\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 05:36:18 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 27 Aug 2014 20:40:23 -0700", "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby orsmga001.jf.intel.com with ESMTP; 27 Aug 2014 20:39:56 -0700", "from fmsmsx119.amr.corp.intel.com (10.19.9.28) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 27 Aug 2014 20:39:56 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX119.amr.corp.intel.com (10.19.9.28) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Wed, 27 Aug 2014 20:39:56 -0700", "from shsmsx104.ccr.corp.intel.com ([169.254.5.17]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 11:39:54 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,415,1406617200\"; d=\"scan'208\";a=\"564530767\"", "From": "\"Wu, Jingjing\" <jingjing.wu@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "Thread-Index": "AQHPwZy6uM+I2qgzZkecQsE4GrHl+Zvj/M+AgAFhCNA=", "Date": "Thu, 28 Aug 2014 03:39:53 +0000", "Message-ID": "<9BB6961774997848B5B42BEC655768F8ADBF1D@SHSMSX104.ccr.corp.intel.com>", "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<1409105634-29980-6-git-send-email-jingjing.wu@intel.com>\n\t<9091956.EmWA3cIqCF@xps13>", "In-Reply-To": "<9091956.EmWA3cIqCF@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 Aug 2014 03:36:19 -0000" }, "addressed": null }, { "id": 540, "web_url": "http://patches.dpdk.org/comment/540/", "msgid": "<7302306.qBW1xKV0E1@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/7302306.qBW1xKV0E1@xps13", "date": "2014-08-28T08:55:55", "subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-08-28 03:39, Wu, Jingjing:\n> Because these macros such as IPPROTO_TCP, IPPROTO_UDP are already\n> defined in <netinet/in.h>. If user's application include <netinet/in.h>\n> and rte_ip.h at the same time, there will be conflict error, for\n> example cmdline.c in testpmd.\n\nYes\n\n> I remember there was someone also raised this issue few month ago.\n\nYes, and the question was: \"should we totally remove these definitions\"?\nI think yes.\n\n> So just use the way \"#ifndef #endif\" to avoid the conflict.\n\nBut you didn't explain difference between _NETINET_IN_H and _NETINET_IN_H_.\n\n> And it is exactly workaround as you said.\n\nYes, it's a workaround.\nIf rte_ip.h is included before netinet/in.h, I think there is still a problem.", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wg0-f50.google.com (mail-wg0-f50.google.com\n\t[74.125.82.50]) by dpdk.org (Postfix) with ESMTP id E0D5C682E\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 10:51:52 +0200 (CEST)", "by mail-wg0-f50.google.com with SMTP id x12so424342wgg.33\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 01:56:01 -0700 (PDT)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\txn15sm33295238wib.13.2014.08.28.01.55.59 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 01:56:00 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=fHCmJbwHAUfw1LntIhqRxKkrN2DzEQKtoemE4bRB9GU=;\n\tb=gwgAGPfE660wf5eZXMQENnAww3twurrBw2nvS3k4/b39SSN5BNXw9BlasqaLOLVQiJ\n\tFijAX5vejVUvzo7yApKNXw44HFtpbYtQGIoPda5++lA908fIm5FMZO84+WPFQxDFzzBO\n\tX9LhUNqykeLwjL6J144qrbiqjjIe1uLoK5+3jivVg83zw7VluK8SW2JGO9vn5zf4dX0Y\n\tthTd5Vgn+F4X5rg6bp/HoNtHnyJrTSJtTEsZI8NMq+SZpeX8346AeSRKO1CRPfV4ZRUP\n\tiW/HEmMy2C8/GKsu6D4PpRxVWKGWFHEGFyJXVIVEZS0a3Nj4/eM/Z1UqTfv55s2x+T8X\n\t3y1w==", "X-Gm-Message-State": "ALoCoQlOChm+KWpl8M5IfA2G5o9iy0owUv1clhJC5iWhwefYhxDfUhuqFe7WVgu1d8Qnw7CXhrTX", "X-Received": "by 10.194.47.208 with SMTP id f16mr1143396wjn.130.1409216161116; \n\tThu, 28 Aug 2014 01:56:01 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Wu, Jingjing\" <jingjing.wu@intel.com>", "Date": "Thu, 28 Aug 2014 10:55:55 +0200", "Message-ID": "<7302306.qBW1xKV0E1@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<9BB6961774997848B5B42BEC655768F8ADBF1D@SHSMSX104.ccr.corp.intel.com>", "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<9091956.EmWA3cIqCF@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADBF1D@SHSMSX104.ccr.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 Aug 2014 08:51:53 -0000" }, "addressed": null }, { "id": 557, "web_url": "http://patches.dpdk.org/comment/557/", "msgid": "<9BB6961774997848B5B42BEC655768F8ADC286@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9BB6961774997848B5B42BEC655768F8ADC286@SHSMSX104.ccr.corp.intel.com", "date": "2014-08-28T14:37:20", "subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "submitter": { "id": 47, "url": "http://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, August 28, 2014 4:56 PM\n> To: Wu, Jingjing\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict\n> \n> 2014-08-28 03:39, Wu, Jingjing:\n> > Because these macros such as IPPROTO_TCP, IPPROTO_UDP are already\n> > defined in <netinet/in.h>. If user's application include <netinet/in.h>\n> > and rte_ip.h at the same time, there will be conflict error, for\n> > example cmdline.c in testpmd.\n> \n> Yes\n> \n> > I remember there was someone also raised this issue few month ago.\n> \n> Yes, and the question was: \"should we totally remove these definitions\"?\n> I think yes.\n> \nYes, it will be clear. But it also provides a way to user who doesn't use netinet/in.h.\n\n> > So just use the way \"#ifndef #endif\" to avoid the conflict.\n> \n> But you didn't explain difference between _NETINET_IN_H and _NETINET_IN_H_.\n\nIt is due to the different versions of in.h, some use _NETINET_IN_H_ to define the\nhead file, while some use _NETINET_IN_H\n> \n> > And it is exactly workaround as you said.\n> \n> Yes, it's a workaround.\n> If rte_ip.h is included before netinet/in.h, I think there is still a problem.\n\nYes, it's just workaround.\nAs my understanding, in DPDK's source code\nSystem head files includes first should be as following. So I think it's OK then.\n> \n> --\n> Thomas\n\nCan I send a separate patch for this? Because it has no strict relationship with flow director.\n\nThanks \nJingjing", "headers": { "Return-Path": "<jingjing.wu@intel.com>", "Received": [ "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id B098E682E\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 16:33:44 +0200 (CEST)", "from azsmga001.ch.intel.com ([10.2.17.19])\n\tby fmsmga102.fm.intel.com with ESMTP; 28 Aug 2014 07:37:40 -0700", "from fmsmsx104.amr.corp.intel.com ([10.18.124.202])\n\tby azsmga001.ch.intel.com with ESMTP; 28 Aug 2014 07:37:23 -0700", "from fmsmsx155.amr.corp.intel.com (10.18.116.71) by\n\tfmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 28 Aug 2014 07:37:22 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 28 Aug 2014 07:37:22 -0700", "from shsmsx104.ccr.corp.intel.com ([169.254.5.17]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 22:37:21 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,418,1406617200\"; d=\"scan'208\";a=\"473497953\"", "From": "\"Wu, Jingjing\" <jingjing.wu@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "Thread-Index": "AQHPwZy6uM+I2qgzZkecQsE4GrHl+Zvj/M+AgAFhCND//9SUgIAA3phA", "Date": "Thu, 28 Aug 2014 14:37:20 +0000", "Message-ID": "<9BB6961774997848B5B42BEC655768F8ADC286@SHSMSX104.ccr.corp.intel.com>", "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<9091956.EmWA3cIqCF@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADBF1D@SHSMSX104.ccr.corp.intel.com>\n\t<7302306.qBW1xKV0E1@xps13>", "In-Reply-To": "<7302306.qBW1xKV0E1@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 Aug 2014 14:33:45 -0000" }, "addressed": null }, { "id": 558, "web_url": "http://patches.dpdk.org/comment/558/", "msgid": "<7011798.3lPZFUXyOJ@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/7011798.3lPZFUXyOJ@xps13", "date": "2014-08-28T14:46:21", "subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-08-28 14:37, Wu, Jingjing:\n> Can I send a separate patch for this?\n> Because it has no strict relationship with flow director.\n\nYes, please.\nBut I think you should look at the removal option (no redefinition\nof at all).\n\nThanks", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wg0-f52.google.com (mail-wg0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id DBE71682E\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 16:42:19 +0200 (CEST)", "by mail-wg0-f52.google.com with SMTP id m15so854317wgh.11\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 07:46:29 -0700 (PDT)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tln6sm10534571wjb.13.2014.08.28.07.46.27 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 07:46:27 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=ohhGPosLb7O5g3QJI2b4cSZ4ORLtJBxiH9gawrSrNNQ=;\n\tb=XBeplIAOU1DsIVx7yRBwT7XbtTTQ88BOuPq5hypK0gh1ZKgxjZSRZLBBwatj/16cpm\n\tmdMrrWHqxGa0LauyvwMzZhHAbusof93wUL2MAFnbYQ2DB1q+4/J8rFAF+wa8dB6mY+6F\n\tG/+ymj5WDUMr4yQgZC8KcDfmKqTJmO+vZiTuQUsp17BJFZW9/vASa894nI0j2HI2PdDC\n\tlCobsWhkcjkhQDnyXNlQy+la9t2hOH71Q+2f1w4XalDBdog5/b52cEP5WLS34BUPGTg/\n\t8GQCktQEeP387UEAOGNGVJO2hCGHlMKUneR88hY+CkFkOLon3g0QJTdb5SVy/rAkh1se\n\toFkA==", "X-Gm-Message-State": "ALoCoQnBqtp5+MfxrjgJI/9JrBy/6rDxxlpf5IAG5VZhgfBE7befIF5am+1KjV6AYIhkOVGVq2Ab", "X-Received": "by 10.180.11.72 with SMTP id o8mr37451842wib.71.1409237188461;\n\tThu, 28 Aug 2014 07:46:28 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Wu, Jingjing\" <jingjing.wu@intel.com>", "Date": "Thu, 28 Aug 2014 16:46:21 +0200", "Message-ID": "<7011798.3lPZFUXyOJ@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<9BB6961774997848B5B42BEC655768F8ADC286@SHSMSX104.ccr.corp.intel.com>", "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<7302306.qBW1xKV0E1@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADC286@SHSMSX104.ccr.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 5/7] fix the Marco conflict", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 Aug 2014 14:42:20 -0000" }, "addressed": null } ]