Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23684,
    "url": "http://patches.dpdk.org/api/patches/23684/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1492509520-31943-1-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1492509520-31943-1-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1492509520-31943-1-git-send-email-harry.van.haaren@intel.com",
    "date": "2017-04-18T09:58:40",
    "name": "[dpdk-dev] event/sw: fix credit return on invalid queue id",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0fee48b77cac61e55a193eae8d3c39ae96634489",
    "submitter": {
        "id": 317,
        "url": "http://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1492509520-31943-1-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/23684/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/23684/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 865AA37A6;\n\tTue, 18 Apr 2017 11:58:44 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 6979F2C72\n\tfor <dev@dpdk.org>; Tue, 18 Apr 2017 11:58:43 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Apr 2017 02:58:42 -0700",
            "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga004.fm.intel.com with ESMTP; 18 Apr 2017 02:58:41 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.37,218,1488873600\"; d=\"scan'208\";a=\"250438221\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Harry van Haaren <harry.van.haaren@intel.com>",
        "Date": "Tue, 18 Apr 2017 10:58:40 +0100",
        "Message-Id": "<1492509520-31943-1-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] event/sw: fix credit return on invalid queue id",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch returns a credit when an rte_event is\nenqueued with an invalid queue_id. Previously a\ncredit was leaked from the system.\n\nNote that the eventdev instance does not attempt\nto free any resources that the rte_event owns. As\na result, resources owned by the rte_event are leaked.\nEg. if the rte_event represents an rte_mbuf, the mbuf\nwill not be freed, and causes a leak from the mempool.\n\nFixes: 656af9180014 (\"event/sw: add worker core functions\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/event/sw/sw_evdev_worker.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/event/sw/sw_evdev_worker.c b/drivers/event/sw/sw_evdev_worker.c\nindex b9b6f8d..9cb6bef 100644\n--- a/drivers/event/sw/sw_evdev_worker.c\n+++ b/drivers/event/sw/sw_evdev_worker.c\n@@ -105,9 +105,12 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num)\n \t\t */\n \t\tif ((new_ops[i] & QE_FLAG_COMPLETE) && outstanding)\n \t\t\tp->outstanding_releases--;\n-\t\t/* Branch to avoid touching p->stats except error case */\n-\t\tif (unlikely(invalid_qid))\n+\n+\t\t/* error case: branch to avoid touching p->stats */\n+\t\tif (unlikely(invalid_qid)) {\n \t\t\tp->stats.rx_dropped++;\n+\t\t\tp->inflight_credits++;\n+\t\t}\n \t}\n \n \t/* returns number of events actually enqueued */\n",
    "prefixes": [
        "dpdk-dev"
    ]
}