Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23651,
    "url": "http://patches.dpdk.org/api/patches/23651/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1492185898-43547-1-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1492185898-43547-1-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1492185898-43547-1-git-send-email-harry.van.haaren@intel.com",
    "date": "2017-04-14T16:04:58",
    "name": "[dpdk-dev] eventdev: fix dequeue timeout bitmask brackets",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b69e0d8101d6be746d21292aa6846c6808c9fbf3",
    "submitter": {
        "id": 317,
        "url": "http://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1492185898-43547-1-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/23651/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/23651/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3A2755689;\n\tFri, 14 Apr 2017 18:05:11 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 7D4DC5688\n\tfor <dev@dpdk.org>; Fri, 14 Apr 2017 18:05:08 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Apr 2017 09:05:06 -0700",
            "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Apr 2017 09:05:04 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.37,199,1488873600\"; d=\"scan'208\";a=\"74162619\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jerin.jacob@caviumnetworks.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>",
        "Date": "Fri, 14 Apr 2017 17:04:58 +0100",
        "Message-Id": "<1492185898-43547-1-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] eventdev: fix dequeue timeout bitmask brackets",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix brackets around the & operator to first mask a single bit\nand then perform the not operator. Previously the result was\nnot as expected, due to the ! operator being performed first.\n\nAs noted on list[1] Clang 4.0 warns about a possible bug for\nthis type of line:\n\tif (!variable & FLAG) {\n\nFixes: 4f0804bbdfb9 (\"eventdev: implement the northbound APIs\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n[1] http://dpdk.org/ml/archives/dev/2017-April/064089.html\n---\n lib/librte_eventdev/rte_eventdev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c\nindex 8042988..a64071e 100644\n--- a/lib/librte_eventdev/rte_eventdev.c\n+++ b/lib/librte_eventdev/rte_eventdev.c\n@@ -368,7 +368,8 @@ rte_event_dev_configure(uint8_t dev_id,\n \t(*dev->dev_ops->dev_infos_get)(dev, &info);\n \n \t/* Check dequeue_timeout_ns value is in limit */\n-\tif (!dev_conf->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT) {\n+\tif (!(dev_conf->event_dev_cfg &\n+\t\t\t\tRTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT)) {\n \t\tif (dev_conf->dequeue_timeout_ns < info.min_dequeue_timeout_ns\n \t\t\t|| dev_conf->dequeue_timeout_ns >\n \t\t\t\t info.max_dequeue_timeout_ns) {\n",
    "prefixes": [
        "dpdk-dev"
    ]
}