Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23627,
    "url": "http://patches.dpdk.org/api/patches/23627/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1492092776-57008-1-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1492092776-57008-1-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1492092776-57008-1-git-send-email-jianfeng.tan@intel.com",
    "date": "2017-04-13T14:12:56",
    "name": "[dpdk-dev] net/virtio-user: fix not working on 32-bit system",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9ca2e5a2a202421dd385359591cb3db00cfb00e8",
    "submitter": {
        "id": 313,
        "url": "http://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1492092776-57008-1-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/23627/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/23627/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DEFE8316B;\n\tThu, 13 Apr 2017 16:12:12 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 51A832C6E;\n\tThu, 13 Apr 2017 16:12:11 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP; 13 Apr 2017 07:12:10 -0700",
            "from dpdk06.sh.intel.com ([10.239.129.195])\n\tby orsmga003.jf.intel.com with ESMTP; 13 Apr 2017 07:12:08 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.37,194,1488873600\"; d=\"scan'208\";a=\"955733192\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yuanhan.liu@linux.intel.com, olivier.matz@6wind.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>, stable@dpdk.org",
        "Date": "Thu, 13 Apr 2017 14:12:56 +0000",
        "Message-Id": "<1492092776-57008-1-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: fix not working on 32-bit system",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "virtio-user cannot work on 32-bit system as higher 32-bit of the\naddr field (64-bit) in the desc is filled with non-zero value\nwhich should not happen for a 32-bit system.\n\nThis is a regression bug. For 32-bit system, the first 4 bytes\nis the virtual address, with following 8 bytes pointing to\nphysical addr. With below wrong definition, both virtual address\nand lower 4 bytes of physical addr are obtained.\n  #define VIRTIO_MBUF_ADDR(mb, vq) \\\n\t(*(uint64_t *)((uintptr_t)(mb) + (vq)->offset))\n\nFixes: 25f80d108780 (\"net/virtio: fix packet corruption\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtqueue.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex f9e3736..f43ea70 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -72,7 +72,8 @@ struct rte_mbuf;\n  * Return the physical address (or virtual address in case of\n  * virtio-user) of mbuf data buffer.\n  */\n-#define VIRTIO_MBUF_ADDR(mb, vq) (*(uint64_t *)((uintptr_t)(mb) + (vq)->offset))\n+#define VIRTIO_MBUF_ADDR(mb, vq) \\\n+\t((uint64_t)((uintptr_t)(*(void **)((uintptr_t)(mb) + (vq)->offset))))\n #else\n #define VIRTIO_MBUF_ADDR(mb, vq) ((mb)->buf_physaddr)\n #endif\n",
    "prefixes": [
        "dpdk-dev"
    ]
}