Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/23240/?format=api
{ "id": 23240, "url": "http://patches.dpdk.org/api/patches/23240/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1491401037-28611-1-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1491401037-28611-1-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1491401037-28611-1-git-send-email-bernard.iremonger@intel.com", "date": "2017-04-05T14:03:57", "name": "[dpdk-dev,v2] net/i40e: fix QinQ eth pattern parsing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "833f67df6555c63603ac395a1739d2a5c9d9e0e8", "submitter": { "id": 91, "url": "http://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1491401037-28611-1-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/23240/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/23240/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0A1B32B84;\n\tWed, 5 Apr 2017 16:04:06 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 3F6FF1DB1\n\tfor <dev@dpdk.org>; Wed, 5 Apr 2017 16:04:03 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2017 07:04:02 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga004.fm.intel.com with ESMTP; 05 Apr 2017 07:04:00 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=intel;\n\tt=1491401044; x=1522937044;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=G5dby60I9OznvmIUUNkIqlabj6W1fx0ktPuR+7PI8kk=;\n\tb=P1xEYetqRt9gIu+RJ/g8RSw+jxFoe5wwW0Mv44WkDFMfefvX0vDszetb\n\tF3PiDHcUIHfeqAhgj1xca23oGJyepg==;", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.36,278,1486454400\"; d=\"scan'208\";a=\"244582410\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org,\n\tbeilei.xing@intel.com", "Cc": "wenzhuo.lu@intel.com,\n\tBernard Iremonger <bernard.iremonger@intel.com>", "Date": "Wed, 5 Apr 2017 15:03:57 +0100", "Message-Id": "<1491401037-28611-1-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1491236049-6747-1-git-send-email-bernard.iremonger@intel.com>", "References": "<1491236049-6747-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix QinQ eth pattern parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The eth keyword only should be accepted.\n\nFixes: d46e85af6b5c (\"net/i40e: parse QinQ pattern\")\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\nChanges in v2:\nrebased to latest dpdk-next-net\nDocument the i40e_flow_parse_qinq_pattern function.\nParse the eth keyword in similar way to mpls parsing function.\n\n drivers/net/i40e/i40e_flow.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex 9f541eaff..3cf0e5a70 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -1740,6 +1740,13 @@ i40e_flow_parse_mpls_filter(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+/* 1. Last in item should be NULL as range is not supported.\n+ * 2. Supported filter types: QINQ.\n+ * 3. Mask of fields which need to be matched should be\n+ * filled with 1.\n+ * 4. Mask of fields which needn't to be matched should be\n+ * filled with 0.\n+ */\n static int\n i40e_flow_parse_qinq_pattern(__rte_unused struct rte_eth_dev *dev,\n \t\t\t const struct rte_flow_item *pattern,\n@@ -1747,8 +1754,6 @@ i40e_flow_parse_qinq_pattern(__rte_unused struct rte_eth_dev *dev,\n \t\t\t struct i40e_tunnel_filter_conf *filter)\n {\n \tconst struct rte_flow_item *item = pattern;\n-\tconst struct rte_flow_item_eth *eth_spec;\n-\tconst struct rte_flow_item_eth *eth_mask;\n \tconst struct rte_flow_item_vlan *vlan_spec = NULL;\n \tconst struct rte_flow_item_vlan *vlan_mask = NULL;\n \tconst struct rte_flow_item_vlan *i_vlan_spec = NULL;\n@@ -1770,13 +1775,11 @@ i40e_flow_parse_qinq_pattern(__rte_unused struct rte_eth_dev *dev,\n \t\titem_type = item->type;\n \t\tswitch (item_type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ETH:\n-\t\t\teth_spec = (const struct rte_flow_item_eth *)item->spec;\n-\t\t\teth_mask = (const struct rte_flow_item_eth *)item->mask;\n-\t\t\tif (eth_spec && eth_mask) {\n+\t\t\tif (item->spec || item->mask) {\n \t\t\t\trte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n \t\t\t\t\t\t item,\n-\t\t\t\t\t\t \"Invalid ether spec/mask\");\n+\t\t\t\t\t\t \"Invalid ETH item\");\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n \t\t\tbreak;\n", "prefixes": [ "dpdk-dev", "v2" ] }