Patch Detail
Show a patch.
GET /api/patches/230/?format=api
{ "id": 230, "url": "http://patches.dpdk.org/api/patches/230/?format=api", "web_url": "http://patches.dpdk.org/patch/230/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk" }, "msgid": "<1409062162-19575-5-git-send-email-david.marchand@6wind.com>", "date": "2014-08-26T14:09:14", "name": "[dpdk-dev,04/11] ixgbe: add log messages when rx bulk mode is not usable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "580710a13fee07ccfc051062903fbd320dbd1026", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/patch/230/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/230/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/230/checks/", "tags": {}, "headers": { "X-Mailer": "git-send-email 1.7.10.4", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "From": "David Marchand <david.marchand@6wind.com>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "Date": "Tue, 26 Aug 2014 16:09:14 +0200", "X-List-Received-Date": "Tue, 26 Aug 2014 14:05:35 -0000", "X-Mailman-Version": "2.1.15", "X-Gm-Message-State": "ALoCoQnsYAPAO0HfLkf4WqwqZ4vFxKAvpc+hQ0IOYz+X/NO0gaqpaD45PM5XcxEbCeAEkn/zgcQd", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "To": "dev@dpdk.org", "References": "<1409062162-19575-1-git-send-email-david.marchand@6wind.com>", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=4I8c/2aR8VoMtXCE4XqHjpdtD+Le040vPgSGZ6zs/t0=;\n\tb=bSjOc0ns+IjxBDiTtMzvSuJ1Yeb6Ek3diuVPaPsuBQBOhZnt+YC33u+kLt0EcY+EZ3\n\tZr4t/SDQM4Milt1lm/ONbVGuOkoF4g1wRcgSA9kJV9JXHoT7qLFsvRpuWEbp1gY9FF6U\n\tOyVp7MekkLH1bQFG3pdwbFpxtO1a0dAoWP5NrieeYrdAxin8fhSp7kODsMsP6L5EjY9g\n\tQ/GplnQU6tw0c2Z5XxhDQf68V4iQN7LwcJUJdBeTi9heUixCpXG2iZIyM3DReDhwqpAx\n\twhD/SJdAFJVpxBKo0hLXnsQcZQKyCmnLtxib4x0NBsE9hqrVI9Xk6vEm2jS/rSxG4elo\n\tG0oA==", "Return-Path": "<david.marchand@6wind.com>", "X-BeenThere": "dev@dpdk.org", "List-Post": "<mailto:dev@dpdk.org>", "Received": [ "from mail-we0-f169.google.com (mail-we0-f169.google.com\n\t[74.125.82.169]) by dpdk.org (Postfix) with ESMTP id 1A88FB37B\n\tfor <dev@dpdk.org>; Tue, 26 Aug 2014 16:05:35 +0200 (CEST)", "by mail-we0-f169.google.com with SMTP id u56so14740725wes.28\n\tfor <dev@dpdk.org>; Tue, 26 Aug 2014 07:09:35 -0700 (PDT)", "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tcy9sm12543569wib.18.2014.08.26.07.09.33 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Aug 2014 07:09:34 -0700 (PDT)" ], "X-Received": "by 10.180.73.142 with SMTP id l14mr3335499wiv.83.1409062175145; \n\tTue, 26 Aug 2014 07:09:35 -0700 (PDT)", "Subject": "[dpdk-dev] [PATCH 04/11] ixgbe: add log messages when rx bulk mode\n\tis not usable", "In-Reply-To": "<1409062162-19575-1-git-send-email-david.marchand@6wind.com>", "Message-Id": "<1409062162-19575-5-git-send-email-david.marchand@6wind.com>", "Precedence": "list", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>" }, "content": "Signed-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 29 ++++++++++++++++++++++++-----\n 1 file changed, 24 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex e2804bd..7d6c7ea 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -1969,15 +1969,34 @@ check_rx_burst_bulk_alloc_preconditions(__rte_unused struct igb_rx_queue *rxq)\n \t * outside of this function.\n \t */\n #ifdef RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC\n-\tif (! (rxq->rx_free_thresh >= RTE_PMD_IXGBE_RX_MAX_BURST))\n+\tif (! (rxq->rx_free_thresh >= RTE_PMD_IXGBE_RX_MAX_BURST)) {\n+\t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions: \"\n+\t\t\t \"rxq->rx_free_thresh=%d, \"\n+\t\t\t \"RTE_PMD_IXGBE_RX_MAX_BURST=%d\\n\",\n+\t\t\t rxq->rx_free_thresh, RTE_PMD_IXGBE_RX_MAX_BURST);\n \t\tret = -EINVAL;\n-\telse if (! (rxq->rx_free_thresh < rxq->nb_rx_desc))\n+\t} else if (! (rxq->rx_free_thresh < rxq->nb_rx_desc)) {\n+\t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions: \"\n+\t\t\t \"rxq->rx_free_thresh=%d, \"\n+\t\t\t \"rxq->nb_rx_desc=%d\\n\",\n+\t\t\t rxq->rx_free_thresh, rxq->nb_rx_desc);\n \t\tret = -EINVAL;\n-\telse if (! ((rxq->nb_rx_desc % rxq->rx_free_thresh) == 0))\n+\t} else if (! ((rxq->nb_rx_desc % rxq->rx_free_thresh) == 0)) {\n+\t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions: \"\n+\t\t\t \"rxq->nb_rx_desc=%d, \"\n+\t\t\t \"rxq->rx_free_thresh=%d\\n\",\n+\t\t\t rxq->nb_rx_desc, rxq->rx_free_thresh);\n \t\tret = -EINVAL;\n-\telse if (! (rxq->nb_rx_desc <\n-\t (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST)))\n+\t} else if (! (rxq->nb_rx_desc <\n+\t (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST))) {\n+\t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions: \"\n+\t\t\t \"rxq->nb_rx_desc=%d, \"\n+\t\t\t \"IXGBE_MAX_RING_DESC=%d, \"\n+\t\t\t \"RTE_PMD_IXGBE_RX_MAX_BURST=%d\\n\",\n+\t\t\t rxq->nb_rx_desc, IXGBE_MAX_RING_DESC,\n+\t\t\t RTE_PMD_IXGBE_RX_MAX_BURST);\n \t\tret = -EINVAL;\n+\t}\n #else\n \tret = -EINVAL;\n #endif\n", "prefixes": [ "dpdk-dev", "04/11" ] }