Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 21925,
    "url": "http://patches.dpdk.org/api/patches/21925/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1489820786-14226-15-git-send-email-rasesh.mody@cavium.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1489820786-14226-15-git-send-email-rasesh.mody@cavium.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1489820786-14226-15-git-send-email-rasesh.mody@cavium.com",
    "date": "2017-03-18T07:05:39",
    "name": "[dpdk-dev,v2,14/61] net/qede/base: update MFW when default MTU is changed",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "2a735b9b4fcff3a9a81057a5e748c332b8edb55c",
    "submitter": {
        "id": 569,
        "url": "http://patches.dpdk.org/api/people/569/?format=api",
        "name": "Mody, Rasesh",
        "email": "rasesh.mody@cavium.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1489820786-14226-15-git-send-email-rasesh.mody@cavium.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/21925/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/21925/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E3216CF9C;\n\tSat, 18 Mar 2017 08:11:47 +0100 (CET)",
            "from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com\n\t[67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 263A22B99\n\tfor <dev@dpdk.org>; Sat, 18 Mar 2017 08:11:43 +0100 (CET)",
            "from pps.filterd (m0085408.ppops.net [127.0.0.1])\n\tby mx0b-0016ce01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv2I7BZS7026027; Sat, 18 Mar 2017 00:11:41 -0700",
            "from avcashub1.qlogic.com ([198.186.0.115])\n\tby mx0b-0016ce01.pphosted.com with ESMTP id 29908ug02v-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tSat, 18 Mar 2017 00:11:41 -0700",
            "from avluser05.qlc.com (10.1.113.115) by avcashub1.qlogic.org\n\t(10.1.4.190) with Microsoft SMTP Server (TLS) id 14.3.235.1;\n\tSat, 18 Mar 2017 00:11:40 -0700",
            "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid v2I7Beag014667;\tSat, 18 Mar 2017 00:11:40 -0700"
        ],
        "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@cavium.com using -f",
        "From": "Rasesh Mody <rasesh.mody@cavium.com>",
        "To": "<dev@dpdk.org>, <ferruh.yigit@intel.com>",
        "CC": "Rasesh Mody <rasesh.mody@cavium.com>, <Dept-EngDPDKDev@cavium.com>",
        "Date": "Sat, 18 Mar 2017 00:05:39 -0700",
        "Message-ID": "<1489820786-14226-15-git-send-email-rasesh.mody@cavium.com>",
        "X-Mailer": "git-send-email 1.7.10.3",
        "In-Reply-To": "<162b5be7-d8a5-0e89-a32f-b1a992aef2a3@intel.com>",
        "References": "<162b5be7-d8a5-0e89-a32f-b1a992aef2a3@intel.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "disclaimer": "bypass",
        "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8470\n\tsignatures=668448",
        "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1702020001\n\tdefinitions=main-1703180075",
        "Subject": "[dpdk-dev] [PATCH v2 14/61] net/qede/base: update MFW when default\n\tMTU is changed",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Send mailbox command to Management FW when MTU changes.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_dev.c |   11 +++++++++++\n drivers/net/qede/base/ecore_mcp.c |    3 ---\n 2 files changed, 11 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c\nindex 7a501bb..13e13ba 100644\n--- a/drivers/net/qede/base/ecore_dev.c\n+++ b/drivers/net/qede/base/ecore_dev.c\n@@ -1629,6 +1629,7 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev,\n {\n \tenum _ecore_status_t rc = ECORE_SUCCESS, mfw_rc;\n \tu32 load_code, param, drv_mb_param;\n+\tbool b_default_mtu = true;\n \tstruct ecore_hwfn *p_hwfn;\n \tint i;\n \n@@ -1648,6 +1649,12 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev,\n \tfor_each_hwfn(p_dev, i) {\n \t\tstruct ecore_hwfn *p_hwfn = &p_dev->hwfns[i];\n \n+\t\t/* If management didn't provide a default, set one of our own */\n+\t\tif (!p_hwfn->hw_info.mtu) {\n+\t\t\tp_hwfn->hw_info.mtu = 1500;\n+\t\t\tb_default_mtu = false;\n+\t\t}\n+\n \t\tif (IS_VF(p_dev)) {\n \t\t\tp_hwfn->b_int_enabled = 1;\n \t\t\tcontinue;\n@@ -1776,6 +1783,10 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev,\n \t\t\treturn rc;\n \t\t}\n \n+\t\tif (!b_default_mtu)\n+\t\t\tecore_mcp_ov_update_mtu(p_hwfn, p_hwfn->p_main_ptt,\n+\t\t\t\t\t\tp_hwfn->hw_info.mtu);\n+\n \t\trc = ecore_mcp_ov_update_driver_state(p_hwfn,\n \t\t\t\t\t\t      p_hwfn->p_main_ptt,\n \t\t\t\t\t\tECORE_OV_DRIVER_STATE_DISABLED);\ndiff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c\nindex 8720ae7..0338576 100644\n--- a/drivers/net/qede/base/ecore_mcp.c\n+++ b/drivers/net/qede/base/ecore_mcp.c\n@@ -1438,9 +1438,6 @@ enum _ecore_status_t ecore_mcp_fill_shmem_func_info(struct ecore_hwfn *p_hwfn,\n \n \tinfo->mtu = (u16)shmem_info.mtu_size;\n \n-\tif (info->mtu == 0)\n-\t\tinfo->mtu = 1500;\n-\n \tDP_VERBOSE(p_hwfn, (ECORE_MSG_SP | ECORE_MSG_IFUP),\n \t\t   \"Read configuration from shmem: pause_on_host %02x\"\n \t\t    \" protocol %02x BW [%02x - %02x]\"\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "14/61"
    ]
}