Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 21666,
    "url": "http://patches.dpdk.org/api/patches/21666/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1489091282-195702-1-git-send-email-allain.legacy@windriver.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1489091282-195702-1-git-send-email-allain.legacy@windriver.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1489091282-195702-1-git-send-email-allain.legacy@windriver.com",
    "date": "2017-03-09T20:28:02",
    "name": "[dpdk-dev] net/virtio: disable LSC interrupt if MSIX not enabled",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2f10f037f5481930f1251a38aaa7eb02cd88ad92",
    "submitter": {
        "id": 679,
        "url": "http://patches.dpdk.org/api/people/679/?format=api",
        "name": "Allain Legacy",
        "email": "allain.legacy@windriver.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1489091282-195702-1-git-send-email-allain.legacy@windriver.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/21666/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/21666/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0A98037B4;\n\tThu,  9 Mar 2017 21:28:14 +0100 (CET)",
            "from mail1.windriver.com (mail1.windriver.com [147.11.146.13])\n\tby dpdk.org (Postfix) with ESMTP id 15FB83DC\n\tfor <dev@dpdk.org>; Thu,  9 Mar 2017 21:28:11 +0100 (CET)",
            "from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id v29KSA3D020994\n\t(version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);\n\tThu, 9 Mar 2017 12:28:10 -0800 (PST)",
            "from yow-cgts4-lx.wrs.com (128.224.145.137) by\n\tALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server\n\t(TLS) id 14.3.294.0; Thu, 9 Mar 2017 12:28:09 -0800"
        ],
        "From": "Allain Legacy <allain.legacy@windriver.com>",
        "To": "<yuanhan.liu@linux.intel.com>, <maxime.coquelin@redhat.com>",
        "CC": "<dev@dpdk.org>, <matt.peters@windriver.com>",
        "Date": "Thu, 9 Mar 2017 15:28:02 -0500",
        "Message-ID": "<1489091282-195702-1-git-send-email-allain.legacy@windriver.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[128.224.145.137]",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: disable LSC interrupt if MSIX not\n\tenabled",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Matt Peters <matt.peters@windriver.com>\n\nThe link state change interrupt can only be configured if the virtio device\nsupports MSIX.  Prior to this change the writing of the vector to the PCI\nconfig space was causing it to overwrite the initial part of the MAC\naddress since the MSIX vector is not in the config space and is occupied by\nthe MAC address.\n\nThis has been reproduced in Virtual Box (v5.0.30.r112061) in Windows 7\n\nSigned-off-by: Matt Peters <matt.peters@windriver.com>\nSigned-off-by: Allain Legacy <allain.legacy@windriver.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 4dc03b9..66770fc 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1338,11 +1338,11 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,\n \t\trte_eth_copy_pci_info(eth_dev, pci_dev);\n \t}\n \n-\t/* If host does not support status then disable LSC */\n-\tif (!vtpci_with_feature(hw, VIRTIO_NET_F_STATUS))\n-\t\teth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;\n-\telse\n+\t/* If host does not support both status and MSI-X then disable LSC */\n+\tif (vtpci_with_feature(hw, VIRTIO_NET_F_STATUS) && hw->use_msix)\n \t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;\n+\telse\n+\t\teth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;\n \n \trx_func_get(eth_dev);\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}