Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/216/?format=api
{ "id": 216, "url": "http://patches.dpdk.org/api/patches/216/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20140826020853.851222673@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20140826020853.851222673@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20140826020853.851222673@networkplumber.org", "date": "2014-08-26T02:07:54", "name": "[dpdk-dev,RFC,08/10] virtio: remove redundant vq_alignment", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "3bc21004cf1df9911be1efe7be89884acc8a49fa", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20140826020853.851222673@networkplumber.org/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/216/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<stephen@networkplumber.org>", "Received": [ "from mail-pd0-f182.google.com (mail-pd0-f182.google.com\n\t[209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 2AC0AB396\n\tfor <dev@dpdk.org>; Tue, 26 Aug 2014 04:04:59 +0200 (CEST)", "by mail-pd0-f182.google.com with SMTP id fp1so21324042pdb.41\n\tfor <dev@dpdk.org>; Mon, 25 Aug 2014 19:08:56 -0700 (PDT)", "from localhost (static-50-53-65-80.bvtn.or.frontiernet.net.\n\t[50.53.65.80]) by mx.google.com with ESMTPSA id\n\tkk7sm5152020pab.31.2014.08.25.19.08.54 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Aug 2014 19:08:55 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject\n\t:references:mime-version:content-type:content-disposition;\n\tbh=6t+jTkSsvGBYEZd94Mkgupql3YL92qX7xFSJcC5/us4=;\n\tb=JyIZdIPUj1FVtZWNeb+4W5cTN1RQ4Msskdr28DULdbvXLiL5GbXYzN81oh+kcqCF4i\n\t3RemtwIbbFWXtiwiIMkzFCkofLsq5ae3En6yZKT9Z4MsCVZuPD1eH3iBNHJO7rKFtItW\n\tAIboW9oJkthgTF9RlenJMqujRiA7hNg7ddhPIHhGoSbv25UUvQLvq4tYItyV9BmsKAyn\n\tb94VzQdGV1XdMJy+ADBLeAG5TQfyoKYtxauPZ1I09/lOuy4HmHEzuARCIGVT3X+85A9x\n\tCwhNR4NOiNM4cOs7zpig4nvXzew1es+kCTVna8cM4rpkcM6f1Yi/7ZTIstOFxvnBlcAX\n\tCazw==", "X-Gm-Message-State": "ALoCoQlNrAKmAH4/+XStzSBgDIc5qy2gupceKzRq2fbCR35ca4otWbLTNIS+Iz7xCyH4wqG3QQa5", "X-Received": "by 10.68.57.140 with SMTP id i12mr33662942pbq.44.1409018936173; \n\tMon, 25 Aug 2014 19:08:56 -0700 (PDT)", "Message-Id": "<20140826020853.851222673@networkplumber.org>", "User-Agent": "quilt/0.63-1", "Date": "Mon, 25 Aug 2014 19:07:54 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Ouyang Changchun <changchun.ouyang@intel.com>", "References": "<20140826020746.062748014@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Disposition": "inline; filename=virtio-no-align.patch", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [RFC 08/10] virtio: remove redundant vq_alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Aug 2014 02:04:59 -0000" }, "content": "Since vq_alignment is constant (always 4K), it does not\nneed to be part of the vring struct.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n\n---\n lib/librte_pmd_virtio/virtio_ethdev.c | 1 -\n lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-\n lib/librte_pmd_virtio/virtqueue.h | 3 +--\n 3 files changed, 2 insertions(+), 4 deletions(-)", "diff": "--- a/lib/librte_pmd_virtio/virtio_ethdev.c\t2014-08-25 19:00:09.918550097 -0700\n+++ b/lib/librte_pmd_virtio/virtio_ethdev.c\t2014-08-25 19:00:09.918550097 -0700\n@@ -290,7 +290,6 @@ int virtio_dev_queue_setup(struct rte_et\n \tvq->port_id = dev->data->port_id;\n \tvq->queue_id = queue_idx;\n \tvq->vq_queue_index = vtpci_queue_idx;\n-\tvq->vq_alignment = VIRTIO_PCI_VRING_ALIGN;\n \tvq->vq_nentries = vq_size;\n \tvq->vq_free_cnt = vq_size;\n \n--- a/lib/librte_pmd_virtio/virtio_rxtx.c\t2014-08-25 19:00:09.918550097 -0700\n+++ b/lib/librte_pmd_virtio/virtio_rxtx.c\t2014-08-25 19:00:09.918550097 -0700\n@@ -258,7 +258,7 @@ virtio_dev_vring_start(struct virtqueue\n \t * Reinitialise since virtio port might have been stopped and restarted\n \t */\n \tmemset(vq->vq_ring_virt_mem, 0, vq->vq_ring_size);\n-\tvring_init(vr, size, ring_mem, vq->vq_alignment);\n+\tvring_init(vr, size, ring_mem, VIRTIO_PCI_VRING_ALIGN);\n \tvq->vq_used_cons_idx = 0;\n \tvq->vq_desc_head_idx = 0;\n \tvq->vq_avail_idx = 0;\n--- a/lib/librte_pmd_virtio/virtqueue.h\t2014-08-25 19:00:09.918550097 -0700\n+++ b/lib/librte_pmd_virtio/virtqueue.h\t2014-08-25 19:00:09.918550097 -0700\n@@ -139,8 +139,7 @@ struct virtqueue {\n \tuint8_t port_id; /**< Device port identifier. */\n \n \tvoid *vq_ring_virt_mem; /**< linear address of vring*/\n-\tint vq_alignment;\n-\tint vq_ring_size;\n+\tunsigned int vq_ring_size;\n \tphys_addr_t vq_ring_mem; /**< physical address of vring */\n \n \tstruct vring vq_ring; /**< vring keeping desc, used and avail */\n", "prefixes": [ "dpdk-dev", "RFC", "08/10" ] }