Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21528/?format=api
{ "id": 21528, "url": "http://patches.dpdk.org/api/patches/21528/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170307091928.57990-2-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170307091928.57990-2-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170307091928.57990-2-qi.z.zhang@intel.com", "date": "2017-03-07T09:19:26", "name": "[dpdk-dev,v2,1/3] vfio: keep interrupt source read only", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3952e996eef2d89293b340f72e2bfe07f0491920", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170307091928.57990-2-qi.z.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/21528/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/21528/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 787E45A68;\n\tTue, 7 Mar 2017 09:29:13 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id E451E1BBE\n\tfor <dev@dpdk.org>; Tue, 7 Mar 2017 09:28:38 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Mar 2017 00:28:37 -0800", "from unknown (HELO localhost.localdomain.sh.intel.com)\n\t([10.239.129.167])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Mar 2017 00:28:36 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.35,257,1484035200\"; d=\"scan'208\";a=\"831813263\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas.monjalon@6wind.com", "Cc": "dev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Tue, 7 Mar 2017 04:19:26 -0500", "Message-Id": "<20170307091928.57990-2-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170307091928.57990-1-qi.z.zhang@intel.com>", "References": "<1487801822-30938-1-git-send-email-qi.z.zhang@intel.com>\n\t<20170307091928.57990-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/3] vfio: keep interrupt source read only", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove the inappropriate modification on get_max_intr\nfield that keep the intr_source read only.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 36 ++++------------------------\n 1 file changed, 4 insertions(+), 32 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\nindex 92a19cb..b50dad8 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n@@ -278,29 +278,6 @@ vfio_disable_msi(const struct rte_intr_handle *intr_handle) {\n \treturn ret;\n }\n \n-static int\n-get_max_intr(const struct rte_intr_handle *intr_handle)\n-{\n-\tstruct rte_intr_source *src;\n-\n-\tTAILQ_FOREACH(src, &intr_sources, next) {\n-\t\tif (src->intr_handle.fd != intr_handle->fd)\n-\t\t\tcontinue;\n-\n-\t\tif (src->intr_handle.max_intr < intr_handle->max_intr)\n-\t\t\tsrc->intr_handle.max_intr = intr_handle->max_intr;\n-\t\tif (!src->intr_handle.max_intr)\n-\t\t\tsrc->intr_handle.max_intr = 1;\n-\t\telse if (src->intr_handle.max_intr > RTE_MAX_RXTX_INTR_VEC_ID)\n-\t\t\tsrc->intr_handle.max_intr\n-\t\t\t\t= RTE_MAX_RXTX_INTR_VEC_ID + 1;\n-\n-\t\treturn src->intr_handle.max_intr;\n-\t}\n-\n-\treturn -1;\n-}\n-\n /* enable MSI-X interrupts */\n static int\n vfio_enable_msix(const struct rte_intr_handle *intr_handle) {\n@@ -313,15 +290,10 @@ vfio_enable_msix(const struct rte_intr_handle *intr_handle) {\n \n \tirq_set = (struct vfio_irq_set *) irq_set_buf;\n \tirq_set->argsz = len;\n-\n-\tret = get_max_intr(intr_handle);\n-\tif (ret < 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Invalid number of MSI-X irqs for fd %d\\n\",\n-\t\t\tintr_handle->fd);\n-\t\treturn -1;\n-\t}\n-\n-\tirq_set->count = ret;\n+\t/* 0 < irq_set->count < RTE_MAX_RXTX_INTR_VEC_ID + 1 */\n+\tirq_set->count = intr_handle->max_intr ?\n+\t\t(intr_handle->max_intr > RTE_MAX_RXTX_INTR_VEC_ID + 1 ?\n+\t\tRTE_MAX_RXTX_INTR_VEC_ID + 1 : intr_handle->max_intr) : 1;\n \tirq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD | VFIO_IRQ_SET_ACTION_TRIGGER;\n \tirq_set->index = VFIO_PCI_MSIX_IRQ_INDEX;\n \tirq_set->start = 0;\n", "prefixes": [ "dpdk-dev", "v2", "1/3" ] }