Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 21431,
    "url": "http://patches.dpdk.org/api/patches/21431/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1488794430-25179-4-git-send-email-jblunck@infradead.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1488794430-25179-4-git-send-email-jblunck@infradead.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1488794430-25179-4-git-send-email-jblunck@infradead.org",
    "date": "2017-03-06T09:59:55",
    "name": "[dpdk-dev,03/38] net/nfp: use library function for DMA zone reserve",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "30e91166f6b17d8388b58a21b74c1c32ed051187",
    "submitter": {
        "id": 249,
        "url": "http://patches.dpdk.org/api/people/249/?format=api",
        "name": "Jan Blunck",
        "email": "jblunck@infradead.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1488794430-25179-4-git-send-email-jblunck@infradead.org/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/21431/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/21431/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A5F4FAB08;\n\tMon,  6 Mar 2017 11:01:24 +0100 (CET)",
            "from mail-wr0-f195.google.com (mail-wr0-f195.google.com\n\t[209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 8FE223772\n\tfor <dev@dpdk.org>; Mon,  6 Mar 2017 11:00:48 +0100 (CET)",
            "by mail-wr0-f195.google.com with SMTP id u108so17051642wrb.2\n\tfor <dev@dpdk.org>; Mon, 06 Mar 2017 02:00:48 -0800 (PST)",
            "from weierstrass.local.net ([91.200.109.169])\n\tby smtp.gmail.com with ESMTPSA id\n\tu145sm3829237wmu.1.2017.03.06.02.00.47 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Mar 2017 02:00:47 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id:in-reply-to:references;\n\tbh=lnVE1c9paqy4Y/I7dIBvOESHnPQ6aJYkZLKf4ihdqjE=;\n\tb=A3bqyyL3Jp6lPdIn35QgUlOFZRUBiqzYppS+l23UUIz9zdYF8ggxEmBbP2rUyb5lUF\n\tIrVVGKaliyrhL+bHxSirQWS+fLrXr7AvKmDwZrHfLepWNqQUAOUhTykMVQaTxAt5qPrz\n\ttJA7sgcylE/MD1NpFH6oWkbttbwZW+7OW29ZcrOOFc6yBa6A2JbTqSF1ygxjhbizsozI\n\t3TxLc80kqJu6mkrqasCjxb544Koh+wkk0zb6hBFB700bGklHgSaOq4dGHFJjGdVVp/UO\n\tRnu3+m5NnHhtoDnq2x9xvSsw32n/bVtdm+FlbzrwhlNsZsTNaLRmGyEF7Kdgo/d8YROL\n\t69cQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=lnVE1c9paqy4Y/I7dIBvOESHnPQ6aJYkZLKf4ihdqjE=;\n\tb=SUueWqrpIAq43yq3Fl7z/dTok7aF6OO522GNeZANArnZ6hm3qyqPF9TkG/lXM9u4ZA\n\tbVeptQWGVjbbFAcUWgAx0TiQ8UXghKuFywYK8Qd8wbpik2dLblPZEVag4QeDASM/zI5c\n\tQ+yZvzLrszunFF6TxkwlQhEw8tBmmdO3vjRfRbCfGETiU1+UP4/iArHupwXgRU7MUV2X\n\tyeNWb79P8ej/VyCgKgfDW+Lqgxe8LNTNOc+d6d/BXHmFJpW9ckC0g0L81PAeRn5vBztn\n\tGWXwCf+enCtaz+KEFgHComuvyLbRDFaNqpjDNfr9NsD6PQe5ovQbBVaNK9Eys+8BtaAU\n\tclxQ==",
        "X-Gm-Message-State": "AMke39lKEihc52ZanlQMYuQSbHzsjs4lMwqjww5SvJEV4HBDeSqFaMVNWhIEAS4v5qOwkw==",
        "X-Received": "by 10.223.129.183 with SMTP id 52mr14760674wra.88.1488794448077; \n\tMon, 06 Mar 2017 02:00:48 -0800 (PST)",
        "From": "Jan Blunck <jblunck@infradead.org>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  6 Mar 2017 10:59:55 +0100",
        "Message-Id": "<1488794430-25179-4-git-send-email-jblunck@infradead.org>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>",
        "References": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>",
        "Subject": "[dpdk-dev] [PATCH 03/38] net/nfp: use library function for DMA zone\n\treserve",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This driver can use the library function rte_eth_dma_zone_reserve()\ninstead of duplicating the code.\n\nSigned-off-by: Jan Blunck <jblunck@infradead.org>\n---\n drivers/net/nfp/nfp_net.c | 30 ++++++------------------------\n 1 file changed, 6 insertions(+), 24 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex d79f262..b9dfe80 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -205,26 +205,6 @@ nn_cfg_writeq(struct nfp_net_hw *hw, int off, uint64_t val)\n \tnn_writeq(rte_cpu_to_le_64(val), hw->ctrl_bar + off);\n }\n \n-/* Creating memzone for hardware rings. */\n-static const struct rte_memzone *\n-ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,\n-\t\t      uint16_t queue_id, uint32_t ring_size, int socket_id)\n-{\n-\tchar z_name[RTE_MEMZONE_NAMESIZE];\n-\tconst struct rte_memzone *mz;\n-\n-\tsnprintf(z_name, sizeof(z_name), \"%s_%s_%d_%d\",\n-\t\t dev->driver->pci_drv.driver.name,\n-\t\t ring_name, dev->data->port_id, queue_id);\n-\n-\tmz = rte_memzone_lookup(z_name);\n-\tif (mz)\n-\t\treturn mz;\n-\n-\treturn rte_memzone_reserve_aligned(z_name, ring_size, socket_id, 0,\n-\t\t\t\t\t   NFP_MEMZONE_ALIGN);\n-}\n-\n /*\n  * Atomically reads link status information from global structure rte_eth_dev.\n  *\n@@ -1461,9 +1441,10 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,\n \t * handle the maximum ring size is allocated in order to allow for\n \t * resizing in later calls to the queue setup function.\n \t */\n-\ttz = ring_dma_zone_reserve(dev, \"rx_ring\", queue_idx,\n+\ttz = rte_eth_dma_zone_reserve(dev, \"rx_ring\", queue_idx,\n \t\t\t\t   sizeof(struct nfp_net_rx_desc) *\n-\t\t\t\t   NFP_NET_MAX_RX_DESC, socket_id);\n+\t\t\t\t   NFP_NET_MAX_RX_DESC, NFP_MEMZONE_ALIGN,\n+\t\t\t\t   socket_id);\n \n \tif (tz == NULL) {\n \t\tRTE_LOG(ERR, PMD, \"Error allocatig rx dma\\n\");\n@@ -1603,9 +1584,10 @@ nfp_net_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t * handle the maximum ring size is allocated in order to allow for\n \t * resizing in later calls to the queue setup function.\n \t */\n-\ttz = ring_dma_zone_reserve(dev, \"tx_ring\", queue_idx,\n+\ttz = rte_eth_dma_zone_reserve(dev, \"tx_ring\", queue_idx,\n \t\t\t\t   sizeof(struct nfp_net_tx_desc) *\n-\t\t\t\t   NFP_NET_MAX_TX_DESC, socket_id);\n+\t\t\t\t   NFP_NET_MAX_TX_DESC, NFP_MEMZONE_ALIGN,\n+\t\t\t\t   socket_id);\n \tif (tz == NULL) {\n \t\tRTE_LOG(ERR, PMD, \"Error allocating tx dma\\n\");\n \t\tnfp_net_tx_queue_release(txq);\n",
    "prefixes": [
        "dpdk-dev",
        "03/38"
    ]
}