Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20957,
    "url": "http://patches.dpdk.org/api/patches/20957/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170228185315.12546-16-aconole@redhat.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170228185315.12546-16-aconole@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170228185315.12546-16-aconole@redhat.com",
    "date": "2017-02-28T18:53:04",
    "name": "[dpdk-dev,v6,15/26] eal: do not panic on alarm init",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2f867e67f52543c51237b7b305e285fc3ecb0c50",
    "submitter": {
        "id": 332,
        "url": "http://patches.dpdk.org/api/people/332/?format=api",
        "name": "Aaron Conole",
        "email": "aconole@redhat.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170228185315.12546-16-aconole@redhat.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/20957/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/20957/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 596B7F964;\n\tTue, 28 Feb 2017 19:54:26 +0100 (CET)",
            "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id B4D652B86\n\tfor <dev@dpdk.org>; Tue, 28 Feb 2017 19:53:26 +0100 (CET)",
            "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3475080F95;\n\tTue, 28 Feb 2017 18:53:27 +0000 (UTC)",
            "from dhcp-25-97.bos.redhat.com ([10.18.25.172])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id v1SIrHWR019326; Tue, 28 Feb 2017 13:53:26 -0500"
        ],
        "From": "Aaron Conole <aconole@redhat.com>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tBruce Richardson <bruce.richardson@intel.com>",
        "Date": "Tue, 28 Feb 2017 13:53:04 -0500",
        "Message-Id": "<20170228185315.12546-16-aconole@redhat.com>",
        "In-Reply-To": "<20170228185315.12546-1-aconole@redhat.com>",
        "References": "<20170227161811.12309-1-aconole@redhat.com>\n\t<20170228185315.12546-1-aconole@redhat.com>",
        "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]); Tue, 28 Feb 2017 18:53:27 +0000 (UTC)",
        "Subject": "[dpdk-dev] [PATCH v6 15/26] eal: do not panic on alarm init",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "rte_eal_alarm_init() call uses the linux timerfd framework to create a\npoll()-able timer using standard posix file operations.  This could fail\nfor a few reasons given in the man-pages, but many could be\ncorrected by the user application.  No need to panic.\n\nSigned-off-by: Aaron Conole <aconole@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex aa10192..7aa6b6e 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -869,8 +869,11 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n-\tif (rte_eal_alarm_init() < 0)\n-\t\trte_panic(\"Cannot init interrupt-handling thread\\n\");\n+\tif (rte_eal_alarm_init() < 0) {\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\t/* rte_eal_alarm_init sets rte_errno on failure. */\n+\t\treturn -1;\n+\t}\n \n \tif (rte_eal_timer_init() < 0)\n \t\trte_panic(\"Cannot init HPET or TSC timers\\n\");\n",
    "prefixes": [
        "dpdk-dev",
        "v6",
        "15/26"
    ]
}