Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20922,
    "url": "http://patches.dpdk.org/api/patches/20922/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170227161811.12309-22-aconole@redhat.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170227161811.12309-22-aconole@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170227161811.12309-22-aconole@redhat.com",
    "date": "2017-02-27T16:18:06",
    "name": "[dpdk-dev,v5,21/26] eal: do not panic on failed PCI probe",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2d5527898a5269a198430719bbd4e87ea97795a0",
    "submitter": {
        "id": 332,
        "url": "http://patches.dpdk.org/api/people/332/?format=api",
        "name": "Aaron Conole",
        "email": "aconole@redhat.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170227161811.12309-22-aconole@redhat.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/20922/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/20922/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C4726F97F;\n\tMon, 27 Feb 2017 17:19:17 +0100 (CET)",
            "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id E1AF8BD28\n\tfor <dev@dpdk.org>; Mon, 27 Feb 2017 17:18:24 +0100 (CET)",
            "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 56CECC05681A;\n\tMon, 27 Feb 2017 16:18:25 +0000 (UTC)",
            "from dhcp-25-97.bos.redhat.com (dhcp-25-172.bos.redhat.com\n\t[10.18.25.172])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id v1RGICK1003061; Mon, 27 Feb 2017 11:18:24 -0500"
        ],
        "From": "Aaron Conole <aconole@redhat.com>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tBruce Richardson <bruce.richardson@intel.com>",
        "Date": "Mon, 27 Feb 2017 11:18:06 -0500",
        "Message-Id": "<20170227161811.12309-22-aconole@redhat.com>",
        "In-Reply-To": "<20170227161811.12309-1-aconole@redhat.com>",
        "References": "<20170225160309.31270-1-aconole@redhat.com>\n\t<20170227161811.12309-1-aconole@redhat.com>",
        "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]); Mon, 27 Feb 2017 16:18:25 +0000 (UTC)",
        "Subject": "[dpdk-dev] [PATCH v5 21/26] eal: do not panic on failed PCI probe",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "It may even be possible to simply log the error and continue on letting\nthe user check the logs and restart the application when things are failed.\n\nSigned-off-by: Aaron Conole <aconole@redhat.com>\n---\n lib/librte_eal/linuxapp/eal/eal.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 291fa53..fbc1dcc 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -943,8 +943,11 @@ rte_eal_init(int argc, char **argv)\n \t\trte_panic(\"Cannot probe devices\\n\");\n \n \t/* Probe & Initialize PCI devices */\n-\tif (rte_eal_pci_probe())\n-\t\trte_panic(\"Cannot probe PCI\\n\");\n+\tif (rte_eal_pci_probe()) {\n+\t\tRTE_LOG(ERR, EAL, \"Cannot probe PCI\\n\");\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n+\t}\n \n \tif (rte_eal_dev_init() < 0)\n \t\trte_panic(\"Cannot init pmd devices\\n\");\n",
    "prefixes": [
        "dpdk-dev",
        "v5",
        "21/26"
    ]
}