Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20915/?format=api
{ "id": 20915, "url": "http://patches.dpdk.org/api/patches/20915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170227161811.12309-15-aconole@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170227161811.12309-15-aconole@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170227161811.12309-15-aconole@redhat.com", "date": "2017-02-27T16:17:59", "name": "[dpdk-dev,v5,14/26] eal: do not panic on tailq init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3f8bbb7245e96e197b2c10ac54451893eebc030c", "submitter": { "id": 332, "url": "http://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170227161811.12309-15-aconole@redhat.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/20915/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/20915/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0A77FF951;\n\tMon, 27 Feb 2017 17:19:03 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id C331F2E81\n\tfor <dev@dpdk.org>; Mon, 27 Feb 2017 17:18:20 +0100 (CET)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3A71F3B74F;\n\tMon, 27 Feb 2017 16:18:21 +0000 (UTC)", "from dhcp-25-97.bos.redhat.com (dhcp-25-172.bos.redhat.com\n\t[10.18.25.172])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id v1RGICJs003061; Mon, 27 Feb 2017 11:18:20 -0500" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Mon, 27 Feb 2017 11:17:59 -0500", "Message-Id": "<20170227161811.12309-15-aconole@redhat.com>", "In-Reply-To": "<20170227161811.12309-1-aconole@redhat.com>", "References": "<20170225160309.31270-1-aconole@redhat.com>\n\t<20170227161811.12309-1-aconole@redhat.com>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]); Mon, 27 Feb 2017 16:18:21 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v5 14/26] eal: do not panic on tailq init", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are some theoretical racy conditions in the system that _could_\ncause early tailq init to fail; however, no need to panic the\napplication. While it can't continue using DPDK, it could make better\nalerts to the user.\n\nSigned-off-by: Aaron Conole <aconole@redhat.com>\n---\n lib/librte_eal/common/eal_common_tailqs.c | 3 +--\n lib/librte_eal/linuxapp/eal/eal.c | 7 +++++--\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_tailqs.c b/lib/librte_eal/common/eal_common_tailqs.c\nindex bb08ec8..4f69828 100644\n--- a/lib/librte_eal/common/eal_common_tailqs.c\n+++ b/lib/librte_eal/common/eal_common_tailqs.c\n@@ -188,8 +188,7 @@ rte_eal_tailqs_init(void)\n \t\tif (t->head == NULL) {\n \t\t\tRTE_LOG(ERR, EAL,\n \t\t\t\t\"Cannot initialize tailq: %s\\n\", t->name);\n-\t\t\t/* no need to TAILQ_REMOVE, we are going to panic in\n-\t\t\t * rte_eal_init() */\n+\t\t\t/* TAILQ_REMOVE not needed, error is already fatal */\n \t\t\tgoto fail;\n \t\t}\n \t}\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 799f5f6..e0767c0 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -863,8 +863,11 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n-\tif (rte_eal_tailqs_init() < 0)\n-\t\trte_panic(\"Cannot init tail queues for objects\\n\");\n+\tif (rte_eal_tailqs_init() < 0) {\n+\t\tRTE_LOG(ERR, EAL, \"Cannot init tail queues for objects\\n\");\n+\t\trte_errno = EFAULT;\n+\t\treturn -1;\n+\t}\n \n \tif (rte_eal_alarm_init() < 0)\n \t\trte_panic(\"Cannot init interrupt-handling thread\\n\");\n", "prefixes": [ "dpdk-dev", "v5", "14/26" ] }