Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2091,
    "url": "http://patches.dpdk.org/api/patches/2091/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1418902316-30266-1-git-send-email-nhorman@tuxdriver.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1418902316-30266-1-git-send-email-nhorman@tuxdriver.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1418902316-30266-1-git-send-email-nhorman@tuxdriver.com",
    "date": "2014-12-18T11:31:56",
    "name": "[dpdk-dev,v2] xenvirt: Fix build break on cmdline_parse_etheraddr call",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9b7aff6cde15a27b2aa7999502cba63367206790",
    "submitter": {
        "id": 32,
        "url": "http://patches.dpdk.org/api/people/32/?format=api",
        "name": "Neil Horman",
        "email": "nhorman@tuxdriver.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1418902316-30266-1-git-send-email-nhorman@tuxdriver.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/2091/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/2091/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 235CA7DF0;\n\tThu, 18 Dec 2014 12:32:09 +0100 (CET)",
            "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 33CC468BF\n\tfor <dev@dpdk.org>; Thu, 18 Dec 2014 12:32:08 +0100 (CET)",
            "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1Y1ZJM-0003iO-64; Thu, 18 Dec 2014 06:32:06 -0500"
        ],
        "From": "Neil Horman <nhorman@tuxdriver.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 18 Dec 2014 06:31:56 -0500",
        "Message-Id": "<1418902316-30266-1-git-send-email-nhorman@tuxdriver.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "In-Reply-To": "<1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>",
        "References": "<1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>",
        "X-Spam-Score": "-2.9 (--)",
        "X-Spam-Status": "No",
        "Subject": "[dpdk-dev] [PATCH v2] xenvirt: Fix build break on\n\tcmdline_parse_etheraddr call",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Back in:\n\ncommit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db\nAuthor: Alan Carew <alan.carew@intel.com>\nDate:   Fri Dec 5 15:19:07 2014 +0100\n\n    cmdline: fix overflow on bsd\n\nThe author failed to fixup a call to cmdline_parse_etheraddr in xenvirt.  This\npatch makes the needed correction to avoid a build break\n\nSigned-off-by: Neil Horman <nhorman@tuxdriver.com>\nCC: Thomas Monjalon <thomas.monjalon@6wind.com>\nCC: Olivier Matz <olivier.matz@6wind.com>\n\n---\nChange notes\n\nv2: Changed sizeof(struct ether_addr) to sizeof(dict->addr)\n---\n lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c\nindex 6555ec5..04e30c9 100644\n--- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c\n+++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c\n@@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict,\n \t\tif (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,\n \t\t\t\tsizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {\n \t\t\tif (cmdline_parse_etheraddr(NULL,\n-\t\t\t\t\t\t\tpair[1],\n-\t\t\t\t\t\t\t&dict->addr) < 0) {\n+\t\t\t\t\t\t    pair[1],\n+\t\t\t\t\t\t    &dict->addr,\n+\t\t\t\t\t\t    sizeof(dict->addr)) < 0) {\n \t\t\t\tRTE_LOG(ERR, PMD,\n \t\t\t\t\t\"Invalid %s device ether address\\n\",\n \t\t\t\t\tname);\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}