Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2087/?format=api
{ "id": 2087, "url": "http://patches.dpdk.org/api/patches/2087/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1418853558-2445-4-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1418853558-2445-4-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1418853558-2445-4-git-send-email-thomas.monjalon@6wind.com", "date": "2014-12-17T21:59:18", "name": "[dpdk-dev,3/3] mk: fix link with CC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b5150ad116888844b324e4127ec5ced4f806b9f8", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1418853558-2445-4-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/2087/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/2087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 904388043;\n\tWed, 17 Dec 2014 23:00:08 +0100 (CET)", "from mail-wi0-f174.google.com (mail-wi0-f174.google.com\n\t[209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 8FF147F48\n\tfor <dev@dpdk.org>; Wed, 17 Dec 2014 22:59:56 +0100 (CET)", "by mail-wi0-f174.google.com with SMTP id h11so17292973wiw.7\n\tfor <dev@dpdk.org>; Wed, 17 Dec 2014 13:59:56 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tjs5sm22467293wid.11.2014.12.17.13.59.54 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 17 Dec 2014 13:59:55 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=czU8hIL5qp9TfdG7liilzKE4G6aWtzo9YcrR3vZhwfM=;\n\tb=Bn6dwxrc5hwX/w/gQb2PIzjOW5JQ9QBrPhENN+zcWDaNivV5Zl4WhoGjKa6Qt47JiT\n\trr2yFKNl00nlq0vWPZb+3XqLBd17yo8Lo9nMCDJb/Qhr/hSXgUD5Pg7pR5LTMMG23lbV\n\tWEXIVSbaBXDmfaAv2EfR+fUo81tOXuK7eGieeoeFahoOwQDP1PZwfwanY+zjy6BP3ug9\n\tNmbhmxljOvlgI75CoEoYC10z2sw1prcbrQG2L4uP6D46LEp42qsyO5jChGx8749SCwKl\n\tLHstfvypL9LHSFMFKdB2RtNZA7kEBtIJJgxaIL6+TkSHuGH5wwYBsIu166S7rpu1xAnT\n\tvRHw==", "X-Gm-Message-State": "ALoCoQlEnaQziyZ9WAhhEeakOxwT3m7++KaCaSGNsotFADY9JSBot4zrjxCahsugDkx2mMUXmXS4", "X-Received": "by 10.180.218.39 with SMTP id pd7mr18624395wic.21.1418853596426; \n\tWed, 17 Dec 2014 13:59:56 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 17 Dec 2014 22:59:18 +0100", "Message-Id": "<1418853558-2445-4-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.1.3", "In-Reply-To": "<1418853558-2445-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<2594499.JbYxbdnDqd@xps13>\n\t<1418853558-2445-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 3/3] mk: fix link with CC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It appeared in commit 21cdc2e77a4ca999 (\"fix 32-bit link with gcc\")\nthat linker options must be prefixed by -Wl, when using CC.\nSo CPU_LDFLAGS is prefixed in rte.lib.mk.\nThen commit 815cfb7925bb6de (\"fix link of combined shared library using CC\")\nintroduced another prefixing of CPU_LDFLAGS in rte.sharelib.mk,\nincluded in lib/Makefile.\nBecause CPU_LDFLAGS is an exported variable, the prefixing is done twice.\nInitial patch of commit 815cfb7925bb6de had a workaround but it hasn't\nbeen applied in favor of this proper fix.\n\nNow variables are not overriden when prefixing.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.app.mk | 5 ++---\n mk/rte.lib.mk | 6 ++++--\n mk/rte.shared.mk | 6 ++----\n mk/rte.sharelib.mk | 8 +++++---\n 4 files changed, 13 insertions(+), 12 deletions(-)", "diff": "diff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 3c35985..e1a0dbf 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -256,11 +256,10 @@ LDLIBS += -l$(RTE_LIBNAME)\n endif\n \n ifeq ($(LINK_USING_CC),1)\n-LDLIBS := $(call linkerprefix,$(LDLIBS))\n-LDFLAGS := $(call linkerprefix,$(LDFLAGS))\n override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))\n O_TO_EXE = $(CC) $(CFLAGS) $(LDFLAGS_$(@)) \\\n-\t-Wl,-Map=$(@).map,--cref -o $@ $(OBJS-y) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LDLIBS)\n+\t-Wl,-Map=$(@).map,--cref -o $@ $(OBJS-y) $(call linkerprefix,$(LDFLAGS)) \\\n+\t$(EXTRA_LDFLAGS) $(call linkerprefix,$(LDLIBS))\n else\n O_TO_EXE = $(LD) $(LDFLAGS) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n \t-Map=$(@).map --cref -o $@ $(OBJS-y) $(LDLIBS)\ndiff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex a67c129..81bf8e1 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -62,7 +62,9 @@ exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))\n ifeq ($(LINK_USING_CC),1)\n # Override the definition of LD here, since we're linking with CC\n LD := $(CC) $(CPU_CFLAGS)\n-CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))\n+_CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))\n+else\n+_CPU_LDFLAGS := $(CPU_LDFLAGS)\n endif\n \n O_TO_A = $(AR) crus $(LIB) $(OBJS-y)\n@@ -74,7 +76,7 @@ O_TO_A_DO = @set -e; \\\n \t$(O_TO_A) && \\\n \techo $(O_TO_A_CMD) > $(call exe2cmd,$(@))\n \n-O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)\n+O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)\n O_TO_S_STR = $(subst ','\\'',$(O_TO_S)) #'# fix syntax highlight\n O_TO_S_DISP = $(if $(V),\"$(O_TO_S_STR)\",\" LD $(@)\")\n O_TO_S_DO = @set -e; \\\ndiff --git a/mk/rte.shared.mk b/mk/rte.shared.mk\nindex 42feee7..fc6b0b4 100644\n--- a/mk/rte.shared.mk\n+++ b/mk/rte.shared.mk\n@@ -58,11 +58,9 @@ build: _postbuild\n exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))\n \n ifeq ($(LINK_USING_CC),1)\n-LDLIBS := $(call linkerprefix,$(LDLIBS))\n-LDFLAGS := $(call linkerprefix,$(LDFLAGS))\n override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))\n-O_TO_SO = $(CC) $(LDFLAGS) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n-\t-shared -o $@ $(OBJS-y) $(LDLIBS)\n+O_TO_SO = $(CC) $(call linkerprefix,$(LDFLAGS)) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n+\t-shared -o $@ $(OBJS-y) $(call linkerprefix,$(LDLIBS))\n else\n O_TO_SO = $(LD) $(LDFLAGS) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n \t-shared -o $@ $(OBJS-y) $(LDLIBS)\ndiff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk\nindex d0cc7e3..de53558 100644\n--- a/mk/rte.sharelib.mk\n+++ b/mk/rte.sharelib.mk\n@@ -50,11 +50,13 @@ OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)\n ifeq ($(LINK_USING_CC),1)\n # Override the definition of LD here, since we're linking with CC\n LD := $(CC) $(CPU_CFLAGS)\n-CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))\n+O_TO_S = $(LD) $(call linkerprefix,$(CPU_LDFLAGS)) \\\n+\t-shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)\n+else\n+O_TO_S = $(LD) $(CPU_LDFLAGS) \\\n+\t-shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)\n endif\n \n-O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) \\\n-\t-o $(RTE_OUTPUT)/lib/$(LIB_ONE)\n O_TO_S_STR = $(subst ','\\'',$(O_TO_S)) #'# fix syntax highlight\n O_TO_S_DISP = $(if $(V),\"$(O_TO_S_STR)\",\" LD $(@)\")\n O_TO_S_CMD = \"cmd_$@ = $(O_TO_S_STR)\"\n", "prefixes": [ "dpdk-dev", "3/3" ] }