Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2086/?format=api
{ "id": 2086, "url": "http://patches.dpdk.org/api/patches/2086/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1418853558-2445-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1418853558-2445-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1418853558-2445-3-git-send-email-thomas.monjalon@6wind.com", "date": "2014-12-17T21:59:17", "name": "[dpdk-dev,2/3] mk: forbid multiple definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c01781e13bdbfad69a324482c571e2b98d7a317c", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1418853558-2445-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/2086/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/2086/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 366848040;\n\tWed, 17 Dec 2014 23:00:06 +0100 (CET)", "from mail-wg0-f52.google.com (mail-wg0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 008B57F48\n\tfor <dev@dpdk.org>; Wed, 17 Dec 2014 22:59:54 +0100 (CET)", "by mail-wg0-f52.google.com with SMTP id x12so21431061wgg.11\n\tfor <dev@dpdk.org>; Wed, 17 Dec 2014 13:59:54 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tjs5sm22467293wid.11.2014.12.17.13.59.53 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 17 Dec 2014 13:59:53 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=e5up1qc4lL3FiYX4OmxBUTYUVSQ8IQ3t+wu4bWA/PSw=;\n\tb=dZGZIp9NZroI2FGItRRyZZ31vs218hcrPdhf3hYJFGTHpQh+Y+GQgHxxyneu9eaNSD\n\tmO1rzoxgerym0Ekptbf4vf3Lq/tepO0NMfjTuf8X7iVl4tQYhOi0LplnzcZl1/rmb5PJ\n\tc5xKyFGs6GR9jo4wTHk2pALoD07FNnaTb1A0vkyXvW4zuYrruGbch+tzy4BG4Fnak/Za\n\tEOSZbtC0u2rh2BQd36L9s+WxZ1+wpan4ugJATstMkXXGen92mxZSGqXD4Q58l167ur0M\n\tUNuBoWGOm5fffCllfdtwFU90V8Ut8aQOmI/nL893nF4klqt2gJm1r+xhvempupkiw1pt\n\tBwEQ==", "X-Gm-Message-State": "ALoCoQnIZccdDSkYkbqWXWSJxfGuB64lL6i6MNUnDs2cZZNS9hQ02wFDK4ALw+GhUdJ2DIodzbMr", "X-Received": "by 10.194.86.165 with SMTP id q5mr77112074wjz.10.1418853594704; \n\tWed, 17 Dec 2014 13:59:54 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 17 Dec 2014 22:59:17 +0100", "Message-Id": "<1418853558-2445-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.1.3", "In-Reply-To": "<1418853558-2445-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<2594499.JbYxbdnDqd@xps13>\n\t<1418853558-2445-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 2/3] mk: forbid multiple definitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The option \"-z muldefs\" was set only if not using ld directly.\nBy the way, this option seems to be a useless hack introduced\nwith shared and combined libraries support (e25e4d7ef16b8aa84de).\nThe clean approach is to remove it.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.lib.mk | 5 ++---\n mk/rte.sharelib.mk | 3 +--\n 2 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex d83e808..a67c129 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -62,7 +62,6 @@ exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))\n ifeq ($(LINK_USING_CC),1)\n # Override the definition of LD here, since we're linking with CC\n LD := $(CC) $(CPU_CFLAGS)\n-LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)\n CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))\n endif\n \n@@ -75,7 +74,7 @@ O_TO_A_DO = @set -e; \\\n \t$(O_TO_A) && \\\n \techo $(O_TO_A_CMD) > $(call exe2cmd,$(@))\n \n-O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS-y) -o $(LIB)\n+O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)\n O_TO_S_STR = $(subst ','\\'',$(O_TO_S)) #'# fix syntax highlight\n O_TO_S_DISP = $(if $(V),\"$(O_TO_S_STR)\",\" LD $(@)\")\n O_TO_S_DO = @set -e; \\\n@@ -91,7 +90,7 @@ O_TO_C_DO = @set -e; \\\n \t$(lib_dir) \\\n \t$(copy_obj)\n else\n-O_TO_C = $(LD) $(LD_MULDEFS) -shared $(OBJS-y) -o $(LIB_ONE)\n+O_TO_C = $(LD) -shared $(OBJS-y) -o $(LIB_ONE)\n O_TO_C_STR = $(subst ','\\'',$(O_TO_C)) #'# fix syntax highlight\n O_TO_C_DISP = $(if $(V),\"$(O_TO_C_STR)\",\" LD_C $(@)\")\n O_TO_C_DO = @set -e; \\\ndiff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk\nindex d0ec12a..d0cc7e3 100644\n--- a/mk/rte.sharelib.mk\n+++ b/mk/rte.sharelib.mk\n@@ -50,11 +50,10 @@ OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)\n ifeq ($(LINK_USING_CC),1)\n # Override the definition of LD here, since we're linking with CC\n LD := $(CC) $(CPU_CFLAGS)\n-LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)\n CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))\n endif\n \n-O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS) \\\n+O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) \\\n \t-o $(RTE_OUTPUT)/lib/$(LIB_ONE)\n O_TO_S_STR = $(subst ','\\'',$(O_TO_S)) #'# fix syntax highlight\n O_TO_S_DISP = $(if $(V),\"$(O_TO_S_STR)\",\" LD $(@)\")\n", "prefixes": [ "dpdk-dev", "2/3" ] }