Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20848/?format=api
{ "id": 20848, "url": "http://patches.dpdk.org/api/patches/20848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1488182237-10247-14-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488182237-10247-14-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1488182237-10247-14-git-send-email-rasesh.mody@cavium.com", "date": "2017-02-27T07:56:29", "name": "[dpdk-dev,13/61] net/qede/base: change queue/sb-id from 8 bit to 16 bit", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3be332115fe3a24fb0897a5b8d7c4992677392e4", "submitter": { "id": 569, "url": "http://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1488182237-10247-14-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/20848/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/20848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 404E8F977;\n\tMon, 27 Feb 2017 08:58:18 +0100 (CET)", "from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com\n\t[67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 844C9F95A\n\tfor <dev@dpdk.org>; Mon, 27 Feb 2017 08:58:00 +0100 (CET)", "from pps.filterd (m0085408.ppops.net [127.0.0.1])\n\tby mx0b-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv1R7vTnl010874; Sun, 26 Feb 2017 23:57:58 -0800", "from avcashub1.qlogic.com ([198.186.0.117])\n\tby mx0b-0016ce01.pphosted.com with ESMTP id 28ut281v1y-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tSun, 26 Feb 2017 23:57:58 -0800", "from avluser05.qlc.com (10.1.113.115) by qlc.com (10.1.4.192) with\n\tMicrosoft SMTP Server id 14.3.235.1;\n\tSun, 26 Feb 2017 23:57:57 -0800", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid v1R7vvuE010405;\tSun, 26 Feb 2017 23:57:57 -0800" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@cavium.com using -f", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "<dev@dpdk.org>", "CC": "Rasesh Mody <rasesh.mody@cavium.com>, <Dept-EngDPDKDev@cavium.com>", "Date": "Sun, 26 Feb 2017 23:56:29 -0800", "Message-ID": "<1488182237-10247-14-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1488182237-10247-1-git-send-email-rasesh.mody@cavium.com>", "References": "<1488182237-10247-1-git-send-email-rasesh.mody@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8451\n\tsignatures=669242", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1702020001\n\tdefinitions=main-1702270081", "Subject": "[dpdk-dev] [PATCH 13/61] net/qede/base: change queue/sb-id from 8\n\tbit to 16 bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the queue/sb-id values from 8 bit fields to 16 bit fields.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_dev.c | 8 ++++----\n drivers/net/qede/base/ecore_dev_api.h | 4 ++--\n drivers/net/qede/base/ecore_l2.c | 2 +-\n drivers/net/qede/base/ecore_l2_api.h | 2 +-\n drivers/net/qede/base/ecore_sriov.c | 4 ++--\n 5 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c\nindex 2c768d8..ea087a7 100644\n--- a/drivers/net/qede/base/ecore_dev.c\n+++ b/drivers/net/qede/base/ecore_dev.c\n@@ -3884,7 +3884,7 @@ static enum _ecore_status_t ecore_set_coalesce(struct ecore_hwfn *p_hwfn,\n \n enum _ecore_status_t ecore_set_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n \t\t\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t\t\t u16 coalesce, u8 qid, u16 sb_id)\n+\t\t\t\t\t u16 coalesce, u16 qid, u16 sb_id)\n {\n \tstruct ustorm_eth_queue_zone eth_qzone;\n \tu8 timeset, timer_res;\n@@ -3905,7 +3905,7 @@ enum _ecore_status_t ecore_set_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n \t}\n \ttimeset = (u8)(coalesce >> timer_res);\n \n-\trc = ecore_fw_l2_queue(p_hwfn, (u16)qid, &fw_qid);\n+\trc = ecore_fw_l2_queue(p_hwfn, qid, &fw_qid);\n \tif (rc != ECORE_SUCCESS)\n \t\treturn rc;\n \n@@ -3927,7 +3927,7 @@ enum _ecore_status_t ecore_set_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n \n enum _ecore_status_t ecore_set_txq_coalesce(struct ecore_hwfn *p_hwfn,\n \t\t\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t\t\t u16 coalesce, u8 qid, u16 sb_id)\n+\t\t\t\t\t u16 coalesce, u16 qid, u16 sb_id)\n {\n \tstruct xstorm_eth_queue_zone eth_qzone;\n \tu8 timeset, timer_res;\n@@ -3949,7 +3949,7 @@ enum _ecore_status_t ecore_set_txq_coalesce(struct ecore_hwfn *p_hwfn,\n \n \ttimeset = (u8)(coalesce >> timer_res);\n \n-\trc = ecore_fw_l2_queue(p_hwfn, (u16)qid, &fw_qid);\n+\trc = ecore_fw_l2_queue(p_hwfn, qid, &fw_qid);\n \tif (rc != ECORE_SUCCESS)\n \t\treturn rc;\n \ndiff --git a/drivers/net/qede/base/ecore_dev_api.h b/drivers/net/qede/base/ecore_dev_api.h\nindex 0dee68a..e7332ac 100644\n--- a/drivers/net/qede/base/ecore_dev_api.h\n+++ b/drivers/net/qede/base/ecore_dev_api.h\n@@ -535,7 +535,7 @@ enum _ecore_status_t ecore_final_cleanup(struct ecore_hwfn\t*p_hwfn,\n */\n enum _ecore_status_t ecore_set_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n \t\t\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t\t\t u16 coalesce, u8 qid, u16 sb_id);\n+\t\t\t\t\t u16 coalesce, u16 qid, u16 sb_id);\n \n /**\n * @brief ecore_set_txq_coalesce - Configure coalesce parameters for a Tx queue\n@@ -553,6 +553,6 @@ enum _ecore_status_t ecore_set_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n */\n enum _ecore_status_t ecore_set_txq_coalesce(struct ecore_hwfn *p_hwfn,\n \t\t\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t\t\t u16 coalesce, u8 qid, u16 sb_id);\n+\t\t\t\t\t u16 coalesce, u16 qid, u16 sb_id);\n \n #endif\ndiff --git a/drivers/net/qede/base/ecore_l2.c b/drivers/net/qede/base/ecore_l2.c\nindex 22bb43d..1379a1b 100644\n--- a/drivers/net/qede/base/ecore_l2.c\n+++ b/drivers/net/qede/base/ecore_l2.c\n@@ -212,7 +212,7 @@ enum _ecore_status_t\n \n \tfor (i = 0; i < ECORE_RSS_IND_TABLE_SIZE; i++) {\n \t\trc = ecore_fw_l2_queue(p_hwfn,\n-\t\t\t\t (u8)p_rss->rss_ind_table[i],\n+\t\t\t\t p_rss->rss_ind_table[i],\n \t\t\t\t &abs_l2_queue);\n \t\tif (rc != ECORE_SUCCESS)\n \t\t\treturn rc;\ndiff --git a/drivers/net/qede/base/ecore_l2_api.h b/drivers/net/qede/base/ecore_l2_api.h\nindex 247316b..8f7b614 100644\n--- a/drivers/net/qede/base/ecore_l2_api.h\n+++ b/drivers/net/qede/base/ecore_l2_api.h\n@@ -37,7 +37,7 @@ struct ecore_queue_start_common_params {\n \t/* q_zone_id is relative, may be different from queue id\n \t * currently used by Tx-only, upper-bounded by number of FW-queues\n \t */\n-\tu8 qzone_id;\n+\tu16 qzone_id;\n \n \t/* stats_id is relative or absolute depends on function */\n \tu8 stats_id;\ndiff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c\nindex cda4516..a6c4b6e 100644\n--- a/drivers/net/qede/base/ecore_sriov.c\n+++ b/drivers/net/qede/base/ecore_sriov.c\n@@ -2120,8 +2120,8 @@ static void ecore_iov_vf_mbx_start_txq(struct ecore_hwfn *p_hwfn,\n \t !ecore_iov_validate_sb(p_hwfn, vf, req->hw_sb))\n \t\tgoto out;\n \n-\tparams.queue_id = (u8)vf->vf_queues[req->tx_qid].fw_tx_qid;\n-\tparams.qzone_id = (u8)vf->vf_queues[req->tx_qid].fw_tx_qid;\n+\tparams.queue_id = vf->vf_queues[req->tx_qid].fw_tx_qid;\n+\tparams.qzone_id = vf->vf_queues[req->tx_qid].fw_tx_qid;\n \tparams.vport_id = vf->vport_id;\n \tparams.stats_id = vf->abs_vf_id + 0x10;\n \tparams.sb = req->hw_sb;\n", "prefixes": [ "dpdk-dev", "13/61" ] }