Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20635,
    "url": "http://patches.dpdk.org/api/patches/20635/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1487647073-129064-13-git-send-email-david.hunt@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1487647073-129064-13-git-send-email-david.hunt@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1487647073-129064-13-git-send-email-david.hunt@intel.com",
    "date": "2017-02-21T03:17:48",
    "name": "[dpdk-dev,v7,12/17] example: add extra stats to distributor sample",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1eaf77bc010072d2728357dc83e0ceeed0af7e09",
    "submitter": {
        "id": 342,
        "url": "http://patches.dpdk.org/api/people/342/?format=api",
        "name": "Hunt, David",
        "email": "david.hunt@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1487647073-129064-13-git-send-email-david.hunt@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/20635/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/20635/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D3DFDF95D;\n\tTue, 21 Feb 2017 11:18:02 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id CDAEE5911\n\tfor <dev@dpdk.org>; Tue, 21 Feb 2017 11:17:30 +0100 (CET)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Feb 2017 02:17:29 -0800",
            "from silpixa00397515.ir.intel.com (HELO\n\tsilpixa00397515.ger.corp.intel.com) ([10.237.223.14])\n\tby fmsmga004.fm.intel.com with ESMTP; 21 Feb 2017 02:17:28 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.35,189,1484035200\"; d=\"scan'208\";a=\"227857110\"",
        "From": "David Hunt <david.hunt@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "bruce.richardson@intel.com,\n\tDavid Hunt <david.hunt@intel.com>",
        "Date": "Tue, 21 Feb 2017 03:17:48 +0000",
        "Message-Id": "<1487647073-129064-13-git-send-email-david.hunt@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1487647073-129064-1-git-send-email-david.hunt@intel.com>",
        "References": "<1485163480-156507-2-git-send-email-david.hunt@intel.com>\n\t<1487647073-129064-1-git-send-email-david.hunt@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v7 12/17] example: add extra stats to distributor\n\tsample",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This will allow us to see what's going on at various stages\nthroughout the sample app, with per-second visibility\n\nSigned-off-by: David Hunt <david.hunt@intel.com>\n---\n examples/distributor/main.c | 139 +++++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 123 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/examples/distributor/main.c b/examples/distributor/main.c\nindex 350d6f6..6634e2f 100644\n--- a/examples/distributor/main.c\n+++ b/examples/distributor/main.c\n@@ -54,24 +54,53 @@\n \n #define RTE_LOGTYPE_DISTRAPP RTE_LOGTYPE_USER1\n \n+#define ANSI_COLOR_RED     \"\\x1b[31m\"\n+#define ANSI_COLOR_RESET   \"\\x1b[0m\"\n+\n /* mask of enabled ports */\n static uint32_t enabled_port_mask;\n volatile uint8_t quit_signal;\n volatile uint8_t quit_signal_rx;\n+volatile uint8_t quit_signal_dist;\n \n static volatile struct app_stats {\n \tstruct {\n \t\tuint64_t rx_pkts;\n \t\tuint64_t returned_pkts;\n \t\tuint64_t enqueued_pkts;\n+\t\tuint64_t enqdrop_pkts;\n \t} rx __rte_cache_aligned;\n+\tint pad1 __rte_cache_aligned;\n+\n+\tstruct {\n+\t\tuint64_t in_pkts;\n+\t\tuint64_t ret_pkts;\n+\t\tuint64_t sent_pkts;\n+\t\tuint64_t enqdrop_pkts;\n+\t} dist __rte_cache_aligned;\n+\tint pad2 __rte_cache_aligned;\n \n \tstruct {\n \t\tuint64_t dequeue_pkts;\n \t\tuint64_t tx_pkts;\n+\t\tuint64_t enqdrop_pkts;\n \t} tx __rte_cache_aligned;\n+\tint pad3 __rte_cache_aligned;\n+\n+\tuint64_t worker_pkts[64] __rte_cache_aligned;\n+\n+\tint pad4 __rte_cache_aligned;\n+\n+\tuint64_t worker_bursts[64][8] __rte_cache_aligned;\n+\n+\tint pad5 __rte_cache_aligned;\n+\n+\tuint64_t port_rx_pkts[64] __rte_cache_aligned;\n+\tuint64_t port_tx_pkts[64] __rte_cache_aligned;\n } app_stats;\n \n+struct app_stats prev_app_stats;\n+\n static const struct rte_eth_conf port_conf_default = {\n \t.rxmode = {\n \t\t.mq_mode = ETH_MQ_RX_RSS,\n@@ -93,6 +122,8 @@ struct output_buffer {\n \tstruct rte_mbuf *mbufs[BURST_SIZE];\n };\n \n+static void print_stats(void);\n+\n /*\n  * Initialises a given port using global settings and with the rx buffers\n  * coming from the mbuf_pool passed as parameter\n@@ -378,25 +409,91 @@ static void\n print_stats(void)\n {\n \tstruct rte_eth_stats eth_stats;\n-\tunsigned i;\n-\n-\tprintf(\"\\nRX thread stats:\\n\");\n-\tprintf(\" - Received:    %\"PRIu64\"\\n\", app_stats.rx.rx_pkts);\n-\tprintf(\" - Processed:   %\"PRIu64\"\\n\", app_stats.rx.returned_pkts);\n-\tprintf(\" - Enqueued:    %\"PRIu64\"\\n\", app_stats.rx.enqueued_pkts);\n-\n-\tprintf(\"\\nTX thread stats:\\n\");\n-\tprintf(\" - Dequeued:    %\"PRIu64\"\\n\", app_stats.tx.dequeue_pkts);\n-\tprintf(\" - Transmitted: %\"PRIu64\"\\n\", app_stats.tx.tx_pkts);\n+\tunsigned int i, j;\n+\tconst unsigned int num_workers = rte_lcore_count() - 4;\n \n \tfor (i = 0; i < rte_eth_dev_count(); i++) {\n \t\trte_eth_stats_get(i, &eth_stats);\n-\t\tprintf(\"\\nPort %u stats:\\n\", i);\n-\t\tprintf(\" - Pkts in:   %\"PRIu64\"\\n\", eth_stats.ipackets);\n-\t\tprintf(\" - Pkts out:  %\"PRIu64\"\\n\", eth_stats.opackets);\n-\t\tprintf(\" - In Errs:   %\"PRIu64\"\\n\", eth_stats.ierrors);\n-\t\tprintf(\" - Out Errs:  %\"PRIu64\"\\n\", eth_stats.oerrors);\n-\t\tprintf(\" - Mbuf Errs: %\"PRIu64\"\\n\", eth_stats.rx_nombuf);\n+\t\tapp_stats.port_rx_pkts[i] = eth_stats.ipackets;\n+\t\tapp_stats.port_tx_pkts[i] = eth_stats.opackets;\n+\t}\n+\n+\tprintf(\"\\n\\nRX Thread:\\n\");\n+\tfor (i = 0; i < rte_eth_dev_count(); i++) {\n+\t\tprintf(\"Port %u Pktsin : %5.2f\\n\", i,\n+\t\t\t\t(app_stats.port_rx_pkts[i] -\n+\t\t\t\tprev_app_stats.port_rx_pkts[i])/1000000.0);\n+\t\tprev_app_stats.port_rx_pkts[i] = app_stats.port_rx_pkts[i];\n+\t}\n+\tprintf(\" - Received:    %5.2f\\n\",\n+\t\t\t(app_stats.rx.rx_pkts -\n+\t\t\tprev_app_stats.rx.rx_pkts)/1000000.0);\n+\tprintf(\" - Returned:    %5.2f\\n\",\n+\t\t\t(app_stats.rx.returned_pkts -\n+\t\t\tprev_app_stats.rx.returned_pkts)/1000000.0);\n+\tprintf(\" - Enqueued:    %5.2f\\n\",\n+\t\t\t(app_stats.rx.enqueued_pkts -\n+\t\t\tprev_app_stats.rx.enqueued_pkts)/1000000.0);\n+\tprintf(\" - Dropped:     %s%5.2f%s\\n\", ANSI_COLOR_RED,\n+\t\t\t(app_stats.rx.enqdrop_pkts -\n+\t\t\tprev_app_stats.rx.enqdrop_pkts)/1000000.0,\n+\t\t\tANSI_COLOR_RESET);\n+\n+\tprintf(\"Distributor thread:\\n\");\n+\tprintf(\" - In:          %5.2f\\n\",\n+\t\t\t(app_stats.dist.in_pkts -\n+\t\t\tprev_app_stats.dist.in_pkts)/1000000.0);\n+\tprintf(\" - Returned:    %5.2f\\n\",\n+\t\t\t(app_stats.dist.ret_pkts -\n+\t\t\tprev_app_stats.dist.ret_pkts)/1000000.0);\n+\tprintf(\" - Sent:        %5.2f\\n\",\n+\t\t\t(app_stats.dist.sent_pkts -\n+\t\t\tprev_app_stats.dist.sent_pkts)/1000000.0);\n+\tprintf(\" - Dropped      %s%5.2f%s\\n\", ANSI_COLOR_RED,\n+\t\t\t(app_stats.dist.enqdrop_pkts -\n+\t\t\tprev_app_stats.dist.enqdrop_pkts)/1000000.0,\n+\t\t\tANSI_COLOR_RESET);\n+\n+\tprintf(\"TX thread:\\n\");\n+\tprintf(\" - Dequeued:    %5.2f\\n\",\n+\t\t\t(app_stats.tx.dequeue_pkts -\n+\t\t\tprev_app_stats.tx.dequeue_pkts)/1000000.0);\n+\tfor (i = 0; i < rte_eth_dev_count(); i++) {\n+\t\tprintf(\"Port %u Pktsout: %5.2f\\n\",\n+\t\t\t\ti, (app_stats.port_tx_pkts[i] -\n+\t\t\t\tprev_app_stats.port_tx_pkts[i])/1000000.0);\n+\t\tprev_app_stats.port_tx_pkts[i] = app_stats.port_tx_pkts[i];\n+\t}\n+\tprintf(\" - Transmitted: %5.2f\\n\",\n+\t\t\t(app_stats.tx.tx_pkts -\n+\t\t\tprev_app_stats.tx.tx_pkts)/1000000.0);\n+\tprintf(\" - Dropped:     %s%5.2f%s\\n\", ANSI_COLOR_RED,\n+\t\t\t(app_stats.tx.enqdrop_pkts -\n+\t\t\tprev_app_stats.tx.enqdrop_pkts)/1000000.0,\n+\t\t\tANSI_COLOR_RESET);\n+\n+\tprev_app_stats.rx.rx_pkts = app_stats.rx.rx_pkts;\n+\tprev_app_stats.rx.returned_pkts = app_stats.rx.returned_pkts;\n+\tprev_app_stats.rx.enqueued_pkts = app_stats.rx.enqueued_pkts;\n+\tprev_app_stats.rx.enqdrop_pkts = app_stats.rx.enqdrop_pkts;\n+\tprev_app_stats.dist.in_pkts = app_stats.dist.in_pkts;\n+\tprev_app_stats.dist.ret_pkts = app_stats.dist.ret_pkts;\n+\tprev_app_stats.dist.sent_pkts = app_stats.dist.sent_pkts;\n+\tprev_app_stats.dist.enqdrop_pkts = app_stats.dist.enqdrop_pkts;\n+\tprev_app_stats.tx.dequeue_pkts = app_stats.tx.dequeue_pkts;\n+\tprev_app_stats.tx.tx_pkts = app_stats.tx.tx_pkts;\n+\tprev_app_stats.tx.enqdrop_pkts = app_stats.tx.enqdrop_pkts;\n+\n+\tfor (i = 0; i < num_workers; i++) {\n+\t\tprintf(\"Worker %02u Pkts: %5.2f. Bursts(1-8): \", i,\n+\t\t\t\t(app_stats.worker_pkts[i] -\n+\t\t\t\tprev_app_stats.worker_pkts[i])/1000000.0);\n+\t\tfor (j = 0; j < 8; j++) {\n+\t\t\tprintf(\"%\"PRIu64\" \", app_stats.worker_bursts[i][j]);\n+\t\t\tapp_stats.worker_bursts[i][j] = 0;\n+\t\t}\n+\t\tprintf(\"\\n\");\n+\t\tprev_app_stats.worker_pkts[i] = app_stats.worker_pkts[i];\n \t}\n }\n \n@@ -502,6 +599,7 @@ main(int argc, char *argv[])\n \tunsigned nb_ports;\n \tuint8_t portid;\n \tuint8_t nb_ports_available;\n+\tuint64_t t, freq;\n \n \t/* catch ctrl-c so we can print on exit */\n \tsignal(SIGINT, int_handler);\n@@ -596,6 +694,15 @@ main(int argc, char *argv[])\n \tif (lcore_rx(&p) != 0)\n \t\treturn -1;\n \n+\tfreq = rte_get_timer_hz();\n+\tt = __rdtsc() + freq;\n+\twhile (!quit_signal_dist) {\n+\t\tif (t < __rdtsc()) {\n+\t\t\tprint_stats();\n+\t\t\tt = _rdtsc() + freq;\n+\t\t}\n+\t}\n+\n \tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n \t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n \t\t\treturn -1;\n",
    "prefixes": [
        "dpdk-dev",
        "v7",
        "12/17"
    ]
}