Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20102/?format=api
http://patches.dpdk.org/api/patches/20102/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1485879273-86228-4-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1485879273-86228-4-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1485879273-86228-4-git-send-email-harry.van.haaren@intel.com", "date": "2017-01-31T16:14:21", "name": "[dpdk-dev,v2,03/15] event/sw: add new software-only eventdev driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0ededcc312fb1d4a321c8caa235daec94741d819", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 10, "url": "http://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1485879273-86228-4-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/20102/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/20102/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C24C6AB08;\n\tTue, 31 Jan 2017 17:15:16 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 3844DFFA\n\tfor <dev@dpdk.org>; Tue, 31 Jan 2017 17:14:48 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 31 Jan 2017 08:14:48 -0800", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby FMSMGA003.fm.intel.com with ESMTP; 31 Jan 2017 08:14:47 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,315,1477983600\"; d=\"scan'208\";a=\"815468136\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "jerin.jacob@caviumnetworks.com,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tHarry van Haaren <harry.van.haaren@intel.com>", "Date": "Tue, 31 Jan 2017 16:14:21 +0000", "Message-Id": "<1485879273-86228-4-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1485879273-86228-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1484580885-148524-1-git-send-email-harry.van.haaren@intel.com>\n\t<1485879273-86228-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 03/15] event/sw: add new software-only\n\teventdev driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nThis adds the minimal changes to allow a SW eventdev implementation to\nbe compiled, linked and created at run time. The eventdev does nothing,\nbut can be created via vdev on commandline, e.g.\n\n sudo ./x86_64-native-linuxapp-gcc/app/test --vdev=event_sw0\n ...\n PMD: Creating eventdev sw device event_sw0, numa_node=0, sched_quanta=128\n RTE>>\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n config/common_base | 5 +\n drivers/event/Makefile | 1 +\n drivers/event/sw/Makefile | 66 ++++++++++\n drivers/event/sw/rte_pmd_evdev_sw_version.map | 3 +\n drivers/event/sw/sw_evdev.c | 178 ++++++++++++++++++++++++++\n drivers/event/sw/sw_evdev.h | 63 +++++++++\n mk/rte.app.mk | 1 +\n 7 files changed, 317 insertions(+)\n create mode 100644 drivers/event/sw/Makefile\n create mode 100644 drivers/event/sw/rte_pmd_evdev_sw_version.map\n create mode 100644 drivers/event/sw/sw_evdev.c\n create mode 100644 drivers/event/sw/sw_evdev.h", "diff": "diff --git a/config/common_base b/config/common_base\nindex 00af811..6f91172 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -434,6 +434,11 @@ CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV=y\n CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG=n\n \n #\n+# Compile PMD for software event device\n+#\n+CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV=y\n+\n+#\n # Compile librte_ring\n #\n CONFIG_RTE_LIBRTE_RING=y\ndiff --git a/drivers/event/Makefile b/drivers/event/Makefile\nindex 678279f..353441c 100644\n--- a/drivers/event/Makefile\n+++ b/drivers/event/Makefile\n@@ -32,5 +32,6 @@\n include $(RTE_SDK)/mk/rte.vars.mk\n \n DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += skeleton\n+DIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += sw\n \n include $(RTE_SDK)/mk/rte.subdir.mk\ndiff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile\nnew file mode 100644\nindex 0000000..d6836e3\n--- /dev/null\n+++ b/drivers/event/sw/Makefile\n@@ -0,0 +1,66 @@\n+# BSD LICENSE\n+#\n+# Copyright(c) 2016-2017 Intel Corporation. All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions\n+# are met:\n+#\n+# * Redistributions of source code must retain the above copyright\n+# notice, this list of conditions and the following disclaimer.\n+# * Redistributions in binary form must reproduce the above copyright\n+# notice, this list of conditions and the following disclaimer in\n+# the documentation and/or other materials provided with the\n+# distribution.\n+# * Neither the name of Intel Corporation nor the names of its\n+# contributors may be used to endorse or promote products derived\n+# from this software without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+# \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+\n+# library name\n+LIB = librte_pmd_sw_event.a\n+\n+# build flags\n+CFLAGS += -O3\n+CFLAGS += $(WERROR_FLAGS)\n+# for older GCC versions, allow us to initialize an event using\n+# designated initializers.\n+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)\n+ifeq ($(shell test $(GCC_VERSION) -le 50 && echo 1), 1)\n+CFLAGS += -Wno-missing-field-initializers\n+endif\n+endif\n+\n+# library version\n+LIBABIVER := 1\n+\n+# versioning export map\n+EXPORT_MAP := rte_pmd_evdev_sw_version.map\n+\n+# library source files\n+SRCS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += sw_evdev.c\n+\n+# export include files\n+SYMLINK-y-include +=\n+\n+# library dependencies\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += lib/librte_eal\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += lib/librte_eventdev\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += lib/librte_kvargs\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += lib/librte_ring\n+\n+include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/event/sw/rte_pmd_evdev_sw_version.map b/drivers/event/sw/rte_pmd_evdev_sw_version.map\nnew file mode 100644\nindex 0000000..1f84b68\n--- /dev/null\n+++ b/drivers/event/sw/rte_pmd_evdev_sw_version.map\n@@ -0,0 +1,3 @@\n+DPDK_17.02 {\n+\tlocal: *;\n+};\ndiff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c\nnew file mode 100644\nindex 0000000..d60f00f\n--- /dev/null\n+++ b/drivers/event/sw/sw_evdev.c\n@@ -0,0 +1,178 @@\n+/*-\n+ * BSD LICENSE\n+ *\n+ * Copyright(c) 2016-2017 Intel Corporation. All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions\n+ * are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ * * Redistributions in binary form must reproduce the above copyright\n+ * notice, this list of conditions and the following disclaimer in\n+ * the documentation and/or other materials provided with the\n+ * distribution.\n+ * * Neither the name of Intel Corporation nor the names of its\n+ * contributors may be used to endorse or promote products derived\n+ * from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include <string.h>\n+\n+#include <rte_vdev.h>\n+#include <rte_memzone.h>\n+#include <rte_kvargs.h>\n+#include <rte_ring.h>\n+\n+#include \"sw_evdev.h\"\n+\n+#define EVENTDEV_NAME_SW_PMD event_sw\n+#define NUMA_NODE_ARG \"numa_node\"\n+#define SCHED_QUANTA_ARG \"sched_quanta\"\n+#define CREDIT_QUANTA_ARG \"credit_quanta\"\n+\n+static int\n+assign_numa_node(const char *key __rte_unused, const char *value, void *opaque)\n+{\n+\tint *socket_id = opaque;\n+\t*socket_id = atoi(value);\n+\tif (*socket_id > RTE_MAX_NUMA_NODES)\n+\t\treturn -1;\n+\treturn 0;\n+}\n+\n+static int\n+set_sched_quanta(const char *key __rte_unused, const char *value, void *opaque)\n+{\n+\tint *quanta = opaque;\n+\t*quanta = atoi(value);\n+\tif (*quanta < 0 || *quanta > 4096)\n+\t\treturn -1;\n+\treturn 0;\n+}\n+\n+static int\n+set_credit_quanta(const char *key __rte_unused, const char *value, void *opaque)\n+{\n+\tint *credit = opaque;\n+\t*credit = atoi(value);\n+\tif (*credit < 0 || *credit > 128)\n+\t\treturn -1;\n+\treturn 0;\n+}\n+\n+static int\n+sw_probe(const char *name, const char *params)\n+{\n+\tstatic const struct rte_eventdev_ops evdev_sw_ops = {\n+\t};\n+\n+\tstatic const char *const args[] = {\n+\t\tNUMA_NODE_ARG,\n+\t\tSCHED_QUANTA_ARG,\n+\t\tCREDIT_QUANTA_ARG,\n+\t\tNULL\n+\t};\n+\tstruct rte_eventdev *dev;\n+\tstruct sw_evdev *sw;\n+\tint socket_id = rte_socket_id();\n+\tint sched_quanta = SW_DEFAULT_SCHED_QUANTA;\n+\tint credit_quanta = SW_DEFAULT_CREDIT_QUANTA;\n+\n+\tif (params != NULL && params[0] != '\\0') {\n+\t\tstruct rte_kvargs *kvlist = rte_kvargs_parse(params, args);\n+\n+\t\tif (!kvlist) {\n+\t\t\tRTE_LOG(INFO, PMD,\n+\t\t\t\t\"Ignoring unsupported parameters when creating device '%s'\\n\",\n+\t\t\t\tname);\n+\t\t} else {\n+\t\t\tint ret = rte_kvargs_process(kvlist, NUMA_NODE_ARG,\n+\t\t\t\t\tassign_numa_node, &socket_id);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tRTE_LOG(ERR, PMD,\n+\t\t\t\t\t\"%s: Error parsing numa node parameter\",\n+\t\t\t\t\tname);\n+\t\t\t\trte_kvargs_free(kvlist);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\n+\t\t\tret = rte_kvargs_process(kvlist, SCHED_QUANTA_ARG,\n+\t\t\t\t\tset_sched_quanta, &sched_quanta);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tRTE_LOG(ERR, PMD,\n+\t\t\t\t\t\"%s: Error parsing sched quanta parameter\",\n+\t\t\t\t\tname);\n+\t\t\t\trte_kvargs_free(kvlist);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\n+\t\t\tret = rte_kvargs_process(kvlist, CREDIT_QUANTA_ARG,\n+\t\t\t\t\tset_credit_quanta, &credit_quanta);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tRTE_LOG(ERR, PMD,\n+\t\t\t\t\t\"%s: Error parsing credit quanta parameter\",\n+\t\t\t\t\tname);\n+\t\t\t\trte_kvargs_free(kvlist);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\n+\t\t\trte_kvargs_free(kvlist);\n+\t\t}\n+\t}\n+\n+\tRTE_LOG(INFO, PMD,\n+\t\t\t\"Creating eventdev sw device %s, numa_node=%d, sched_quanta=%d, credit_quanta=%d\\n\",\n+\t\t\tname, socket_id, sched_quanta, credit_quanta);\n+\n+\tdev = rte_event_pmd_vdev_init(name,\n+\t\t\tsizeof(struct sw_evdev), socket_id);\n+\tif (dev == NULL) {\n+\t\tprintf(\"eventdev vdev init() failed\");\n+\t\treturn -EFAULT;\n+\t}\n+\tdev->dev_ops = &evdev_sw_ops;\n+\n+\tsw = dev->data->dev_private;\n+\tsw->data = dev->data;\n+\n+\t/* copy values passed from vdev command line to instance */\n+\tsw->credit_update_quanta = credit_quanta;\n+\tsw->sched_quanta = sched_quanta;\n+\n+\treturn 0;\n+}\n+\n+static int\n+sw_remove(const char *name)\n+{\n+\tif (name == NULL)\n+\t\treturn -EINVAL;\n+\n+\tRTE_LOG(INFO, PMD, \"Closing eventdev sw device %s\\n\", name);\n+\t/* TODO unregister eventdev and release memzone */\n+\n+\treturn 0;\n+}\n+\n+static struct rte_vdev_driver evdev_sw_pmd_drv = {\n+\t.probe = sw_probe,\n+\t.remove = sw_remove\n+};\n+\n+RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SW_PMD, evdev_sw_pmd_drv);\n+RTE_PMD_REGISTER_PARAM_STRING(event_sw, NUMA_NODE_ARG \"=<int> \"\n+\t\tSCHED_QUANTA_ARG \"=<int>\" CREDIT_QUANTA_ARG \"=<int>\");\ndiff --git a/drivers/event/sw/sw_evdev.h b/drivers/event/sw/sw_evdev.h\nnew file mode 100644\nindex 0000000..9494659\n--- /dev/null\n+++ b/drivers/event/sw/sw_evdev.h\n@@ -0,0 +1,63 @@\n+/*-\n+ * BSD LICENSE\n+ *\n+ * Copyright(c) 2016-2017 Intel Corporation. All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions\n+ * are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ * * Redistributions in binary form must reproduce the above copyright\n+ * notice, this list of conditions and the following disclaimer in\n+ * the documentation and/or other materials provided with the\n+ * distribution.\n+ * * Neither the name of Intel Corporation nor the names of its\n+ * contributors may be used to endorse or promote products derived\n+ * from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#ifndef _SW_EVDEV_H_\n+#define _SW_EVDEV_H_\n+\n+#include <rte_eventdev.h>\n+#include <rte_eventdev_pmd.h>\n+\n+#define SW_DEFAULT_CREDIT_QUANTA 32\n+#define SW_DEFAULT_SCHED_QUANTA 128\n+\n+struct sw_evdev {\n+\tstruct rte_eventdev_data *data;\n+\n+\tint32_t sched_quanta;\n+\tuint32_t credit_update_quanta;\n+};\n+\n+static inline struct sw_evdev *\n+sw_pmd_priv(const struct rte_eventdev *eventdev)\n+{\n+\treturn eventdev->data->dev_private;\n+}\n+\n+static inline const struct sw_evdev *\n+sw_pmd_priv_const(const struct rte_eventdev *eventdev)\n+{\n+\treturn eventdev->data->dev_private;\n+}\n+\n+extern int sched_quanta;\n+\n+#endif /* _SW_EVDEV_H_ */\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 8341c13..8dc0f9f 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -150,6 +150,7 @@ endif # CONFIG_RTE_LIBRTE_CRYPTODEV\n \n ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += -lrte_pmd_skeleton_event\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += -lrte_pmd_sw_event\n endif # CONFIG_RTE_LIBRTE_EVENTDEV\n \n endif # !CONFIG_RTE_BUILD_SHARED_LIBS\n", "prefixes": [ "dpdk-dev", "v2", "03/15" ] }{ "id": 20102, "url": "