Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20006,
    "url": "http://patches.dpdk.org/api/patches/20006/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1485399942-94705-1-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1485399942-94705-1-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1485399942-94705-1-git-send-email-jianfeng.tan@intel.com",
    "date": "2017-01-26T03:05:42",
    "name": "[dpdk-dev] net/virtio-user: check value returned from malloc",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "95583413f0656b5b1a48712b4c3bf04a503b3fe4",
    "submitter": {
        "id": 313,
        "url": "http://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1485399942-94705-1-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/20006/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/20006/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C4FF32BB0;\n\tThu, 26 Jan 2017 04:05:02 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id CC6931023\n\tfor <dev@dpdk.org>; Thu, 26 Jan 2017 04:05:00 +0100 (CET)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga102.jf.intel.com with ESMTP; 25 Jan 2017 19:04:59 -0800",
            "from dpdk06.sh.intel.com ([10.239.129.195])\n\tby orsmga005.jf.intel.com with ESMTP; 25 Jan 2017 19:04:58 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.33,287,1477983600\"; d=\"scan'208\";a=\"57334918\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yuanhan.liu@linux.intel.com, john.mcnamara@intel.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>",
        "Date": "Thu, 26 Jan 2017 03:05:42 +0000",
        "Message-Id": "<1485399942-94705-1-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: check value returned from malloc",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Value returned from malloc is not checked for errors before being used.\nThis patch fixes following coverity issue.\n\n    static struct vhost_memory_kernel *\n    prepare_vhost_memory_kernel(void)\n    {\n        ...\n        vm = malloc(sizeof(struct vhost_memory_kernel) +\n                    max_regions *\n                    sizeof(struct vhost_memory_region));\n        ...\n    >>>     CID 140744:    (NULL_RETURNS)\n    >>>     Dereferencing a null pointer \"vm\".\n                mr = &vm->regions[k++];\n\nFixes: e3b434818bbb (\"net/virtio-user: support kernel vhost\")\nCoverity issue: 140744\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtio_user/vhost_kernel.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c\nindex 9b6637d..05aa6c6 100644\n--- a/drivers/net/virtio/virtio_user/vhost_kernel.c\n+++ b/drivers/net/virtio/virtio_user/vhost_kernel.c\n@@ -114,6 +114,8 @@ prepare_vhost_memory_kernel(void)\n \tvm = malloc(sizeof(struct vhost_memory_kernel) +\n \t\t    max_regions *\n \t\t    sizeof(struct vhost_memory_region));\n+\tif (!vm)\n+\t\treturn NULL;\n \n \tfor (i = 0; i < RTE_MAX_MEMSEG; ++i) {\n \t\tseg = &rte_eal_get_configuration()->mem_config->memseg[i];\n",
    "prefixes": [
        "dpdk-dev"
    ]
}