Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20001/?format=api
{ "id": 20001, "url": "http://patches.dpdk.org/api/patches/20001/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1485354963-17326-2-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1485354963-17326-2-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1485354963-17326-2-git-send-email-bernard.iremonger@intel.com", "date": "2017-01-25T14:36:01", "name": "[dpdk-dev,v5,1/3] net/i40e: fix segmentation fault in close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1366d4b446ebc433f58fc94dcb6781a9da603492", "submitter": { "id": 91, "url": "http://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1485354963-17326-2-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/20001/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/20001/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 32B2B559A;\n\tWed, 25 Jan 2017 15:36:20 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 2F4A3DE5;\n\tWed, 25 Jan 2017 15:36:12 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jan 2017 06:36:11 -0800", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga004.fm.intel.com with ESMTP; 25 Jan 2017 06:36:10 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,284,1477983600\"; d=\"scan'208\";a=\"217494202\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org,\n\twenzhuo.lu@intel.com,\n\tjingjing.wu@intel.com", "Cc": "Bernard Iremonger <bernard.iremonger@intel.com>,\n\tstable@dpdk.org", "Date": "Wed, 25 Jan 2017 14:36:01 +0000", "Message-Id": "<1485354963-17326-2-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1484671162-18493-1-git-send-email-bernard.iremonger@intel.com>", "References": "<1484671162-18493-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 1/3] net/i40e: fix segmentation fault in close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the order of releasing the vsi's.\nRelease the vmdq vsi's first, then release the main vsi.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\n\nCC: stable@dpdk.org\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\nAcked-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex a818998..0937dc4 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1,7 +1,7 @@\n /*-\n * BSD LICENSE\n *\n- * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.\n+ * Copyright(c) 2010-2017 Intel Corporation. All rights reserved.\n * All rights reserved.\n *\n * Redistribution and use in source and binary forms, with or without\n@@ -2072,18 +2072,17 @@ i40e_dev_close(struct rte_eth_dev *dev)\n \t/* shutdown and destroy the HMC */\n \ti40e_shutdown_lan_hmc(hw);\n \n-\t/* release all the existing VSIs and VEBs */\n-\ti40e_fdir_teardown(pf);\n-\ti40e_vsi_release(pf->main_vsi);\n-\n \tfor (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) {\n \t\ti40e_vsi_release(pf->vmdq[i].vsi);\n \t\tpf->vmdq[i].vsi = NULL;\n \t}\n-\n \trte_free(pf->vmdq);\n \tpf->vmdq = NULL;\n \n+\t/* release all the existing VSIs and VEBs */\n+\ti40e_fdir_teardown(pf);\n+\ti40e_vsi_release(pf->main_vsi);\n+\n \t/* shutdown the adminq */\n \ti40e_aq_queue_shutdown(hw, true);\n \ti40e_shutdown_adminq(hw);\n@@ -4374,6 +4373,9 @@ i40e_vsi_release(struct i40e_vsi *vsi)\n \tif (!vsi)\n \t\treturn I40E_SUCCESS;\n \n+\tif (!vsi->adapter)\n+\t\treturn -EFAULT;\n+\n \tuser_param = vsi->user_param;\n \n \tpf = I40E_VSI_TO_PF(vsi);\n", "prefixes": [ "dpdk-dev", "v5", "1/3" ] }