Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 19994,
    "url": "http://patches.dpdk.org/api/patches/19994/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1485343758-179761-1-git-send-email-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1485343758-179761-1-git-send-email-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1485343758-179761-1-git-send-email-pablo.de.lara.guarch@intel.com",
    "date": "2017-01-25T11:29:18",
    "name": "[dpdk-dev] app/test: fix overflow in EFD test",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f87dc7755e7cbfdc600bcdb2fea6510afd9c6765",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1485343758-179761-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/19994/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/19994/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E59911E2B;\n\tWed, 25 Jan 2017 12:27:44 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 1B53FB6D\n\tfor <dev@dpdk.org>; Wed, 25 Jan 2017 12:27:41 +0100 (CET)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP; 25 Jan 2017 03:27:40 -0800",
            "from silpixa00381631.ir.intel.com (HELO\n\tsilpixa00381631.ger.corp.intel.com) ([10.237.222.122])\n\tby orsmga004.jf.intel.com with ESMTP; 25 Jan 2017 03:27:39 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.33,283,1477983600\"; d=\"scan'208\";a=\"52267397\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "byron.marohn@intel.com",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Wed, 25 Jan 2017 11:29:18 +0000",
        "Message-Id": "<1485343758-179761-1-git-send-email-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] app/test: fix overflow in EFD test",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When RTE_EFD_VALUE_NUM_BITS is 32, there was a compilation issue\nbecause of an overflow:\n\napp/test/test_efd.c:157:55: error: overflow in expression;\nresult is 2147483647 with type 'int' [-Werror,-Winteger-overflow]\n        data[0] = mrand48() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);\n\nThis commit fixes the issue by using a setting a different\nmacro VALUE_BITMASK with a conditional\n\nFixes: 0e925aef2779 (\"app/test: add EFD functional and perf tests\")\n\nReported-by: Yong Liu <yong.liu@intel.com>\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test/test_efd.c      | 12 +++++++++---\n app/test/test_efd_perf.c |  9 ++++++++-\n 2 files changed, 17 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/app/test/test_efd.c b/app/test/test_efd.c\nindex d5c3bd9..de49e1d 100644\n--- a/app/test/test_efd.c\n+++ b/app/test/test_efd.c\n@@ -44,6 +44,12 @@\n #define EFD_TEST_KEY_LEN 8\n #define TABLE_SIZE (1 << 21)\n #define ITERATIONS 3\n+\n+#if RTE_EFD_VALUE_NUM_BITS == 32\n+#define VALUE_BITMASK 0xffffffff\n+#else\n+#define VALUE_BITMASK ((1 << RTE_EFD_VALUE_NUM_BITS) - 1)\n+#endif\n static unsigned int test_socket_id;\n \n /* 5-tuple key type */\n@@ -154,7 +160,7 @@ static int test_add_delete(void)\n \t\t\tefd_get_all_sockets_bitmask(), test_socket_id);\n \tTEST_ASSERT_NOT_NULL(handle, \"Error creating the EFD table\\n\");\n \n-\tdata[0] = mrand48() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);\n+\tdata[0] = mrand48() & VALUE_BITMASK;\n \tTEST_ASSERT_SUCCESS(rte_efd_update(handle, test_socket_id, &keys[0],\n \t\t\tdata[0]),\n \t\t\t\"Error inserting the key\");\n@@ -191,7 +197,7 @@ static int test_add_update_delete(void)\n \tprintf(\"Entering %s\\n\", __func__);\n \t/* test with standard add/lookup/delete functions */\n \tefd_value_t prev_value;\n-\tdata[1] = mrand48() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);\n+\tdata[1] = mrand48() & VALUE_BITMASK;\n \n \thandle = rte_efd_create(\"test_add_update_delete\", TABLE_SIZE,\n \t\t\tsizeof(struct flow_key),\n@@ -285,7 +291,7 @@ static int test_five_keys(void)\n \n \t/* Setup data */\n \tfor (i = 0; i < 5; i++)\n-\t\tdata[i] = mrand48() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);\n+\t\tdata[i] = mrand48() & VALUE_BITMASK;\n \n \t/* Add */\n \tfor (i = 0; i < 5; i++) {\ndiff --git a/app/test/test_efd_perf.c b/app/test/test_efd_perf.c\nindex 998a25b..2b8a8ea 100644\n--- a/app/test/test_efd_perf.c\n+++ b/app/test/test_efd_perf.c\n@@ -43,12 +43,19 @@\n #include <rte_thash.h>\n \n #include \"test.h\"\n+\n #define NUM_KEYSIZES 10\n #define NUM_SHUFFLES 10\n #define MAX_KEYSIZE 64\n #define MAX_ENTRIES (1 << 19)\n #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */\n #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */\n+\n+#if RTE_EFD_VALUE_NUM_BITS == 32\n+#define VALUE_BITMASK 0xffffffff\n+#else\n+#define VALUE_BITMASK ((1 << RTE_EFD_VALUE_NUM_BITS) - 1)\n+#endif\n static unsigned int test_socket_id;\n \n static inline uint8_t efd_get_all_sockets_bitmask(void)\n@@ -154,7 +161,7 @@ setup_keys_and_data(struct efd_perf_params *params, unsigned int cycle)\n \t\tfor (j = 0; j < params->key_size; j++)\n \t\t\tkeys[i][j] = rte_rand() & 0xFF;\n \n-\t\tdata[i] = rte_rand() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);\n+\t\tdata[i] = rte_rand() & VALUE_BITMASK;\n \t}\n \n \t/* Remove duplicates from the keys array */\n",
    "prefixes": [
        "dpdk-dev"
    ]
}