Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 19982,
    "url": "http://patches.dpdk.org/api/patches/19982/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170124203603.3887-1-emmanuel.roullit@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170124203603.3887-1-emmanuel.roullit@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170124203603.3887-1-emmanuel.roullit@gmail.com",
    "date": "2017-01-24T20:36:03",
    "name": "[dpdk-dev] net/virtio: do not gso when no header is present",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c9bf07e4091522d2b9a78bccfa7d04b381fcce95",
    "submitter": {
        "id": 647,
        "url": "http://patches.dpdk.org/api/people/647/?format=api",
        "name": "Emmanuel Roullit",
        "email": "emmanuel.roullit@gmail.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170124203603.3887-1-emmanuel.roullit@gmail.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/19982/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/19982/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 83BEB1023;\n\tTue, 24 Jan 2017 21:36:15 +0100 (CET)",
            "from mail-wj0-f195.google.com (mail-wj0-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id A4254201\n\tfor <dev@dpdk.org>; Tue, 24 Jan 2017 21:36:13 +0100 (CET)",
            "by mail-wj0-f195.google.com with SMTP id i7so3219358wjf.2\n\tfor <dev@dpdk.org>; Tue, 24 Jan 2017 12:36:13 -0800 (PST)",
            "from emmanuel-Aspire-E5-571.primacom.net ([185.44.151.141])\n\tby smtp.gmail.com with ESMTPSA id\n\tz134sm27930449wmc.20.2017.01.24.12.36.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 24 Jan 2017 12:36:12 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=a9QRjJtMJWitj1idCyHQr8ly/ZOsTxe6j16Wr5z6Fpk=;\n\tb=GpX6i9ay/1TvjNLiHDGn/9HzsPnJZ26p/IWsHuKOXpZ8P7KzVoq3nogfZN0n4tsXJH\n\t0b0BuLLPpyaH77wKQMPd/0S7tSQGRi7wC41WnNLXO2hrIv6a9ZRfurXSaGRFi7wPDpkp\n\tU08TxfmuZyOF8V/Kj1PpZqUjRPu7HvTzUwltN3L6BnrutoXQGCIzrOcIKwZ1f0rh8oW4\n\tB3Hns09GX9VtPTtSj1CBCa36Xd7M2cIZdMclI+0z0u+k2iktQFMW2qICnkHbmQq/nsPy\n\tTUDiaGMA4Ml3+EC86mIosJo9GYVaFdH1syf2olOAA1vJVwSlwR/Qr/y2QYdBgjfPqOgl\n\tRWGA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=a9QRjJtMJWitj1idCyHQr8ly/ZOsTxe6j16Wr5z6Fpk=;\n\tb=h5s5DyycCeZggd8usYiQaP8q/9FC74xG3dRvHej475ArUwFFe1o4PyNZy5hUC8iDk8\n\tWdaZMxctcyyIkMRazr3syCNVZ2Qhf40LOj3kei079mKXviMRVzSymCK6dGEYf9Z9gXH+\n\thbU38we6mt/XFIuQVhThx7qKYW3r5ojeOv/RYSvLDts6gqElzqppkjFxsWGQfjb4ibfC\n\toxhf5rIEJuGDC3RG9jBi/m6T0GZv4nFjneE/OBV85tsY9dcIDRMaRZs9mCQ43Q93c9P8\n\tFSO5ISPPnSBrg/H3DEHhmlfsZDBC60qC93cfOatqRBGrZnKAVUgAdRVYgxgFf5226+GL\n\tkWuw==",
        "X-Gm-Message-State": "AIkVDXJU3pKA9Iw1adnKpDqPWZDL/vDyU1hZbLqoWZO8tWmTkj6Kj43NIaWZaIcvMQ58sQ==",
        "X-Received": "by 10.223.170.221 with SMTP id\n\ti29mr37046549wrc.131.1485290173381; \n\tTue, 24 Jan 2017 12:36:13 -0800 (PST)",
        "From": "Emmanuel Roullit <emmanuel.roullit@gmail.com>",
        "To": "huawei.xie@intel.com,\n\tyuanhan.liu@linux.intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Tue, 24 Jan 2017 21:36:03 +0100",
        "Message-Id": "<20170124203603.3887-1-emmanuel.roullit@gmail.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: do not gso when no header is present",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Found with clang static analysis:\nlib/librte_vhost/virtio_net.c:723:17: warning:\nAccess to field 'data_off' results in a dereference of a null pointer\n(loaded from variable 'tcp_hdr')\n        m->l4_len = (tcp_hdr->data_off & 0xf0) >> 2;\n                     ^~~~~~~~~~~~~~~~~\n\nFixes: 2a51b1091cb5 (\"vhost: support indirect descriptor in non-mergeable Rx\")\n\nSigned-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>\n---\n lib/librte_vhost/virtio_net.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 595f67c4d..82444b7b9 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -677,6 +677,7 @@ parse_ethernet(struct rte_mbuf *m, uint16_t *l4_proto, void **l4_hdr)\n \tdefault:\n \t\tm->l3_len = 0;\n \t\t*l4_proto = 0;\n+\t\t*l4_hdr = NULL;\n \t\tbreak;\n \t}\n }\n@@ -713,7 +714,7 @@ vhost_dequeue_offload(struct virtio_net_hdr *hdr, struct rte_mbuf *m)\n \t\t}\n \t}\n \n-\tif (hdr->gso_type != VIRTIO_NET_HDR_GSO_NONE) {\n+\tif (l4_hdr && hdr->gso_type != VIRTIO_NET_HDR_GSO_NONE) {\n \t\tswitch (hdr->gso_type & ~VIRTIO_NET_HDR_GSO_ECN) {\n \t\tcase VIRTIO_NET_HDR_GSO_TCPV4:\n \t\tcase VIRTIO_NET_HDR_GSO_TCPV6:\n",
    "prefixes": [
        "dpdk-dev"
    ]
}