Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/18604/?format=api
{ "id": 18604, "url": "http://patches.dpdk.org/api/patches/18604/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/ca7ba8260f3ef956e253ea338b17e3e9dc9df01a.1482920437.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<ca7ba8260f3ef956e253ea338b17e3e9dc9df01a.1482920437.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ca7ba8260f3ef956e253ea338b17e3e9dc9df01a.1482920437.git.nelio.laranjeiro@6wind.com", "date": "2016-12-28T10:37:14", "name": "[dpdk-dev,v4,1/6] net/mlx5: add preliminary flow API support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13eabccde546733a2ea2b236229b61dc32206f20", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/ca7ba8260f3ef956e253ea338b17e3e9dc9df01a.1482920437.git.nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/18604/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/18604/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4A5695588;\n\tWed, 28 Dec 2016 11:38:05 +0100 (CET)", "from mail-wj0-f170.google.com (mail-wj0-f170.google.com\n\t[209.85.210.170]) by dpdk.org (Postfix) with ESMTP id AC5F820F\n\tfor <dev@dpdk.org>; Wed, 28 Dec 2016 11:37:36 +0100 (CET)", "by mail-wj0-f170.google.com with SMTP id c11so129405134wjx.3\n\tfor <dev@dpdk.org>; Wed, 28 Dec 2016 02:37:36 -0800 (PST)", "from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tkq6sm30022703wjc.7.2016.12.28.02.37.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 28 Dec 2016 02:37:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=2mQoqyVg01jEyxTOG1+iuQkSYw/nXIVfYMZH+ugu8uc=;\n\tb=H8qTu4/0OpnC0ts88YLc18UjX5ViwlSWIieyDhSIYpGubu9lkKuCiQbkbDs1VuhAnq\n\t9L1pJfUkWdCqd5yl2s0ZxNxuyjcm3B0i/zGrwKZ5vibvjzqoYtWvKXbysx20n0a1jRVo\n\tTtU6yTD2CbKWLLxmH7nOpv791etHmhGVGQAqh+OIlKmufHFpXRk38/Pha5JjbHMPiykZ\n\tjA0wBcIqi87od/3seY7eBAvKmjz2rt8jdbYM0w6gV1XEmJPZuHXIZfNPD0Jf11sblVbn\n\t9Dh1qCZ15L2WMJiBO6ZN0UPl7flJkMvHkrRjacXLZH2rmLm1LQoq+5vC6e1dZAcIh6Ie\n\tLdRg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=2mQoqyVg01jEyxTOG1+iuQkSYw/nXIVfYMZH+ugu8uc=;\n\tb=FSasgf1b/jKD1EDPtF7yETi6Oco9/+U/T2e//j5XMvz1OIaELyOD/l/YSVnYQITCfd\n\tdmanrh6Rxu4GOzoyrXMegc92TYYkjE1eWV89cRwRMzda3WM3jPEwq0GPhosh3ecmrM1F\n\tDzGC+VcDOUQoCeN0OYlKNMmvR+/oNUAsYkiR6LW3tTUwmEbpdD21V1jtwfSkwA80nboy\n\tB65Rxw3sIRhdG5Q64kHKU91lF4Chejblh0xcUrqa8ooI53AX9p0eG4a5b7Gct2BH2/BA\n\t3RP2KZBXfo4tFioIVVsZsLwQeqDAw0a5nrzfMdrr/1IvXyNebVP7uhqZosCfQUy2zWvX\n\trujA==", "X-Gm-Message-State": "AIkVDXK+XiW9iYVIEnrub+e6vIoPhR1chC3r9a9diWyNdR2iYgbpD/auKt2mO3bhU2/46ifo", "X-Received": "by 10.194.58.7 with SMTP id m7mr19261792wjq.73.1482921456336;\n\tWed, 28 Dec 2016 02:37:36 -0800 (PST)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 28 Dec 2016 11:37:14 +0100", "Message-Id": "<ca7ba8260f3ef956e253ea338b17e3e9dc9df01a.1482920437.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1482920437.git.nelio.laranjeiro@6wind.com>", "<cover.1482920437.git.nelio.laranjeiro@6wind.com>" ], "References": [ "<cover.1482920437.git.nelio.laranjeiro@6wind.com>", "<cover.1482331954.git.nelio.laranjeiro@6wind.com>\n\t<cover.1482920437.git.nelio.laranjeiro@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v4 1/6] net/mlx5: add preliminary flow API support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/Makefile | 1 +\n drivers/net/mlx5/mlx5.h | 16 ++++++\n drivers/net/mlx5/mlx5_fdir.c | 15 ++++++\n drivers/net/mlx5/mlx5_flow.c | 124 +++++++++++++++++++++++++++++++++++++++++++\n 4 files changed, 156 insertions(+)\n create mode 100644 drivers/net/mlx5/mlx5_flow.c", "diff": "diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile\nindex cf87f0b..6d1338a 100644\n--- a/drivers/net/mlx5/Makefile\n+++ b/drivers/net/mlx5/Makefile\n@@ -48,6 +48,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_stats.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_rss.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_fdir.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_mr.c\n+SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_flow.c\n \n # Dependencies.\n DEPDIRS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += lib/librte_ether\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 79b7a60..04f4eaa 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -59,6 +59,7 @@\n #include <rte_spinlock.h>\n #include <rte_interrupts.h>\n #include <rte_errno.h>\n+#include <rte_flow.h>\n #ifdef PEDANTIC\n #pragma GCC diagnostic error \"-Wpedantic\"\n #endif\n@@ -268,4 +269,19 @@ void priv_fdir_enable(struct priv *);\n int mlx5_dev_filter_ctrl(struct rte_eth_dev *, enum rte_filter_type,\n \t\t\t enum rte_filter_op, void *);\n \n+/* mlx5_flow.c */\n+\n+int mlx5_flow_validate(struct rte_eth_dev *, const struct rte_flow_attr *,\n+\t\t const struct rte_flow_item [],\n+\t\t const struct rte_flow_action [],\n+\t\t struct rte_flow_error *);\n+struct rte_flow *mlx5_flow_create(struct rte_eth_dev *,\n+\t\t\t\t const struct rte_flow_attr *,\n+\t\t\t\t const struct rte_flow_item [],\n+\t\t\t\t const struct rte_flow_action [],\n+\t\t\t\t struct rte_flow_error *);\n+int mlx5_flow_destroy(struct rte_eth_dev *, struct rte_flow *,\n+\t\t struct rte_flow_error *);\n+int mlx5_flow_flush(struct rte_eth_dev *, struct rte_flow_error *);\n+\n #endif /* RTE_PMD_MLX5_H_ */\ndiff --git a/drivers/net/mlx5/mlx5_fdir.c b/drivers/net/mlx5/mlx5_fdir.c\nindex 1acf682..f80c58b 100644\n--- a/drivers/net/mlx5/mlx5_fdir.c\n+++ b/drivers/net/mlx5/mlx5_fdir.c\n@@ -55,6 +55,8 @@\n #include <rte_malloc.h>\n #include <rte_ethdev.h>\n #include <rte_common.h>\n+#include <rte_flow.h>\n+#include <rte_flow_driver.h>\n #ifdef PEDANTIC\n #pragma GCC diagnostic error \"-Wpedantic\"\n #endif\n@@ -1042,6 +1044,14 @@ priv_fdir_ctrl_func(struct priv *priv, enum rte_filter_op filter_op, void *arg)\n \treturn ret;\n }\n \n+static const struct rte_flow_ops mlx5_flow_ops = {\n+\t.validate = mlx5_flow_validate,\n+\t.create = mlx5_flow_create,\n+\t.destroy = mlx5_flow_destroy,\n+\t.flush = mlx5_flow_flush,\n+\t.query = NULL,\n+};\n+\n /**\n * Manage filter operations.\n *\n@@ -1067,6 +1077,11 @@ mlx5_dev_filter_ctrl(struct rte_eth_dev *dev,\n \tstruct priv *priv = dev->data->dev_private;\n \n \tswitch (filter_type) {\n+\tcase RTE_ETH_FILTER_GENERIC:\n+\t\tif (filter_op != RTE_ETH_FILTER_GET)\n+\t\t\treturn -EINVAL;\n+\t\t*(const void **)arg = &mlx5_flow_ops;\n+\t\treturn 0;\n \tcase RTE_ETH_FILTER_FDIR:\n \t\tpriv_lock(priv);\n \t\tret = priv_fdir_ctrl_func(priv, filter_op, arg);\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nnew file mode 100644\nindex 0000000..4fdefa0\n--- /dev/null\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -0,0 +1,124 @@\n+/*-\n+ * BSD LICENSE\n+ *\n+ * Copyright 2016 6WIND S.A.\n+ * Copyright 2016 Mellanox.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions\n+ * are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ * * Redistributions in binary form must reproduce the above copyright\n+ * notice, this list of conditions and the following disclaimer in\n+ * the documentation and/or other materials provided with the\n+ * distribution.\n+ * * Neither the name of 6WIND S.A. nor the names of its\n+ * contributors may be used to endorse or promote products derived\n+ * from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include <rte_ethdev.h>\n+#include <rte_flow.h>\n+#include <rte_flow_driver.h>\n+\n+#include \"mlx5.h\"\n+\n+/**\n+ * Validate a flow supported by the NIC.\n+ *\n+ * @see rte_flow_validate()\n+ * @see rte_flow_ops\n+ */\n+int\n+mlx5_flow_validate(struct rte_eth_dev *dev,\n+\t\t const struct rte_flow_attr *attr,\n+\t\t const struct rte_flow_item items[],\n+\t\t const struct rte_flow_action actions[],\n+\t\t struct rte_flow_error *error)\n+{\n+\t(void)dev;\n+\t(void)attr;\n+\t(void)items;\n+\t(void)actions;\n+\t(void)error;\n+\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t NULL, \"not implemented yet\");\n+\treturn -rte_errno;\n+}\n+\n+/**\n+ * Create a flow.\n+ *\n+ * @see rte_flow_create()\n+ * @see rte_flow_ops\n+ */\n+struct rte_flow *\n+mlx5_flow_create(struct rte_eth_dev *dev,\n+\t\t const struct rte_flow_attr *attr,\n+\t\t const struct rte_flow_item items[],\n+\t\t const struct rte_flow_action actions[],\n+\t\t struct rte_flow_error *error)\n+{\n+\t(void)dev;\n+\t(void)attr;\n+\t(void)items;\n+\t(void)actions;\n+\t(void)error;\n+\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t NULL, \"not implemented yet\");\n+\treturn NULL;\n+}\n+\n+/**\n+ * Destroy a flow.\n+ *\n+ * @see rte_flow_destroy()\n+ * @see rte_flow_ops\n+ */\n+int\n+mlx5_flow_destroy(struct rte_eth_dev *dev,\n+\t\t struct rte_flow *flow,\n+\t\t struct rte_flow_error *error)\n+{\n+\t(void)dev;\n+\t(void)flow;\n+\t(void)error;\n+\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t NULL, \"not implemented yet\");\n+\treturn -rte_errno;\n+}\n+\n+/**\n+ * Destroy all flows.\n+ *\n+ * @see rte_flow_flush()\n+ * @see rte_flow_ops\n+ */\n+int\n+mlx5_flow_flush(struct rte_eth_dev *dev,\n+\t\tstruct rte_flow_error *error)\n+{\n+\t(void)dev;\n+\t(void)error;\n+\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t NULL, \"not implemented yet\");\n+\treturn -rte_errno;\n+}\n", "prefixes": [ "dpdk-dev", "v4", "1/6" ] }