Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 18312,
    "url": "http://patches.dpdk.org/api/patches/18312/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1482308980-76777-1-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1482308980-76777-1-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1482308980-76777-1-git-send-email-wenzhuo.lu@intel.com",
    "date": "2016-12-21T08:29:40",
    "name": "[dpdk-dev] net/i40e: fix wrong return value when handling PF message",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2e372d7049ce8a24dba20736eb522c46e8848ccb",
    "submitter": {
        "id": 258,
        "url": "http://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1482308980-76777-1-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/18312/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/18312/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 20C6810B8A;\n\tWed, 21 Dec 2016 09:29:51 +0100 (CET)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 22A16FC27\n\tfor <dev@dpdk.org>; Wed, 21 Dec 2016 09:29:48 +0100 (CET)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga103.fm.intel.com with ESMTP; 21 Dec 2016 00:29:47 -0800",
            "from dpdk26.sh.intel.com ([10.239.128.228])\n\tby orsmga004.jf.intel.com with ESMTP; 21 Dec 2016 00:29:46 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.33,382,1477983600\"; d=\"scan'208\";a=\"42091919\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "Date": "Wed, 21 Dec 2016 16:29:40 +0800",
        "Message-Id": "<1482308980-76777-1-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "Subject": "[dpdk-dev] [PATCH] net/i40e: fix wrong return value when handling\n\tPF message",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When VF receives a message from PF, it should check the return\nvalue. But in i40evf_execute_vf_cmd the value is ignored and not\nreturned to the caller.\n\nFixes: 95cd21f45d1b (\"i40evf: allocate virtchnl commands buffer per VF\")\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.h    | 2 +-\n drivers/net/i40e/i40e_ethdev_vf.c | 1 +\n 2 files changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h\nindex 298cef4..28111a7 100644\n--- a/drivers/net/i40e/i40e_ethdev.h\n+++ b/drivers/net/i40e/i40e_ethdev.h\n@@ -527,7 +527,7 @@ struct i40e_vf {\n \tenum i40e_aq_link_speed link_speed;\n \tbool vf_reset;\n \tvolatile uint32_t pend_cmd; /* pending command not finished yet */\n-\tuint32_t cmd_retval; /* return value of the cmd response from PF */\n+\tint32_t cmd_retval; /* return value of the cmd response from PF */\n \tu16 pend_msg; /* flags indicates events from pf not handled yet */\n \tuint8_t *aq_resp; /* buffer to store the adminq response from PF */\n \ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 12da0ec..5d25764 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -361,6 +361,7 @@ struct rte_i40evf_xstats_name_off {\n \t\terr = -1;\n \t\tdo {\n \t\t\tret = i40evf_read_pfmsg(dev, &info);\n+\t\t\tvf->cmd_retval = info.result;\n \t\t\tif (ret == I40EVF_MSG_CMD) {\n \t\t\t\terr = 0;\n \t\t\t\tbreak;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}