Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17312/?format=api
{ "id": 17312, "url": "http://patches.dpdk.org/api/patches/17312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1480436367-20749-41-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1480436367-20749-41-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1480436367-20749-41-git-send-email-arybchenko@solarflare.com", "date": "2016-11-29T16:19:12", "name": "[dpdk-dev,v2,40/55] net/sfc: periodic management EVQ polling using alarm", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "38f2ad58c67a6e56088e6ec2cc3f66dc5a3fc380", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1480436367-20749-41-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17312/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17312/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 61594FA98;\n\tTue, 29 Nov 2016 17:22:31 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 50C79475D\n\tfor <dev@dpdk.org>; Tue, 29 Nov 2016 17:20:53 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo01.seg.att.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\t5eaad385.2b3e98666940.83585.00-2495.173910.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tTue, 29 Nov 2016 16:20:53 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t2eaad385.0.83424.00-2358.173855.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tTue, 29 Nov 2016 16:20:51 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Tue, 29 Nov 2016 08:20:26 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Tue, 29 Nov 2016 08:20:25 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuATGKOWE030020; Tue, 29 Nov 2016 16:20:24 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuATGKM1m021233; Tue, 29 Nov 2016 16:20:24 GMT" ], "X-MXL-Hash": [ "583daae54516bbed-fdc243b745cdda082412f2ce9b7e66393b2fb91e", "583daae3367de582-cbc3431ac1181417a8739330d5065e56c3179998" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Tue, 29 Nov 2016 16:19:12 +0000", "Message-ID": "<1480436367-20749-41-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1480436367-20749-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>\n\t<1480436367-20749-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UoJlQrEB c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=9Zmx-CB1EvL28Kt1B]", "[EsA:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH v2 40/55] net/sfc: periodic management EVQ\n\tpolling using alarm", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Timers cannot be used to implement periodic polling, since it implies\nrequirement on application to process timers in the main loop.\n\nReviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ev.c | 42 ++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 42 insertions(+)", "diff": "diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c\nindex a6a1ee2..179c4f8 100644\n--- a/drivers/net/sfc/sfc_ev.c\n+++ b/drivers/net/sfc/sfc_ev.c\n@@ -29,6 +29,7 @@\n \n #include <rte_debug.h>\n #include <rte_cycles.h>\n+#include <rte_alarm.h>\n \n #include \"efx.h\"\n \n@@ -45,6 +46,9 @@\n /* Event queue init approx timeout */\n #define SFC_EVQ_INIT_TIMEOUT_US\t\t(2 * US_PER_S)\n \n+/* Management event queue polling period in microseconds */\n+#define SFC_MGMT_EV_QPOLL_PERIOD_US\t(US_PER_S)\n+\n \n static boolean_t\n sfc_ev_initialized(void *arg)\n@@ -328,6 +332,34 @@ sfc_ev_qstop(struct sfc_adapter *sa, unsigned int sw_index)\n \tefx_ev_qdestroy(evq->common);\n }\n \n+static void\n+sfc_ev_mgmt_periodic_qpoll(void *arg)\n+{\n+\tstruct sfc_adapter *sa = arg;\n+\tint rc;\n+\n+\tsfc_ev_mgmt_qpoll(sa);\n+\n+\trc = rte_eal_alarm_set(SFC_MGMT_EV_QPOLL_PERIOD_US,\n+\t\t\t sfc_ev_mgmt_periodic_qpoll, sa);\n+\tif (rc != 0)\n+\t\tsfc_panic(sa,\n+\t\t\t \"cannot rearm management EVQ polling alarm (rc=%d)\",\n+\t\t\t rc);\n+}\n+\n+static void\n+sfc_ev_mgmt_periodic_qpoll_start(struct sfc_adapter *sa)\n+{\n+\tsfc_ev_mgmt_periodic_qpoll(sa);\n+}\n+\n+static void\n+sfc_ev_mgmt_periodic_qpoll_stop(struct sfc_adapter *sa)\n+{\n+\trte_eal_alarm_cancel(sfc_ev_mgmt_periodic_qpoll, sa);\n+}\n+\n int\n sfc_ev_start(struct sfc_adapter *sa)\n {\n@@ -349,6 +381,14 @@ sfc_ev_start(struct sfc_adapter *sa)\n \trte_spinlock_unlock(&sa->mgmt_evq_lock);\n \n \t/*\n+\t * Start management EVQ polling. If interrupts are disabled\n+\t * (not used), it is required to process link status change\n+\t * and other device level events to avoid unrecoverable\n+\t * error because the event queue overflow.\n+\t */\n+\tsfc_ev_mgmt_periodic_qpoll_start(sa);\n+\n+\t/*\n \t * Rx/Tx event queues are started/stopped when corresponding\n \t * Rx/Tx queue is started/stopped.\n \t */\n@@ -371,6 +411,8 @@ sfc_ev_stop(struct sfc_adapter *sa)\n \n \tsfc_log_init(sa, \"entry\");\n \n+\tsfc_ev_mgmt_periodic_qpoll_stop(sa);\n+\n \t/* Make sure that all event queues are stopped */\n \tsw_index = sa->evq_count;\n \twhile (sw_index-- > 0) {\n", "prefixes": [ "dpdk-dev", "v2", "40/55" ] }