Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17292/?format=api
http://patches.dpdk.org/api/patches/17292/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1480436367-20749-33-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1480436367-20749-33-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1480436367-20749-33-git-send-email-arybchenko@solarflare.com", "date": "2016-11-29T16:19:04", "name": "[dpdk-dev,v2,32/55] net/sfc: add device configure and close stubs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4869e368e178326cc070f85f0fe053eb04fe2c97", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1480436367-20749-33-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17292/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17292/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CD86FFA39;\n\tTue, 29 Nov 2016 17:21:49 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 21BE53989\n\tfor <dev@dpdk.org>; Tue, 29 Nov 2016 17:20:49 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo01.seg.att.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\t1eaad385.2b3e5a803940.83545.00-2486.173805.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tTue, 29 Nov 2016 16:20:49 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t6daad385.0.83400.00-2384.173640.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tTue, 29 Nov 2016 16:20:39 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Tue, 29 Nov 2016 08:20:25 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Tue, 29 Nov 2016 08:20:25 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuATGKODI029990; Tue, 29 Nov 2016 16:20:24 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuATGKM1e021233; Tue, 29 Nov 2016 16:20:24 GMT" ], "X-MXL-Hash": [ "583daae17eeb59d7-ea41d261c7656b866c503d69aa1b7a8751994720", "583daad7410bf66e-e1f5d0d29ed835fca35ea649704a7b3778440ef6" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Tue, 29 Nov 2016 16:19:04 +0000", "Message-ID": "<1480436367-20749-33-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1480436367-20749-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>\n\t<1480436367-20749-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UoJlQrEB c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=XtyHadxMRhaiTuztb]", "[ykA:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.4975883530; CM=0.500; S=0.497(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH v2 32/55] net/sfc: add device configure and close\n\tstubs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc.c | 29 ++++++++++++++++++++++\n drivers/net/sfc/sfc.h | 29 ++++++++++++++++++----\n drivers/net/sfc/sfc_ethdev.c | 58 ++++++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 111 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c\nindex 2a17d26..cbb14d7 100644\n--- a/drivers/net/sfc/sfc.c\n+++ b/drivers/net/sfc/sfc.c\n@@ -82,6 +82,35 @@ sfc_dma_free(const struct sfc_adapter *sa, efsys_mem_t *esmp)\n \tmemset(esmp, 0, sizeof(*esmp));\n }\n \n+int\n+sfc_configure(struct sfc_adapter *sa)\n+{\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n+\n+\tSFC_ASSERT(sa->state == SFC_ADAPTER_INITIALIZED);\n+\tsa->state = SFC_ADAPTER_CONFIGURING;\n+\n+\tsa->state = SFC_ADAPTER_CONFIGURED;\n+\tsfc_log_init(sa, \"done\");\n+\treturn 0;\n+}\n+\n+void\n+sfc_close(struct sfc_adapter *sa)\n+{\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n+\n+\tSFC_ASSERT(sa->state == SFC_ADAPTER_CONFIGURED);\n+\tsa->state = SFC_ADAPTER_CLOSING;\n+\n+\tsa->state = SFC_ADAPTER_INITIALIZED;\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n static int\n sfc_mem_bar_init(struct sfc_adapter *sa)\n {\ndiff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex b9a0b0b..c664fb6 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -50,11 +50,28 @@ extern \"C\" {\n *\tV\t\t\t|\n * +---------------+------------+\n * | INITIALIZED |\n+ * +---------------+<-----------+\n+ *\t|.dev_configure\t\t|\n+ *\tV\t\t\t|\n+ * +---------------+\t\t|\n+ * | CONFIGURING |------------^\n+ * +---------------+ failed\t|\n+ *\t|success\t\t|\n+ *\t|\t\t+---------------+\n+ *\t|\t\t| CLOSING |\n+ *\t|\t\t+---------------+\n+ *\t|\t\t\t^\n+ *\tV\t\t\t|.dev_close\n+ * +---------------+------------+\n+ * | CONFIGURED |\n * +---------------+\n */\n enum sfc_adapter_state {\n \tSFC_ADAPTER_UNINITIALIZED = 0,\n \tSFC_ADAPTER_INITIALIZED,\n+\tSFC_ADAPTER_CONFIGURING,\n+\tSFC_ADAPTER_CONFIGURED,\n+\tSFC_ADAPTER_CLOSING,\n \n \tSFC_ADAPTER_NSTATES\n };\n@@ -78,11 +95,10 @@ struct sfc_mcdi {\n /* Adapter private data */\n struct sfc_adapter {\n \t/*\n-\t * PMD setup and configuration is not thread safe.\n-\t * Since it is not performance sensitive, it is better to guarantee\n-\t * thread-safety and add device level lock.\n-\t * Adapter control operations which change its state should\n-\t * acquire the lock.\n+\t * PMD setup and configuration is not thread safe. Since it is not\n+\t * performance sensitive, it is better to guarantee thread-safety\n+\t * and add device level lock. Adapter control operations which\n+\t * change its state should acquire the lock.\n \t */\n \trte_spinlock_t\t\t\tlock;\n \tenum sfc_adapter_state\t\tstate;\n@@ -146,6 +162,9 @@ void sfc_detach(struct sfc_adapter *sa);\n int sfc_mcdi_init(struct sfc_adapter *sa);\n void sfc_mcdi_fini(struct sfc_adapter *sa);\n \n+int sfc_configure(struct sfc_adapter *sa);\n+void sfc_close(struct sfc_adapter *sa);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 381f90c..ca46b7d 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -49,7 +49,65 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tsfc_log_init(sa, \"entry\");\n }\n \n+static int\n+sfc_dev_configure(struct rte_eth_dev *dev)\n+{\n+\tstruct rte_eth_dev_data *dev_data = dev->data;\n+\tstruct sfc_adapter *sa = dev_data->dev_private;\n+\tint rc;\n+\n+\tsfc_log_init(sa, \"entry n_rxq=%u n_txq=%u\",\n+\t\t dev_data->nb_rx_queues, dev_data->nb_tx_queues);\n+\n+\tsfc_adapter_lock(sa);\n+\tswitch (sa->state) {\n+\tcase SFC_ADAPTER_CONFIGURED:\n+\t\tsfc_close(sa);\n+\t\tSFC_ASSERT(sa->state == SFC_ADAPTER_INITIALIZED);\n+\t\t/* FALLTHROUGH */\n+\tcase SFC_ADAPTER_INITIALIZED:\n+\t\trc = sfc_configure(sa);\n+\t\tbreak;\n+\tdefault:\n+\t\tsfc_err(sa, \"unexpected adapter state %u to configure\",\n+\t\t\tsa->state);\n+\t\trc = EINVAL;\n+\t\tbreak;\n+\t}\n+\tsfc_adapter_unlock(sa);\n+\n+\tsfc_log_init(sa, \"done %d\", rc);\n+\tSFC_ASSERT(rc >= 0);\n+\treturn -rc;\n+}\n+\n+static void\n+sfc_dev_close(struct rte_eth_dev *dev)\n+{\n+\tstruct sfc_adapter *sa = dev->data->dev_private;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tsfc_adapter_lock(sa);\n+\tswitch (sa->state) {\n+\tcase SFC_ADAPTER_CONFIGURED:\n+\t\tsfc_close(sa);\n+\t\tSFC_ASSERT(sa->state == SFC_ADAPTER_INITIALIZED);\n+\t\t/* FALLTHROUGH */\n+\tcase SFC_ADAPTER_INITIALIZED:\n+\t\tbreak;\n+\tdefault:\n+\t\tsfc_err(sa, \"unexpected adapter state %u on close\", sa->state);\n+\t\tbreak;\n+\t}\n+\tsfc_adapter_unlock(sa);\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n static const struct eth_dev_ops sfc_eth_dev_ops = {\n+\t.dev_configure\t\t\t= sfc_dev_configure,\n+\t.dev_close\t\t\t= sfc_dev_close,\n \t.dev_infos_get\t\t\t= sfc_dev_infos_get,\n };\n \n", "prefixes": [ "dpdk-dev", "v2", "32/55" ] }{ "id": 17292, "url": "