Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17205/?format=api
{ "id": 17205, "url": "http://patches.dpdk.org/api/patches/17205/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479931644-78960-5-git-send-email-benjamin.walker@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479931644-78960-5-git-send-email-benjamin.walker@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479931644-78960-5-git-send-email-benjamin.walker@intel.com", "date": "2016-11-23T20:07:22", "name": "[dpdk-dev,v2,5/7] pci: Move driver registration above pci scan", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "63449791e62b4027cffbac48accad8e94b7ace03", "submitter": { "id": 487, "url": "http://patches.dpdk.org/api/people/487/?format=api", "name": "Walker, Benjamin", "email": "benjamin.walker@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479931644-78960-5-git-send-email-benjamin.walker@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17205/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17205/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CCAE358D6;\n\tWed, 23 Nov 2016 21:08:02 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 78BB85678\n\tfor <dev@dpdk.org>; Wed, 23 Nov 2016 21:07:34 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 23 Nov 2016 12:07:32 -0800", "from bwalker-desk.ch.intel.com ([143.182.137.60])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Nov 2016 12:07:32 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,539,1473145200\"; d=\"scan'208\";a=\"8589971\"", "From": "Ben Walker <benjamin.walker@intel.com>", "To": "dev@dpdk.org", "Cc": "Ben Walker <benjamin.walker@intel.com>", "Date": "Wed, 23 Nov 2016 13:07:22 -0700", "Message-Id": "<1479931644-78960-5-git-send-email-benjamin.walker@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>", "References": "<1479929804-19614-1-git-send-email-benjamin.walker@intel.com>\n\t<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 5/7] pci: Move driver registration above pci\n\tscan", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The user needs to register drivers before scanning, so\nit makes the most sense to put the registration\nfunctions above the scan function in the header file.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n lib/librte_eal/common/include/rte_pci.h | 56 ++++++++++++++++-----------------\n 1 file changed, 28 insertions(+), 28 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h\nindex 74be1f5..5d0feac 100644\n--- a/lib/librte_eal/common/include/rte_pci.h\n+++ b/lib/librte_eal/common/include/rte_pci.h\n@@ -358,6 +358,34 @@ rte_eal_compare_pci_addr(const struct rte_pci_addr *addr,\n }\n \n /**\n+ * Register a PCI driver.\n+ *\n+ * @param driver\n+ * A pointer to a rte_pci_driver structure describing the driver\n+ * to be registered.\n+ */\n+void rte_eal_pci_register(struct rte_pci_driver *driver);\n+\n+/** Statically register a PCI driver at start up */\n+#define RTE_PMD_REGISTER_PCI(nm, pci_drv) \\\n+RTE_INIT(pciinitfn_ ##nm); \\\n+static void pciinitfn_ ##nm(void) \\\n+{\\\n+\t(pci_drv).driver.name = RTE_STR(nm);\\\n+\trte_eal_pci_register(&pci_drv); \\\n+} \\\n+RTE_PMD_EXPORT_NAME(nm, __COUNTER__)\n+\n+/**\n+ * Unregister a PCI driver.\n+ *\n+ * @param driver\n+ * A pointer to a rte_pci_driver structure describing the driver\n+ * to be unregistered.\n+ */\n+void rte_eal_pci_unregister(struct rte_pci_driver *driver);\n+\n+/**\n * Scan the content of the PCI bus, and the devices in the devices\n * list\n *\n@@ -476,34 +504,6 @@ int rte_eal_pci_detach(const struct rte_pci_addr *addr);\n void rte_eal_pci_dump(FILE *f);\n \n /**\n- * Register a PCI driver.\n- *\n- * @param driver\n- * A pointer to a rte_pci_driver structure describing the driver\n- * to be registered.\n- */\n-void rte_eal_pci_register(struct rte_pci_driver *driver);\n-\n-/** Helper for PCI device registration from driver (eth, crypto) instance */\n-#define RTE_PMD_REGISTER_PCI(nm, pci_drv) \\\n-RTE_INIT(pciinitfn_ ##nm); \\\n-static void pciinitfn_ ##nm(void) \\\n-{\\\n-\t(pci_drv).driver.name = RTE_STR(nm);\\\n-\trte_eal_pci_register(&pci_drv); \\\n-} \\\n-RTE_PMD_EXPORT_NAME(nm, __COUNTER__)\n-\n-/**\n- * Unregister a PCI driver.\n- *\n- * @param driver\n- * A pointer to a rte_pci_driver structure describing the driver\n- * to be unregistered.\n- */\n-void rte_eal_pci_unregister(struct rte_pci_driver *driver);\n-\n-/**\n * Read PCI config space.\n *\n * @param device\n", "prefixes": [ "dpdk-dev", "v2", "5/7" ] }