Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17139/?format=api
{ "id": 17139, "url": "http://patches.dpdk.org/api/patches/17139/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-46-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479740470-6723-46-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-46-git-send-email-arybchenko@solarflare.com", "date": "2016-11-21T15:00:59", "name": "[dpdk-dev,45/56] net/sfc: check configured rxmode", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "13cbd68670317e35e3603255d37af64be96640e7", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-46-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17139/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 03854D5AA;\n\tMon, 21 Nov 2016 16:03:28 +0100 (CET)", "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 08E822A5D\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:39 +0100 (CET)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t35c03385.0.1541303.00-2341.3424236.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:40 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:22 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:22 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1L1n007233 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:21 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J3a006765 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:21 GMT" ], "X-MXL-Hash": "58330c546a39b481-4a2b6c2b1250e512207e67e667923bc7e6747970", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Mon, 21 Nov 2016 15:00:59 +0000", "Message-ID": "<1479740470-6723-46-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=hETAKOhrBMnxUfG-4]", "[UcA:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 45/56] net/sfc: check configured rxmode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/sfc_efx.rst | 12 +++++++++\n drivers/net/sfc/efx/sfc_rx.c | 61 ++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 73 insertions(+)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 46c892b..87b217f8 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -60,6 +60,18 @@ The features not yet supported include:\n \n - Loopback\n \n+- Configurable RX CRC stripping (always stripped)\n+\n+- Header split on receive\n+\n+- VLAN filtering\n+\n+- VLAN stripping\n+\n+- Scattered receive\n+\n+- LRO\n+\n \n Supported NICs\n --------------\ndiff --git a/drivers/net/sfc/efx/sfc_rx.c b/drivers/net/sfc/efx/sfc_rx.c\nindex 961e6b6..bc43e4e 100644\n--- a/drivers/net/sfc/efx/sfc_rx.c\n+++ b/drivers/net/sfc/efx/sfc_rx.c\n@@ -48,6 +48,61 @@ sfc_rx_qinit_info(struct sfc_adapter *sa, unsigned int sw_index)\n \treturn 0;\n }\n \n+static int\n+sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)\n+{\n+\tint rc = 0;\n+\n+\tswitch (rxmode->mq_mode) {\n+\tcase ETH_MQ_RX_NONE:\n+\t\t/* No special checks are required */\n+\t\tbreak;\n+\tdefault:\n+\t\tsfc_err(sa, \"Rx multi-queue mode %u not supported\",\n+\t\t\trxmode->mq_mode);\n+\t\trc = EINVAL;\n+\t}\n+\n+\tif (rxmode->header_split) {\n+\t\tsfc_err(sa, \"Header split on Rx not supported\");\n+\t\trc = EINVAL;\n+\t}\n+\n+\tif (rxmode->hw_vlan_filter) {\n+\t\tsfc_err(sa, \"HW VLAN filtering not supported\");\n+\t\trc = EINVAL;\n+\t}\n+\n+\tif (rxmode->hw_vlan_strip) {\n+\t\tsfc_err(sa, \"HW VLAN stripping not supported\");\n+\t\trc = EINVAL;\n+\t}\n+\n+\tif (rxmode->hw_vlan_extend) {\n+\t\tsfc_err(sa,\n+\t\t\t\"Q-in-Q HW VLAN stripping not supported\");\n+\t\trc = EINVAL;\n+\t}\n+\n+\tif (!rxmode->hw_strip_crc) {\n+\t\tsfc_warn(sa,\n+\t\t\t \"FCS stripping control not supported - always stripped\");\n+\t\trxmode->hw_strip_crc = 1;\n+\t}\n+\n+\tif (rxmode->enable_scatter) {\n+\t\tsfc_err(sa, \"Scatter on Rx not supported\");\n+\t\trc = EINVAL;\n+\t}\n+\n+\tif (rxmode->enable_lro) {\n+\t\tsfc_err(sa, \"LRO not supported\");\n+\t\trc = EINVAL;\n+\t}\n+\n+\treturn rc;\n+}\n+\n /**\n * Initialize Rx subsystem.\n *\n@@ -59,9 +114,14 @@ sfc_rx_qinit_info(struct sfc_adapter *sa, unsigned int sw_index)\n int\n sfc_rx_init(struct sfc_adapter *sa)\n {\n+\tstruct rte_eth_conf *dev_conf = &sa->eth_dev->data->dev_conf;\n \tunsigned int sw_index;\n \tint rc;\n \n+\trc = sfc_rx_check_mode(sa, &dev_conf->rxmode);\n+\tif (rc != 0)\n+\t\tgoto fail_check_mode;\n+\n \tsa->rxq_count = sa->eth_dev->data->nb_rx_queues;\n \n \trc = ENOMEM;\n@@ -85,6 +145,7 @@ sfc_rx_init(struct sfc_adapter *sa)\n \n fail_rxqs_alloc:\n \tsa->rxq_count = 0;\n+fail_check_mode:\n \tsfc_log_init(sa, \"failed %d\", rc);\n \treturn rc;\n }\n", "prefixes": [ "dpdk-dev", "45/56" ] }