Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17131/?format=api
{ "id": 17131, "url": "http://patches.dpdk.org/api/patches/17131/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-36-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479740470-6723-36-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-36-git-send-email-arybchenko@solarflare.com", "date": "2016-11-21T15:00:49", "name": "[dpdk-dev,35/56] net/sfc: implement device start and stop operations", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9cf7751ebf6d95ed04b0f610235663b8e952602a", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-36-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17131/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5183AD56A;\n\tMon, 21 Nov 2016 16:03:19 +0100 (CET)", "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 1C39A54AF\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:37 +0100 (CET)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t05c03385.0.1541303.00-2309.3424224.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:37 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:22 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:21 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1K6P007203 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J3Q006765 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT" ], "X-MXL-Hash": "58330c51735a3461-a5415dadc8f5b163f400c3956a6dd44fd75e8de0", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Mon, 21 Nov 2016 15:00:49 +0000", "Message-ID": "<1479740470-6723-36-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=ost_VK3OpwOC5PQxD]", "[04A:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 35/56] net/sfc: implement device start and stop\n\toperations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/efx/sfc.c | 65 ++++++++++++++++++++++++++++++++++++++++\n drivers/net/sfc/efx/sfc.h | 19 ++++++++++++\n drivers/net/sfc/efx/sfc_ethdev.c | 37 +++++++++++++++++++++++\n 3 files changed, 121 insertions(+)", "diff": "diff --git a/drivers/net/sfc/efx/sfc.c b/drivers/net/sfc/efx/sfc.c\nindex befe68d..8c780ac 100644\n--- a/drivers/net/sfc/efx/sfc.c\n+++ b/drivers/net/sfc/efx/sfc.c\n@@ -127,6 +127,71 @@ sfc_check_conf(struct sfc_adapter *sa)\n }\n \n int\n+sfc_start(struct sfc_adapter *sa)\n+{\n+\tint rc;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n+\n+\tswitch (sa->state) {\n+\tcase SFC_ADAPTER_CONFIGURED:\n+\t\tbreak;\n+\tcase SFC_ADAPTER_STARTED:\n+\t\tsfc_info(sa, \"already started\");\n+\t\treturn 0;\n+\tdefault:\n+\t\trc = EINVAL;\n+\t\tgoto fail_bad_state;\n+\t}\n+\n+\tsa->state = SFC_ADAPTER_STARTING;\n+\n+\tsfc_log_init(sa, \"init nic\");\n+\trc = efx_nic_init(sa->nic);\n+\tif (rc != 0)\n+\t\tgoto fail_nic_init;\n+\n+\tsa->state = SFC_ADAPTER_STARTED;\n+\tsfc_log_init(sa, \"done\");\n+\treturn 0;\n+\n+fail_nic_init:\n+\tsa->state = SFC_ADAPTER_CONFIGURED;\n+fail_bad_state:\n+\tsfc_log_init(sa, \"failed %d\", rc);\n+\treturn rc;\n+}\n+\n+void\n+sfc_stop(struct sfc_adapter *sa)\n+{\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n+\n+\tswitch (sa->state) {\n+\tcase SFC_ADAPTER_STARTED:\n+\t\tbreak;\n+\tcase SFC_ADAPTER_CONFIGURED:\n+\t\tsfc_info(sa, \"already stopped\");\n+\t\treturn;\n+\tdefault:\n+\t\tsfc_err(sa, \"stop in unexpected state %u\", sa->state);\n+\t\tSFC_ASSERT(B_FALSE);\n+\t\treturn;\n+\t}\n+\n+\tsa->state = SFC_ADAPTER_STOPPING;\n+\n+\tefx_nic_fini(sa->nic);\n+\n+\tsa->state = SFC_ADAPTER_CONFIGURED;\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n+int\n sfc_configure(struct sfc_adapter *sa)\n {\n \tint rc;\ndiff --git a/drivers/net/sfc/efx/sfc.h b/drivers/net/sfc/efx/sfc.h\nindex d040f98..42d6898 100644\n--- a/drivers/net/sfc/efx/sfc.h\n+++ b/drivers/net/sfc/efx/sfc.h\n@@ -64,6 +64,20 @@ extern \"C\" {\n *\tV\t\t\t|.dev_close\n * +---------------+------------+\n * | CONFIGURED |\n+ * +---------------+<-----------+\n+ *\t|.dev_start\t\t|\n+ *\tV\t\t\t|\n+ * +---------------+\t\t|\n+ * | STARTING |------------^\n+ * +---------------+ failed\t|\n+ *\t|success\t\t|\n+ *\t|\t\t+---------------+\n+ *\t|\t\t| STOPPING |\n+ *\t|\t\t+---------------+\n+ *\t|\t\t\t^\n+ *\tV\t\t\t|.dev_stop\n+ * +---------------+------------+\n+ * | STARTED |\n * +---------------+\n */\n enum sfc_adapter_state {\n@@ -72,6 +86,9 @@ enum sfc_adapter_state {\n \tSFC_ADAPTER_CONFIGURING,\n \tSFC_ADAPTER_CONFIGURED,\n \tSFC_ADAPTER_CLOSING,\n+\tSFC_ADAPTER_STARTING,\n+\tSFC_ADAPTER_STARTED,\n+\tSFC_ADAPTER_STOPPING,\n \n \tSFC_ADAPTER_NSTATES\n };\n@@ -158,6 +175,8 @@ void sfc_dma_free(const struct sfc_adapter *sa, efsys_mem_t *esmp);\n \n int sfc_attach(struct sfc_adapter *sa);\n void sfc_detach(struct sfc_adapter *sa);\n+int sfc_start(struct sfc_adapter *sa);\n+void sfc_stop(struct sfc_adapter *sa);\n \n int sfc_mcdi_init(struct sfc_adapter *sa);\n void sfc_mcdi_fini(struct sfc_adapter *sa);\ndiff --git a/drivers/net/sfc/efx/sfc_ethdev.c b/drivers/net/sfc/efx/sfc_ethdev.c\nindex 120ee45..ba99516 100644\n--- a/drivers/net/sfc/efx/sfc_ethdev.c\n+++ b/drivers/net/sfc/efx/sfc_ethdev.c\n@@ -79,6 +79,37 @@ sfc_dev_configure(struct rte_eth_dev *dev)\n \treturn -rc;\n }\n \n+static int\n+sfc_dev_start(struct rte_eth_dev *dev)\n+{\n+\tstruct sfc_adapter *sa = dev->data->dev_private;\n+\tint rc;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tsfc_adapter_lock(sa);\n+\trc = sfc_start(sa);\n+\tsfc_adapter_unlock(sa);\n+\n+\tsfc_log_init(sa, \"done %d\", rc);\n+\tSFC_ASSERT(rc >= 0);\n+\treturn -rc;\n+}\n+\n+static void\n+sfc_dev_stop(struct rte_eth_dev *dev)\n+{\n+\tstruct sfc_adapter *sa = dev->data->dev_private;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tsfc_adapter_lock(sa);\n+\tsfc_stop(sa);\n+\tsfc_adapter_unlock(sa);\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n static void\n sfc_dev_close(struct rte_eth_dev *dev)\n {\n@@ -88,6 +119,10 @@ sfc_dev_close(struct rte_eth_dev *dev)\n \n \tsfc_adapter_lock(sa);\n \tswitch (sa->state) {\n+\tcase SFC_ADAPTER_STARTED:\n+\t\tsfc_stop(sa);\n+\t\tSFC_ASSERT(sa->state == SFC_ADAPTER_CONFIGURED);\n+\t\t/* FALLTHROUGH */\n \tcase SFC_ADAPTER_CONFIGURED:\n \t\tsfc_close(sa);\n \t\tSFC_ASSERT(sa->state == SFC_ADAPTER_INITIALIZED);\n@@ -105,6 +140,8 @@ sfc_dev_close(struct rte_eth_dev *dev)\n \n static const struct eth_dev_ops sfc_eth_dev_ops = {\n \t.dev_configure\t\t\t= sfc_dev_configure,\n+\t.dev_start\t\t\t= sfc_dev_start,\n+\t.dev_stop\t\t\t= sfc_dev_stop,\n \t.dev_close\t\t\t= sfc_dev_close,\n \t.dev_infos_get\t\t\t= sfc_dev_infos_get,\n };\n", "prefixes": [ "dpdk-dev", "35/56" ] }