Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17116/?format=api
{ "id": 17116, "url": "http://patches.dpdk.org/api/patches/17116/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-20-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479740470-6723-20-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-20-git-send-email-arybchenko@solarflare.com", "date": "2016-11-21T15:00:33", "name": "[dpdk-dev,19/56] net/sfc: import libefx event prefetch support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "91054e588ee0c82aab0d9d31e895fe4e64fb45ea", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-20-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17116/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/17116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AE5F0D49C;\n\tMon, 21 Nov 2016 16:02:47 +0100 (CET)", "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 34AEB376D\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:31 +0100 (CET)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\ta4c03385.0.1541294.00-2318.3424195.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:31 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:21 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:21 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1K7q007155 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J3A006765 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT" ], "X-MXL-Hash": "58330c4b2f34d20b-2b4ec818faae16a1a0f7b1663666f05cb96b514a", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Mon, 21 Nov 2016 15:00:33 +0000", "Message-ID": "<1479740470-6723-20-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=QMutcHdeXo-d2NIhc]", "[V8A:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.5191359115; CM=0.500; S=0.519(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 19/56] net/sfc: import libefx event prefetch\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "EFSYS_OPT_EV_PREFECT allows to enable event prefetching\nwhen event queue is polled.\n\nFrom Solarflare Communications Inc.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/efx/base/efx.h | 9 +++++++++\n drivers/net/sfc/efx/base/efx_check.h | 7 +++++++\n drivers/net/sfc/efx/base/efx_ev.c | 38 ++++++++++++++++++++++++++++++++++++\n 3 files changed, 54 insertions(+)", "diff": "diff --git a/drivers/net/sfc/efx/base/efx.h b/drivers/net/sfc/efx/base/efx.h\nindex c06c9b6..24b7c8d 100644\n--- a/drivers/net/sfc/efx/base/efx.h\n+++ b/drivers/net/sfc/efx/base/efx.h\n@@ -1317,6 +1317,15 @@ efx_ev_qpending(\n \t__in\t\tefx_evq_t *eep,\n \t__in\t\tunsigned int count);\n \n+#if EFSYS_OPT_EV_PREFETCH\n+\n+extern\t\t\tvoid\n+efx_ev_qprefetch(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tunsigned int count);\n+\n+#endif\t/* EFSYS_OPT_EV_PREFETCH */\n+\n extern\t\t\tvoid\n efx_ev_qpoll(\n \t__in\t\tefx_evq_t *eep,\ndiff --git a/drivers/net/sfc/efx/base/efx_check.h b/drivers/net/sfc/efx/base/efx_check.h\nindex 5956052..df46410 100644\n--- a/drivers/net/sfc/efx/base/efx_check.h\n+++ b/drivers/net/sfc/efx/base/efx_check.h\n@@ -66,6 +66,13 @@\n # endif\n #endif /* EFSYS_OPT_DIAG */\n \n+#if EFSYS_OPT_EV_PREFETCH\n+/* Support optimized EVQ data access */\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n+# error \"EV_PREFETCH requires SIENA or HUNTINGTON or MEDFORD\"\n+# endif\n+#endif /* EFSYS_OPT_EV_PREFETCH */\n+\n #ifdef EFSYS_OPT_FALCON_NIC_CFG_OVERRIDE\n # error \"FALCON_NIC_CFG_OVERRIDE is obsolete and is not supported.\"\n #endif\ndiff --git a/drivers/net/sfc/efx/base/efx_ev.c b/drivers/net/sfc/efx/base/efx_ev.c\nindex 74d146e..c172a06 100644\n--- a/drivers/net/sfc/efx/base/efx_ev.c\n+++ b/drivers/net/sfc/efx/base/efx_ev.c\n@@ -351,6 +351,23 @@ efx_ev_qpending(\n \treturn (EFX_EV_PRESENT(qword));\n }\n \n+#if EFSYS_OPT_EV_PREFETCH\n+\n+\t\t\tvoid\n+efx_ev_qprefetch(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tunsigned int count)\n+{\n+\tunsigned int offset;\n+\n+\tEFSYS_ASSERT3U(eep->ee_magic, ==, EFX_EVQ_MAGIC);\n+\n+\toffset = (count & eep->ee_mask) * sizeof (efx_qword_t);\n+\tEFSYS_MEM_PREFETCH(eep->ee_esmp, offset);\n+}\n+\n+#endif\t/* EFSYS_OPT_EV_PREFETCH */\n+\n #define\tEFX_EV_BATCH\t8\n \n \t\t\tvoid\n@@ -403,11 +420,32 @@ efx_ev_qpoll(\n \t\t\toffset += sizeof (efx_qword_t);\n \t\t}\n \n+#if EFSYS_OPT_EV_PREFETCH && (EFSYS_OPT_EV_PREFETCH_PERIOD > 1)\n+\t\t/*\n+\t\t * Prefetch the next batch when we get within PREFETCH_PERIOD\n+\t\t * of a completed batch. If the batch is smaller, then prefetch\n+\t\t * immediately.\n+\t\t */\n+\t\tif (total == batch && total < EFSYS_OPT_EV_PREFETCH_PERIOD)\n+\t\t\tEFSYS_MEM_PREFETCH(eep->ee_esmp, offset);\n+#endif\t/* EFSYS_OPT_EV_PREFETCH */\n+\n \t\t/* Process the batch of events */\n \t\tfor (index = 0; index < total; ++index) {\n \t\t\tboolean_t should_abort;\n \t\t\tuint32_t code;\n \n+#if EFSYS_OPT_EV_PREFETCH\n+\t\t\t/* Prefetch if we've now reached the batch period */\n+\t\t\tif (total == batch &&\n+\t\t\t index + EFSYS_OPT_EV_PREFETCH_PERIOD == total) {\n+\t\t\t\toffset = (count + batch) & eep->ee_mask;\n+\t\t\t\toffset *= sizeof (efx_qword_t);\n+\n+\t\t\t\tEFSYS_MEM_PREFETCH(eep->ee_esmp, offset);\n+\t\t\t}\n+#endif\t/* EFSYS_OPT_EV_PREFETCH */\n+\n \t\t\tEFX_EV_QSTAT_INCR(eep, EV_ALL);\n \n \t\t\tcode = EFX_QWORD_FIELD(ev[index], FSF_AZ_EV_CODE);\n", "prefixes": [ "dpdk-dev", "19/56" ] }