Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17106/?format=api
{ "id": 17106, "url": "http://patches.dpdk.org/api/patches/17106/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-8-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479740470-6723-8-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-8-git-send-email-arybchenko@solarflare.com", "date": "2016-11-21T15:00:21", "name": "[dpdk-dev,07/56] net/sfc: import libefx MCDI logging support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "284a095589cc87b5fbd1ee0818c08d4065d29cbc", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479740470-6723-8-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17106/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17106/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D1AC53977;\n\tMon, 21 Nov 2016 16:01:56 +0100 (CET)", "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 679E92A5D\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:25 +0100 (CET)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t44c03385.0.1541294.00-2367.3424166.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:25 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:21 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:20 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1JTZ007119 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:19 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J2w006765 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:19 GMT" ], "X-MXL-Hash": "58330c452be4fe5d-4f202e8e6d8864e37193a6e7d162e292f2bcb8d6", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Mon, 21 Nov 2016 15:00:21 +0000", "Message-ID": "<1479740470-6723-8-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=NNL8zR0JFEXHgSg_x]", "[NgA:9 a=gcKDgMwcFbuDw3qs:21 a=DToHueWCNdl3kUu1:21 a=PA03WX]", "[8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.3555707642; CM=0.500; S=0.355(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 07/56] net/sfc: import libefx MCDI logging support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Driver can provide a function to be called to log MCDI\nrequests and responses to help with debugging.\n\nSolarflare netlogdecode cross-platform tool may be used\nto decode these logs.\n\nEFSYS_OPT_MCDI_LOGGING should be enabled to use it.\n\nFrom Solarflare Communications Inc.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/efx/base/efx.h | 12 ++++++++++++\n drivers/net/sfc/efx/base/efx_check.h | 7 +++++++\n drivers/net/sfc/efx/base/efx_mcdi.c | 34 ++++++++++++++++++++++++++++++++++\n 3 files changed, 53 insertions(+)", "diff": "diff --git a/drivers/net/sfc/efx/base/efx.h b/drivers/net/sfc/efx/base/efx.h\nindex 8b9d4d1..0ca0156 100644\n--- a/drivers/net/sfc/efx/base/efx.h\n+++ b/drivers/net/sfc/efx/base/efx.h\n@@ -191,12 +191,24 @@ typedef enum efx_mcdi_exception_e {\n \tEFX_MCDI_EXCEPTION_MC_BADASSERT,\n } efx_mcdi_exception_t;\n \n+#if EFSYS_OPT_MCDI_LOGGING\n+typedef enum efx_log_msg_e {\n+\tEFX_LOG_INVALID,\n+\tEFX_LOG_MCDI_REQUEST,\n+\tEFX_LOG_MCDI_RESPONSE,\n+} efx_log_msg_t;\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n+\n typedef struct efx_mcdi_transport_s {\n \tvoid\t\t*emt_context;\n \tefsys_mem_t\t*emt_dma_mem;\n \tvoid\t\t(*emt_execute)(void *, efx_mcdi_req_t *);\n \tvoid\t\t(*emt_ev_cpl)(void *);\n \tvoid\t\t(*emt_exception)(void *, efx_mcdi_exception_t);\n+#if EFSYS_OPT_MCDI_LOGGING\n+\tvoid\t\t(*emt_logger)(void *, efx_log_msg_t,\n+\t\t\t\t\tvoid *, size_t, void *, size_t);\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n } efx_mcdi_transport_t;\n \n extern\t__checkReturn\tefx_rc_t\ndiff --git a/drivers/net/sfc/efx/base/efx_check.h b/drivers/net/sfc/efx/base/efx_check.h\nindex 9d0e988..228b42c 100644\n--- a/drivers/net/sfc/efx/base/efx_check.h\n+++ b/drivers/net/sfc/efx/base/efx_check.h\n@@ -77,6 +77,13 @@\n # error \"MCDI requires SIENA or HUNTINGTON or MEDFORD\"\n #endif /* EFSYS_OPT_MCDI */\n \n+#if EFSYS_OPT_MCDI_LOGGING\n+/* Support MCDI logging */\n+# if !EFSYS_OPT_MCDI\n+# error \"MCDI_LOGGING requires MCDI\"\n+# endif\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n+\n #ifdef EFSYS_OPT_MON_LM87\n # error \"MON_LM87 is obsolete and is not supported.\"\n #endif\ndiff --git a/drivers/net/sfc/efx/base/efx_mcdi.c b/drivers/net/sfc/efx/base/efx_mcdi.c\nindex 643ba6a..59a16fc 100644\n--- a/drivers/net/sfc/efx/base/efx_mcdi.c\n+++ b/drivers/net/sfc/efx/base/efx_mcdi.c\n@@ -192,6 +192,9 @@ efx_mcdi_request_start(\n \t__in\t\tefx_mcdi_req_t *emrp,\n \t__in\t\tboolean_t ev_cpl)\n {\n+#if EFSYS_OPT_MCDI_LOGGING\n+\tconst efx_mcdi_transport_t *emtp = enp->en_mcdi.em_emtp;\n+#endif\n \tefx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);\n \tefx_dword_t hdr[2];\n \tsize_t hdr_len;\n@@ -268,6 +271,14 @@ efx_mcdi_request_start(\n \t\t MCDI_HEADER_XFLAGS, xflags);\n \t}\n \n+#if EFSYS_OPT_MCDI_LOGGING\n+\tif (emtp->emt_logger != NULL) {\n+\t\temtp->emt_logger(emtp->emt_context, EFX_LOG_MCDI_REQUEST,\n+\t\t &hdr[0], hdr_len,\n+\t\t emrp->emr_in_buf, emrp->emr_in_length);\n+\t}\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n+\n \tefx_mcdi_send_request(enp, &hdr[0], hdr_len,\n \t emrp->emr_in_buf, emrp->emr_in_length);\n }\n@@ -278,6 +289,9 @@ efx_mcdi_read_response_header(\n \t__in\t\tefx_nic_t *enp,\n \t__inout\t\tefx_mcdi_req_t *emrp)\n {\n+#if EFSYS_OPT_MCDI_LOGGING\n+\tconst efx_mcdi_transport_t *emtp = enp->en_mcdi.em_emtp;\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n \tefx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);\n \tefx_dword_t hdr[2];\n \tunsigned int hdr_len;\n@@ -338,6 +352,15 @@ efx_mcdi_read_response_header(\n \t\temrp->emr_err_code = err_code;\n \t\temrp->emr_err_arg = err_arg;\n \n+#if EFSYS_OPT_MCDI_LOGGING\n+\t\tif (emtp->emt_logger != NULL) {\n+\t\t\temtp->emt_logger(emtp->emt_context,\n+\t\t\t EFX_LOG_MCDI_RESPONSE,\n+\t\t\t &hdr[0], hdr_len,\n+\t\t\t &err[0], err_len);\n+\t\t}\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n+\n \t\tif (!emrp->emr_quiet) {\n \t\t\tEFSYS_PROBE3(mcdi_err_arg, int, emrp->emr_cmd,\n \t\t\t int, err_code, int, err_arg);\n@@ -363,6 +386,9 @@ efx_mcdi_finish_response(\n \t__in\t\tefx_nic_t *enp,\n \t__in\t\tefx_mcdi_req_t *emrp)\n {\n+#if EFSYS_OPT_MCDI_LOGGING\n+\tconst efx_mcdi_transport_t *emtp = enp->en_mcdi.em_emtp;\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n \tefx_dword_t hdr[2];\n \tunsigned int hdr_len;\n \tsize_t bytes;\n@@ -389,6 +415,14 @@ efx_mcdi_finish_response(\n \tbytes = MIN(emrp->emr_out_length_used, emrp->emr_out_length);\n \tefx_mcdi_read_response(enp, emrp->emr_out_buf, hdr_len, bytes);\n \n+#if EFSYS_OPT_MCDI_LOGGING\n+\tif (emtp->emt_logger != NULL) {\n+\t\temtp->emt_logger(emtp->emt_context,\n+\t\t EFX_LOG_MCDI_RESPONSE,\n+\t\t &hdr[0], hdr_len,\n+\t\t emrp->emr_out_buf, bytes);\n+\t}\n+#endif /* EFSYS_OPT_MCDI_LOGGING */\n }\n \n \n", "prefixes": [ "dpdk-dev", "07/56" ] }