Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17063,
    "url": "http://patches.dpdk.org/api/patches/17063/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479375779-46629-3-git-send-email-qiming.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479375779-46629-3-git-send-email-qiming.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479375779-46629-3-git-send-email-qiming.yang@intel.com",
    "date": "2016-11-17T09:42:53",
    "name": "[dpdk-dev] ethtool: dispaly bus info and firmware version",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "903c7d53975e1c115d54691e59ab6fb2e760517f",
    "submitter": {
        "id": 522,
        "url": "http://patches.dpdk.org/api/people/522/?format=api",
        "name": "Qiming Yang",
        "email": "qiming.yang@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479375779-46629-3-git-send-email-qiming.yang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/17063/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/17063/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1DC2D58C5;\n\tThu, 17 Nov 2016 10:47:30 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id E98645688\n\tfor <dev@dpdk.org>; Thu, 17 Nov 2016 10:46:52 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 17 Nov 2016 01:46:51 -0800",
            "from unknown (HELO dpdk7.bj.intel.com) ([172.16.182.76])\n\tby orsmga001.jf.intel.com with ESMTP; 17 Nov 2016 01:46:48 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.31,653,1473145200\"; d=\"scan'208\";\n\ta=\"1060591461\"",
        "From": "Qiming Yang <qiming.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "remy.horton@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com,\n\tQiming Yang <qiming.yang@intel.com>",
        "Date": "Thu, 17 Nov 2016 17:42:53 +0800",
        "Message-Id": "<1479375779-46629-3-git-send-email-qiming.yang@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1479375779-46629-1-git-send-email-qiming.yang@intel.com>",
        "References": "<1479375779-46629-1-git-send-email-qiming.yang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH] ethtool: dispaly bus info and firmware version",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch enhances the ethtool-API to support to show the\nbus information and firmware version as same as kernel\nversion ethtool displayed.\n\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n examples/ethtool/ethtool-app/ethapp.c | 2 ++\n examples/ethtool/lib/rte_ethtool.c    | 3 +++\n 2 files changed, 5 insertions(+)",
    "diff": "diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c\nindex 38e466c..9b77385 100644\n--- a/examples/ethtool/ethtool-app/ethapp.c\n+++ b/examples/ethtool/ethtool-app/ethapp.c\n@@ -184,6 +184,8 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params,\n \t\tprintf(\"Port %i driver: %s (ver: %s)\\n\",\n \t\t\tid_port, info.driver, info.version\n \t\t      );\n+\t\tprintf(\"bus-info: %s\\n\", info.bus_info);\n+\t\tprintf(\"firmware-version: %s\\n\", info.fw_version);\n \t}\n }\n \ndiff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c\nindex a1f91d4..542179c 100644\n--- a/examples/ethtool/lib/rte_ethtool.c\n+++ b/examples/ethtool/lib/rte_ethtool.c\n@@ -54,6 +54,9 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo)\n \n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \n+\trte_eth_dev_fwver_get(port_id, drvinfo->fw_version,\n+\t\t\t      sizeof(drvinfo->fw_version));\n+\n \tmemset(&dev_info, 0, sizeof(dev_info));\n \trte_eth_dev_info_get(port_id, &dev_info);\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}