Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 167,
    "url": "http://patches.dpdk.org/api/patches/167/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1408353973-16663-7-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1408353973-16663-7-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1408353973-16663-7-git-send-email-david.marchand@6wind.com",
    "date": "2014-08-18T09:26:12",
    "name": "[dpdk-dev,6/7] app/test: no more builtin commands",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6a32ded26ca269cdbf58db5900dd1af7137831a9",
    "submitter": {
        "id": 3,
        "url": "http://patches.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1408353973-16663-7-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/167/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/167/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<david.marchand@6wind.com>",
        "Received": [
            "from mail-we0-f174.google.com (mail-we0-f174.google.com\n\t[74.125.82.174]) by dpdk.org (Postfix) with ESMTP id D7863B376\n\tfor <dev@dpdk.org>; Mon, 18 Aug 2014 11:23:09 +0200 (CEST)",
            "by mail-we0-f174.google.com with SMTP id x48so4744557wes.19\n\tfor <dev@dpdk.org>; Mon, 18 Aug 2014 02:26:32 -0700 (PDT)",
            "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tza9sm25087627wjc.29.2014.08.18.02.26.30 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Aug 2014 02:26:31 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=/S67NW7rmx2Nj2iTrgQ57ishT/lWvruaGRjvmoQiqqU=;\n\tb=Z0ocKZA51xejACxO6PGvI5qP3wkfu4/ILmOyW7Phmy/wJyKQvwC+9rSL0k09g1gYKC\n\tZp3KCB/FnGKj1CpWdFC5OU9uQzQG1R33A/tUUCR+QXAp2ZCTbqyAh1nLlgzEigk776XQ\n\tZJRw221g7OG/6YZTvBnE3tXJNprOXhH3x6hWwYWUksyl42b2lT0l/fdgTiySuHykVdWv\n\tgU0RZ68240V7YpRGtRdFTZsd5r9jrTQ4h/OjssTcLA5hGmrUGpuBmjtu5pgALcn1a4BI\n\t+CJ0zKo+mCTSxJAu0ml6dyIzEHSAguxwOBKb4FDK4+EnUOsg9dqCWhWGMBICd5/wHqPy\n\tq1iA==",
        "X-Gm-Message-State": "ALoCoQmvufvUbHBz2gXiwwQHl2oz6DxpogIrVf5aE+qEJ2ZtCrGcsngW70ghURUzVBAnrtfLJjl0",
        "X-Received": "by 10.180.81.169 with SMTP id b9mr39589841wiy.10.1408353992252; \n\tMon, 18 Aug 2014 02:26:32 -0700 (PDT)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 18 Aug 2014 11:26:12 +0200",
        "Message-Id": "<1408353973-16663-7-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 1.7.10.4",
        "In-Reply-To": "<1408353973-16663-1-git-send-email-david.marchand@6wind.com>",
        "References": "<1408353973-16663-1-git-send-email-david.marchand@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 6/7] app/test: no more builtin commands",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-List-Received-Date": "Mon, 18 Aug 2014 09:23:10 -0000"
    },
    "content": "The builtin commands list is now empty, we can remove it.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n app/test/commands.c |    6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/app/test/commands.c b/app/test/commands.c\nindex 0640ac9..b7c6ee0 100644\n--- a/app/test/commands.c\n+++ b/app/test/commands.c\n@@ -324,9 +324,8 @@ cmdline_parse_ctx_t main_ctx[] = {\n int commands_init(void)\n {\n \tstruct test_command *t;\n-\tchar builtin_commands[] = \"\";\n \tchar *commands, *ptr;\n-\tint commands_len = strlen(builtin_commands) + 1;\n+\tint commands_len = 0;\n \n \tTAILQ_FOREACH(t, &commands_list, next) {\n \t\tcommands_len += strlen(t->command) + 1;\n@@ -340,7 +339,8 @@ int commands_init(void)\n \tTAILQ_FOREACH(t, &commands_list, next) {\n \t\tptr += sprintf(ptr, \"%s#\", t->command);\n \t}\n-\tptr += sprintf(ptr, \"%s\", builtin_commands);\n+\tptr--;\n+\tptr[0] = '\\0';\n \n \tcmd_autotest_autotest.string_data.str = commands;\n \treturn 0;\n",
    "prefixes": [
        "dpdk-dev",
        "6/7"
    ]
}