Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/162/?format=api
{ "id": 162, "url": "http://patches.dpdk.org/api/patches/162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1408353973-16663-2-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1408353973-16663-2-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1408353973-16663-2-git-send-email-david.marchand@6wind.com", "date": "2014-08-18T09:26:07", "name": "[dpdk-dev,1/7] app: simplify makefiles", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8998de72d6fe50ff22179e8940bab80867eb5349", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1408353973-16663-2-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/162/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/162/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<david.marchand@6wind.com>", "Received": [ "from mail-wi0-f177.google.com (mail-wi0-f177.google.com\n\t[209.85.212.177]) by dpdk.org (Postfix) with ESMTP id C0741B363\n\tfor <dev@dpdk.org>; Mon, 18 Aug 2014 11:23:02 +0200 (CEST)", "by mail-wi0-f177.google.com with SMTP id ho1so3333058wib.4\n\tfor <dev@dpdk.org>; Mon, 18 Aug 2014 02:26:25 -0700 (PDT)", "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tza9sm25087627wjc.29.2014.08.18.02.26.23 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Aug 2014 02:26:24 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=VmNd7f/hpwJPGcDPuJUUe8WeQw/F9anFb22WU+n45U0=;\n\tb=HTVyrYdfIStiDzKhNqNJIawi2mPgJEkktcgLti/MOQrmSJzbg4NcV5FCxeT8yujNDO\n\tMEPbIfxZUTgiqxMe72D1CkTrym4OQ2X/YWu4hobi7vBJc2Go5ahjksMgP0psmPoMYHmd\n\tgPnAE+B7bbIFe7lfORMyqhhZcK5q34xhJtm1u29p/GihWYscYfoexeoy37Di8EH/+a/T\n\tKJnRCdIzZuPwDEul8LTZlbitelbWXw8sQL13s+RKwCUYbP1QnoXssmbLvSioqh6NxiYP\n\trzypCf2UXunnFug92qHnS54WJ+Ns+W+eInXv/jWhDIQ7TsoMA+RIpMoiOnBdrXYimBQO\n\tgSBA==", "X-Gm-Message-State": "ALoCoQl43fN5BhCwOOqJMTyUUVxuWbJgm6YNsDIagkacuFNGe3CYOK0Cs615BUa3PlShc2ENcqOz", "X-Received": "by 10.194.184.166 with SMTP id ev6mr39639427wjc.61.1408353985114;\n\tMon, 18 Aug 2014 02:26:25 -0700 (PDT)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 18 Aug 2014 11:26:07 +0200", "Message-Id": "<1408353973-16663-2-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1408353973-16663-1-git-send-email-david.marchand@6wind.com>", "References": "<1408353973-16663-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH 1/7] app: simplify makefiles", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Mon, 18 Aug 2014 09:23:03 -0000" }, "content": "No need to test some build option multiple times in a Makefile.\nBesides, such option is needed by the associated app, so move it at the\ntop of the Makefile.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n app/cmdline_test/Makefile | 8 ++-\n app/dump_cfg/Makefile | 5 +-\n app/test-acl/Makefile | 9 ++--\n app/test-pipeline/Makefile | 26 +++++-----\n app/test-pmd/Makefile | 40 +++++++--------\n app/test/Makefile | 122 ++++++++++++++++++++++----------------------\n 6 files changed, 110 insertions(+), 100 deletions(-)", "diff": "diff --git a/app/cmdline_test/Makefile b/app/cmdline_test/Makefile\nindex 11c3aba..e9eafd2 100644\n--- a/app/cmdline_test/Makefile\n+++ b/app/cmdline_test/Makefile\n@@ -31,6 +31,8 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y)\n+\n #\n # library name\n #\n@@ -39,10 +41,12 @@ APP = cmdline_test\n #\n # all sources are stored in SRCS-y\n #\n-SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test.c\n-SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += commands.c\n+SRCS-y += cmdline_test.c\n+SRCS-y += commands.c\n \n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \n include $(RTE_SDK)/mk/rte.app.mk\n+\n+endif\ndiff --git a/app/dump_cfg/Makefile b/app/dump_cfg/Makefile\nindex 4c0714e..3257127 100644\n--- a/app/dump_cfg/Makefile\n+++ b/app/dump_cfg/Makefile\n@@ -40,7 +40,6 @@ CFLAGS += $(WERROR_FLAGS)\n SRCS-y := main.c\n \n # this application needs libraries first\n- DEPDIRS-y += lib\n-\n- include $(RTE_SDK)/mk/rte.app.mk\n+DEPDIRS-y += lib\n \n+include $(RTE_SDK)/mk/rte.app.mk\ndiff --git a/app/test-acl/Makefile b/app/test-acl/Makefile\nindex 00fa3b6..43dfdcb 100644\n--- a/app/test-acl/Makefile\n+++ b/app/test-acl/Makefile\n@@ -31,15 +31,18 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ifeq ($(CONFIG_RTE_LIBRTE_ACL),y)\n+\n APP = testacl\n \n CFLAGS += $(WERROR_FLAGS)\n \n # all source are stored in SRCS-y\n-SRCS-$(CONFIG_RTE_LIBRTE_ACL) := main.c\n+SRCS-y := main.c\n \n # this application needs libraries first\n-DEPDIRS-$(CONFIG_RTE_LIBRTE_ACL) += lib\n-\n+DEPDIRS-y += lib\n \n include $(RTE_SDK)/mk/rte.app.mk\n+\n+endif\ndiff --git a/app/test-pipeline/Makefile b/app/test-pipeline/Makefile\nindex 6cc0985..b81652f 100644\n--- a/app/test-pipeline/Makefile\n+++ b/app/test-pipeline/Makefile\n@@ -31,6 +31,8 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ifeq ($(CONFIG_RTE_LIBRTE_PIPELINE),y)\n+\n #\n # library name\n #\n@@ -46,21 +48,21 @@ endif\n #\n # all source are stored in SRCS-y\n #\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) := main.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += config.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += init.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += runtime.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_stub.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_hash.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_lpm.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_lpm_ipv6.c\n+SRCS-y := main.c\n+SRCS-y += config.c\n+SRCS-y += init.c\n+SRCS-y += runtime.c\n+SRCS-y += pipeline_stub.c\n+SRCS-y += pipeline_hash.c\n+SRCS-y += pipeline_lpm.c\n+SRCS-y += pipeline_lpm_ipv6.c\n \n # include ACL lib if available\n-ifeq ($(CONFIG_RTE_LIBRTE_ACL),y)\n-SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_acl.c\n-endif\n+SRCS-$(CONFIG_RTE_LIBRTE_ACL) += pipeline_acl.c\n \n # this application needs libraries first\n-DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += lib\n+DEPDIRS-y += lib\n \n include $(RTE_SDK)/mk/rte.app.mk\n+\n+endif\ndiff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile\nindex debf880..97dc2e6 100644\n--- a/app/test-pmd/Makefile\n+++ b/app/test-pmd/Makefile\n@@ -31,6 +31,8 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ifeq ($(CONFIG_RTE_TEST_PMD),y)\n+\n #\n # library name\n #\n@@ -46,25 +48,21 @@ endif\n #\n # all source are stored in SRCS-y\n #\n-SRCS-$(CONFIG_RTE_TEST_PMD) := testpmd.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += parameters.c\n-ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y)\n-SRCS-$(CONFIG_RTE_TEST_PMD) += cmdline.c\n-endif\n-SRCS-$(CONFIG_RTE_TEST_PMD) += config.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += iofwd.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += macfwd.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += macfwd-retry.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += macswap.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += flowgen.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += rxonly.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += txonly.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += csumonly.c\n-SRCS-$(CONFIG_RTE_TEST_PMD) += icmpecho.c\n-ifeq ($(CONFIG_RTE_LIBRTE_IEEE1588),y)\n-SRCS-$(CONFIG_RTE_TEST_PMD) += ieee1588fwd.c\n-endif\n-SRCS-$(CONFIG_RTE_TEST_PMD) += mempool_anon.c\n+SRCS-y := testpmd.c\n+SRCS-y += parameters.c\n+SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline.c\n+SRCS-y += config.c\n+SRCS-y += iofwd.c\n+SRCS-y += macfwd.c\n+SRCS-y += macfwd-retry.c\n+SRCS-y += macswap.c\n+SRCS-y += flowgen.c\n+SRCS-y += rxonly.c\n+SRCS-y += txonly.c\n+SRCS-y += csumonly.c\n+SRCS-y += icmpecho.c\n+SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c\n+SRCS-y += mempool_anon.c\n \n ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)\n CFLAGS_mempool_anon.o := -D_GNU_SOURCE\n@@ -72,6 +70,8 @@ endif\n CFLAGS_cmdline.o := -D_GNU_SOURCE\n \n # this application needs libraries first\n-DEPDIRS-$(CONFIG_RTE_TEST_PMD) += lib\n+DEPDIRS-y += lib\n \n include $(RTE_SDK)/mk/rte.app.mk\n+\n+endif\ndiff --git a/app/test/Makefile b/app/test/Makefile\nindex 0024737..abb7426 100644\n--- a/app/test/Makefile\n+++ b/app/test/Makefile\n@@ -31,6 +31,8 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ifeq ($(RTE_CONFIG_APP_TEST),y)\n+\n #\n # library name\n #\n@@ -40,50 +42,50 @@ APP = test\n # all sources are stored in SRCS-y\n #\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) := commands.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_pci.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_prefetch.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_byteorder.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_per_lcore.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_atomic.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_malloc.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_cycles.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_spinlock.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_memory.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_memzone.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_ring.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_table.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_table_pipeline.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_table_tables.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_table_ports.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_table_combined.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_table_acl.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_ring_perf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_rwlock.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_timer.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_mempool.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_mempool_perf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_mbuf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_logs.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_memcpy.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_memcpy_perf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_hash.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_hash_perf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_lpm.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_lpm6.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_debug.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_errno.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_tailq.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_string_fns.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_mp_secondary.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_cpuflags.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_eal_flags.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_alarm.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_interrupts.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_version.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_eal_fs.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_func_reentrancy.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_cmdline.c\n+SRCS-y += test.c\n+SRCS-y += test_pci.c\n+SRCS-y += test_prefetch.c\n+SRCS-y += test_byteorder.c\n+SRCS-y += test_per_lcore.c\n+SRCS-y += test_atomic.c\n+SRCS-y += test_malloc.c\n+SRCS-y += test_cycles.c\n+SRCS-y += test_spinlock.c\n+SRCS-y += test_memory.c\n+SRCS-y += test_memzone.c\n+SRCS-y += test_ring.c\n+SRCS-y += test_table.c\n+SRCS-y += test_table_pipeline.c\n+SRCS-y += test_table_tables.c\n+SRCS-y += test_table_ports.c\n+SRCS-y += test_table_combined.c\n+SRCS-y += test_table_acl.c\n+SRCS-y += test_ring_perf.c\n+SRCS-y += test_rwlock.c\n+SRCS-y += test_timer.c\n+SRCS-y += test_mempool.c\n+SRCS-y += test_mempool_perf.c\n+SRCS-y += test_mbuf.c\n+SRCS-y += test_logs.c\n+SRCS-y += test_memcpy.c\n+SRCS-y += test_memcpy_perf.c\n+SRCS-y += test_hash.c\n+SRCS-y += test_hash_perf.c\n+SRCS-y += test_lpm.c\n+SRCS-y += test_lpm6.c\n+SRCS-y += test_debug.c\n+SRCS-y += test_errno.c\n+SRCS-y += test_tailq.c\n+SRCS-y += test_string_fns.c\n+SRCS-y += test_mp_secondary.c\n+SRCS-y += test_cpuflags.c\n+SRCS-y += test_eal_flags.c\n+SRCS-y += test_alarm.c\n+SRCS-y += test_interrupts.c\n+SRCS-y += test_version.c\n+SRCS-y += test_eal_fs.c\n+SRCS-y += test_func_reentrancy.c\n+SRCS-y += test_cmdline.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_num.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_etheraddr.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_portlist.c\n@@ -91,25 +93,23 @@ SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_ipaddr.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_cirbuf.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_string.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_lib.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_red.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_sched.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_meter.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_kni.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_power.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_common.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_timer_perf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_ivshmem.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_distributor.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_distributor_perf.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += test_devargs.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c\n-SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c\n-ifeq ($(CONFIG_RTE_APP_TEST),y)\n+SRCS-y += test_red.c\n+SRCS-y += test_sched.c\n+SRCS-y += test_meter.c\n+SRCS-y += test_kni.c\n+SRCS-y += test_power.c\n+SRCS-y += test_common.c\n+SRCS-y += test_timer_perf.c\n+SRCS-y += test_ivshmem.c\n+SRCS-y += test_distributor.c\n+SRCS-y += test_distributor_perf.c\n+SRCS-y += test_devargs.c\n+SRCS-y += virtual_pmd.c\n+SRCS-y += packet_burst_generator.c\n SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c\n SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) += test_kvargs.c\n-endif\n \n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n@@ -130,6 +130,8 @@ endif\n CFLAGS += -D_GNU_SOURCE\n \n # this application needs libraries first\n-DEPDIRS-$(CONFIG_RTE_APP_TEST) += lib\n+DEPDIRS-y += lib\n \n include $(RTE_SDK)/mk/rte.app.mk\n+\n+endif\n", "prefixes": [ "dpdk-dev", "1/7" ] }